8000 MWPW-162722: Sticky promo banner loading issue by sivasadobe · Pull Request #3263 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MWPW-162722: Sticky promo banner loading issue #3263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 9, 2025
Merged

MWPW-162722: Sticky promo banner loading issue #3263

merged 3 commits into from
Jan 9, 2025

Conversation

sivasadobe
Copy link
Contributor
@sivasadobe sivasadobe commented Nov 26, 2024 •
edited
Loading
  • Fixed sticky top promo banner that hides under breadcrumbs while scrolling.
  • Fixed sticky bottom promo banner not being visible when no-delay option is obtained.

Resolves: MWPW-162722

Test URLs:

Milo

CC
Promo Sticky Top

Promo Sticky Bottom

@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Nov 26, 2024 •
edited
Loading
Page Scores Audits Google
📱 /drafts/siva/162722/bf-promo-pepe-banner PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/siva/162722/bf-promo-pepe-banner PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov Codecov
Copy link
codecov bot commented Nov 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.38%. Comparing ba 8000 se (6f4d98c) to head (00feea1).
Report is 174 commits behind head on stage.

Additional details and impacted files 
@@            Coverage Diff             @@
##            stage    #3263      +/-   ##
==========================================
+ Coverage   96.37%   96.38%   +0.01%     
==========================================
  Files         245      245              
  Lines       56716    56735      +19     
==========================================
+ Hits        54661    54685      +24     
+ Misses       2055     2050       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

overmyheadandbody
overmyheadandbody reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor
@overmyheadandbody overmyheadandbody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok, but I don't see a banner for the sticky top test page, could you add one for reference?

@sivasadobe
Copy link
Contributor Author
sivasadobe commented Dec 11, 2024 •
edited
Loading

@overmyheadandbody, To check the top sticky banner, use the test pages below, I have updated the same in the PR description as well.

Before: https://main--cc--adobecom.hlx.page/drafts/siva/162722/elements-family?martech=off
After: https://main--cc--adobecom.hlx.page/drafts/siva/162722/elements-family?milolibs=mwpw-162722--milo--sivasadobe&martech=off

@github-actions GitHub Actions
Copy link
Contributor

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added Stale and removed Stale labels Dec 24, 2024
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jan 1, 2025

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added the Stale label Jan 1, 2025
@spadmasa spadmasa removed the Stale label Jan 3, 2025
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jan 7, 2025

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@asonnalagi
Copy link

Verified the fix. Test results are in the task MWPW-164046

@spadmasa spadmasa added verified PR has been E2E tested by a reviewer Ready for Stage labels Jan 8, 2025
@milo-pr-merge milo-pr-merge bot merged commit 73cb4e7 into adobecom:stage Jan 9, 2025
25 checks passed
@milo-pr-merge milo-pr-merge bot mentioned this pull request Jan 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overmyheadandbody overmyheadandbody overmyheadandbody approved these changes

@mokimo mokimo mokimo approved these changes

@salonijain3 salonijain3 Awaiting requested review from salonijain3

@aishwaryamathuria aishwaryamathuria Awaiting requested review from aishwaryamathuria

@drashti1712 drashti1712 Awaiting requested review from drashti1712

@Ruchika4 Ruchika4 Awaiting requested review from Ruchika4

@suhjainadobe suhjainadobe Awaiting requested review from suhjainadobe

@JasonHowellSlavin JasonHowellSlavin Awaiting requested review from JasonHowellSlavin

Assignees

@spadmasa spadmasa

@asonnalagi asonnalagi

Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sivasadobe @asonnalagi @overmyheadandbody @mokimo @spadmasa
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
0