generated from adobe/aem-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 192
MWPW-163479: MAS - Switch to Spectrum CSS from SWC #3289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
79 commits
Select commit
Hold shift + click to select a range
2ae5836
MWPW-162385 add wcsApiKey attribute
npeltier 541f98e
Merge branch 'stage' of github.com:adobecom/milo into MWPW-162385
npeltier e445eed
MWPW-161355: Update MAS documentation (#3135)
yesil b99fc0e
Merge branch 'ccd' into MWPW-162385
npeltier 935341c
MWPW-161845: basic analytics on mas cards (#3206)
3ch023 6f22877
MWPW-159191: MAS Freyja support (#3209)
yesil da55e2f
MWPW-161804: Merch card style auditing (#3216)
Axelcureno ec2d95f
Added space after price recurrence label for display-per-unit prices …
st-angelo-adobe 08c281e
Merge branch 'main' of github.com:adobecom/milo into MWPW-162385
npeltier 2dd8fd8
adding example
npeltier df69264
Merge branch 'ccd' of github.com:adobecom/milo into MWPW-162385
npeltier 4c688d0
MWPW-162933: merge mas modules (#3248)
yesil f9680ce
MWPW-160755 - add tests for CCD cards (#3256)
afmicka 2b8083b
Merge branch 'ccd' of github.com:adobecom/milo into MWPW-162385
npeltier 3bcaa80
MWPW-162385 add wcsApiKey attribute (#3203)
afmicka 211c7d4
MWPW-163041: analytics fix (#3257)
3ch023 bcaa237
Fix overriding of border style on merch cards (#3278)
st-angelo-adobe 94a424e
Bump timeout from 2 to 10 sec (#3282)
3ch023 ea01ee0
MWPW-163479: Switch to Spectrum CSS from SWC
yesil 0155146
update doc style
yesil e904710
update doc style
yesil 8ef2ecf
update doc style
yesil 176d1f7
update doc style
yesil 6fbef16
update doc style
yesil 6d87b20
update doc style
yesil 0d8ca95
Update styles
yesil a52d00a
update docs
yesil f50bfa9
Keep SWC logic as an option
yesil 49ae33e
MWPW-161645: lana logging for CCD (#3271)
yesil 2fb80c9
fix gaps with Spectrum CSS support
yesil 6ecca9a
Merge remote-tracking branch 'upstream/ccd' into MWPW-163479
yesil 7877dbf
update version
yesil 1946ac7
fix gaps reported by ccd teamm
yesil 17d0906
address gaps
yesil 3ffabfa
address gaps
yesil fa5d083
address gaps
yesil 1bad4d2
address gaps
yesil cae858b
address gaps
yesil baf80b4
fix for MWPW-163718
yesil c79ce78
addressed design gaps.
yesil c5f27bf
bump the version
yesil 68a4328
Merge remote-tracking branch 'upstream/stage' into ccd
3ch023 dc0f9c7
add build artifacts
3ch023 796ef80
Update colors based on CCD app
yesil f05b400
Update colors based on CCD app
yesil 528817d
build without source maps
yesil f738897
Merge branch 'ccd' of github.com:adobecom/milo into MWPW-163479
yesil 5b9a917
update Nala tests
afmicka 584bc90
fix lint
afmicka 0fe6648
reset box-sizing for merch-card elements
yesil a92795d
Merge branch 'MWPW-163479' of github.com:adobecom/milo into MWPW-163479
yesil ef8bf8d
Force box-sizing on merch-card
yesil 1542e75
update styles: box-sizing
yesil 7d39fd0
Merge branch 'stage' of github.com:adobecom/milo into MWPW-163479
yesil 6207c0f
fix ccd gallery
yesil da77c52
update version
yesil d52f154
limit ccd price style to their variants
yesil 4f632c2
limit ccd price style to suggest variant
yesil 3b5f734
preserve white spaces in prices section
yesil 8235b2a
fix spacing in price
yesil 89a2a94
Update version
yesil 1623cae
Update doc
yesil 145627c
update cards
yesil 6b8e8da
update gallery styles
yesil 3cd086a
make the gallery responsive
yesil b170145
align slice card ctas
yesil ced06ed
cards resize responsively
yesil c2bdc87
fix 1x of gap issue
yesil a7b12d7
fix description text alignement
yesil 2c01de0
fix gaps in minimal widths
yesil 355e8eb
fix the gallery layout
yesil e6f5508
Merge branch 'stage' of github.com:adobecom/milo into MWPW-163479
yesil d8803ca
Fix strikethrough price color in promos
yesil abb166f
Update nala tests
yesil 1f414a6
MWPW-164177: clean up card style on fragment
yesil 4127767
Added a new section to ccd gallery
yesil 5d812fa
update mas version
yesil 69cfa63
fix missing default spectrum css button style
yesil e4856cb
Merge branch 'stage' of github.com:adobecom/milo into MWPW-163479
yesil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated sugg
2C5B
estions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably mention it in
mas
ormas.js
documentation, that consumer needs to bring their spectrum cssThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is this already
https://github.com/adobecom/milo/pull/3289/files#diff-d6a960cce00021b9cdcd7700511c82fae250fb5ac37601f38cefe135814f66a7R9
And we have ccd gallery as an example with Spectrum CSS. Do you think we need to provide more details?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, you are right, its fine for now.
i think in future i want to contribute some 'Getting Started' tutorial, with simple 4 steps, there we can mention it. Smthg like
</mas-commerce-service>
</merch-card>
for dev's running POC it will be great to not need to go through whole doc. But this is a plan for later, not for this PR