8000 Add unc activity feed support for standalone gnav by bandana147 · Pull Request #3386 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add unc activity feed support for standalone gnav #3386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Add unc activity feed support for standalone gnav #3386

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bfabc70
Ading uncConfig for unav
bandana147 Dec 13, 2024
54fb5a7
Ading uncConfig for unav
bandana147 Dec 13, 2024
0f7d9d3
Lint fix
bandana147 Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion libs/blocks/global-navigation/global-navigation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,14 @@ export const CONFIG = {
appswitcher: { name: 'app-switcher' },
notifications: {
name: 'notifications',
attributes: { notificationsConfig: { applicationContext: { appID: getConfig().unav?.uncAppId || 'adobecom' } } },
attributes: {
notificationsConfig: {
applicationContext: {
appID: getConfig().unav?.uncAppId || 'adobecom',
...getConfig().unav?.uncConfig,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bandana147 - by doing this we're allowing consumers to provide whatever configuration they desire. Are we handling all corner cases and exceptions that could appear?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @narcis-radu, the requirement is specific to Adobe Home and came up urgently(Jan 9th as prod). Currently, we don’t have the activity feed implemented on any Milo pages, so it has been agreed that the testing will be owned by them. For existing clients, since they won’t be sending this value, it shouldn’t have any impact.

I have created a ticket to monitor any potential issues.

cc: @salonijain3

},
},
},
},
help: {
name: 'help',
Expand Down
Loading
0