10000 fix(Mwpw-163747):fix for accessibility bugs. by sharath-kannan · Pull Request #3381 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(Mwpw-163747):fix for accessibility bugs. #3381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 9, 2025
Merged

fix(Mwpw-163747):fix for accessibility bugs. #3381

merged 5 commits into from
Jan 9, 2025

Conversation

sharath-kannan
Copy link
Contributor
@sharath-kannan sharath-kannan commented Dec 16, 2024 •
edited
Loading

@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Dec 16, 2024 •
edited
Loading
Page Scores Audits Google
📱 /drafts/sharathkannan/video-accessibility/brick-rounded-corners?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/sharathkannan/video-accessibility/brick-rounded-corners?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov Codecov
Copy link
codecov bot commented Dec 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.45%. Comparing base (82694a3) to head (1eb362b).
Report is 7 commits behind head on stage.

Additional details and impacted files 
@@            Coverage Diff             @@
##            stage    #3381      +/-   ##
==========================================
- Coverage   96.46%   96.45%   -0.01%     
==========================================
  Files         255      255              
  Lines       59363    59364       +1     
==========================================
- Hits        57266    57262       -4     
- Misses       2097     2102       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spadmasa spadmasa self-assigned this Dec 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@sharath-kannan
Copy link
Contributor Author

Other test urls.

Test url for MWPW-163520
-before: https://stage-milosh--sharath-kannan.hlx.page/drafts/ramuntea/accessibility/video-use-cases?martech=off#brick-1
-after: https://mwpw-163747--milosh--sharath-kannan.hlx.page/drafts/ramuntea/accessibility/video-use-cases?martech=off#brick-1

Test url for MWPW-163985

-before: https://www.stage.adobe.com/acrobat/business/generative-ai.html?martech=off
-after: https://www.stage.adobe.com/acrobat/business/generative-ai.html?milolibs=MWPW-163747--milosh--sharath-kannan&martech=off

@github-actions GitHub Actions
Copy link
Contributor

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added the Stale label Dec 25, 2024
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jan 1, 2025

Closing this PR due to inactivity.

@github-actions github-actions bot closed this Jan 1, 2025
@sharath-kannan sharath-kannan reopened this Jan 2, 2025
@github-actions github-actions bot removed the Stale label Jan 3, 2025
@spadmasa
Copy link
spadmasa commented Jan 8, 2025

Validation has been done on the pr :
https://mwpw-163747--milosh--sharath-kannan.hlx.page/drafts/rclayton/test/buy-elements-bundle-sample?martech=off
image
https://mwpw-163747--milosh--sharath-kannan.hlx.page/drafts/ramuntea/accessibility/video-use-cases?martech=off#brick-1
image
https://mwpw-163747--milosh--sharath-kannan.hlx.page/drafts/sharathkannan/video-accessibility/brick-rounded-corners

https://www.stage.adobe.com/acrobat/business/generative-ai.html?milolibs=MWPW-163747--milosh--sharath-kannan&martech=off
image

@spadmasa spadmasa added verified PR has been E2E tested by a reviewer Ready for Stage labels Jan 8, 2025
@milo-pr-merge milo-pr-merge bot merged commit a8222fd into adobecom:stage Jan 9, 2025
24 checks passed
@milo-pr-merge milo-pr-merge bot mentioned this pull request Jan 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bandana147 bandana147 bandana147 approved these changes

@drashti1712 drashti1712 drashti1712 approved these changes

@suhjainadobe suhjainadobe suhjainadobe approved these changes

@rgclayton rgclayton Awaiting requested review from rgclayton rgclayton is a code owner

@salonijain3 salonijain3 Awaiting requested review from salonijain3

@overmyheadandbody overmyheadandbody Awaiting requested review from overmyheadandbody

Assignees

@spadmasa spadmasa

Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sharath-kannan @spadmasa @bandana147 @drashti1712 @suhjainadobe
0