MWPW-164227 add checkmark animation on successful form submit #3397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3397 +/- ##
==========================================
- Coverage 96.48% 96.46% -0.03%
==========================================
Files 254 255 +1
Lines 59031 59280 +249
==========================================
+ Hits 56954 57182 +228
- Misses 2077 2098 +21 ☔ View full report in Codecov by Sentry. |
|
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
qiyundai
reviewed
Dec 27, 2024
qiyundai
approved these changes
Dec 27, 2024
mokimo
approved these changes
Dec 30, 2024
|
Reminder to set the |
fullcolorcoder
approved these changes
Jan 6, 2025
hadobe
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions ca
2C50
nnot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add config option to show checkmark on a successful form submission within a modal & close the modal.
Resolves: MWPW-164227
Test URLs:
Express
Before: https://faas-event--express-milo--adobecom.hlx.page/in/express/#sales-contact-form-1
After: https://faas-event--express-milo--adobecom.hlx.page/in/express/?milolibs=vhargrave-MWPW-164227-milo-faas#sales-contact-form-1
Before: https://faas-event--express-milo--adobecom.hlx.page/drafts/vhargrave/modal-with-redirect
After: https://faas-event--express-milo--adobecom.hlx.page/drafts/vhargrave/modal-with-redirect?milolibs=vhargrave-MWPW-164227-milo-faas
CC Form in Modal (works the same since this is opt in)
BACOM (works the same since this is opt in)