8000 MWPW-161867: Add http check to preflight by JasonHowellSlavin · Pull Request #3438 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MWPW-161867: Add http check to preflight #3438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 28, 2025
Merged

MWPW-161867: Add http check to preflight #3438

merged 5 commits into from
Jan 28, 2025

Conversation

JasonHowellSlavin
Copy link
Contributor
  • Adds a data attribute to links if the link was authored with http instead of https
  • Adds error messaging in preflight if the http data attribute is found

Resolves: MWPW-161867

Test URLs:

@JasonHowellSlavin JasonHowellSlavin added run-nala Run Nala Test Automation against PR needs-verification PR requires E2E testing by a reviewer labels Jan 8, 2025
@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Jan 8, 2025 •
edited
Loading
Page Scores Audits Google
📱 /drafts/slavin/bacom-pages/rtcdp?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/slavin/bacom-pages/rtcdp?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov Codecov
Copy link
codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (a4101ed) to head (928aefb).
Report is 25 commits behind head on stage.

Additional details and impacted files 
@@            Coverage Diff             @@
##            stage    #3438      +/-   ##
==========================================
- Coverage   96.47%   96.46%   -0.02%     
==========================================
  Files         260      260              
  Lines       60415    60416       +1     
==========================================
- Hits        58284    58278       -6     
- Misses       2131     2138       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jan 9, 2025

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@skumar09
Copy link
Contributor
skumar09 commented Jan 9, 2025

@JasonHowellSlavin : Nala tests are run by default on pr branches, so we no longer require run-nala label

@JasonHowellSlavin JasonHowellSlavin removed the run-nala Run Nala Test Automation against PR label Jan 9, 2025
@JasonHowellSlavin JasonHowellSlavin force-pushed the add-http-check-to-preflight branch from 9f63ed0 to a5fb0d1 Compare January 9, 2025 18:59
narcis-radu
narcis-radu reviewed Jan 13, 2025
View reviewed changes
@Dli3 Dli3 added verified PR has been E2E tested by a reviewer Ready for Stage and removed needs-verification PR requires E2E testing by a reviewer labels Jan 17, 2025
@milo-pr-merge
Copy link
Contributor
milo-pr-merge bot commented Jan 17, 2025

Skipped merging 3438: MWPW-161867: Add http check to preflight due to failing checks

@JasonHowellSlavin JasonHowellSlavin force-pushed the add-http-check-to-preflight branch from 07a682f to fba9f56 Compare January 17, 2025 21:11
@milo-pr-merge
Copy link
Contributor
milo-pr-merge bot commented Jan 19, 2025

Skipped merging 3438: MWPW-161867: Add http check to preflight due to failing checks

1 similar comment
@milo-pr-merge
Copy link
Contributor
milo-pr-merge bot commented Jan 20, 2025

Skipped merging 3438: MWPW-161867: Add http check to preflight due to failing checks

@milo-pr-merge
Copy link
Contributor
milo-pr-merge bot commented Jan 20, 2025

Skipped merging 3438: MWPW-161867: Add http check to preflight due to failing or running checks

1 similar comment
@milo-pr-merge
Copy link
Contributor
milo-pr-merge bot commented Jan 21, 2025

Skipped merging 3438: MWPW-161867: Add http check to preflight due to failing or running checks

@JasonHowellSlavin JasonHowellSlavin force-pushed the add-http-check-to-preflight branch from b98fc90 to 928aefb Compare January 21, 2025 18:02
@milo-pr-merge
Copy link
Contributor
milo-pr-merge bot commented Jan 21, 2025

Skipped merging 3438: MWPW-161867: Add http check to preflight due to insufficient approvals. Required: 2 approvals

@milo-pr-merge
Copy link
Contributor
8000
milo-pr-merge bot commented Jan 22, 2025

Skipped merging 3438: MWPW-161867: Add http check to preflight due to insufficient approvals. Required: 2 approvals

1 similar comment
@milo-pr-merge
Copy link
Contributor
milo-pr-merge bot commented Jan 27, 2025

Skipped merging 3438: MWPW-161867: Add http check to preflight due to insufficient approvals. Required: 2 approvals

@milo-pr-merge milo-pr-merge bot merged commit 4799a61 into adobecom:stage Jan 28, 2025
14 checks passed
@milo-pr-merge milo-pr-merge bot mentioned this pull request Jan 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meganthecoder meganthecoder meganthecoder approved these changes

@rgclayton rgclayton Awaiting requested review from rgclayton 6B58

@overmyheadandbody overmyheadandbody Awaiting requested review from overmyheadandbody

@narcis-radu narcis-radu Awaiting requested review from narcis-radu

@mokimo mokimo Awaiting requested review from mokimo

Assignees

@Dli3 Dli3

Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JasonHowellSlavin @skumar09 @narcis-radu @meganthecoder @mokimo @Dli3
0