8000 fix(mwpw-163900):Z-index of play/pause adjusted for interactive marquee. by sharath-kannan · Pull Request #3455 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(mwpw-163900):Z-index of play/pause adjusted for interactive marquee. #3455

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 28, 2025

Conversation

sharath-kannan
Copy link
Contributor
@sharath-kannan sharath-kannan commented Jan 10, 2025
  • The play/pause icon on videos are not clickable in interactive marquee because of an additional layer.
  • Increasing the z-index fixes the issue.

Resolves: MWPW-163900
MWPW-164886
MWPW-165643

Test URLs:

Copy link
codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (b1351a6) to head (4b574d8).
Report is 37 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3455      +/-   ##
==========================================
- Coverage   96.48%   96.47%   -0.02%     
==========================================
  Files         256      256              
  Lines       60101    60101              
==========================================
- Hits        57989    57982       -7     
- Misses       2112     2119       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spadmasa spadmasa self-assigned this Jan 10, 2025
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

Copy link
Contributor
aem-code-sync bot commented Jan 15, 2025

@spadmasa spadmasa added verified PR has been E2E tested by a reviewer Ready for Stage labels Jan 28, 2025
@milo-pr-merge milo-pr-merge bot merged commit 1a89b44 into adobecom:stage Jan 28, 2025
23 checks passed
@milo-pr-merge milo-pr-merge bot mentioned this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0