8000 MWPW-164871 Milo Products Catalog - A11Y - Elements must meet minimum… by bozojovicic · Pull Request #3459 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MWPW-164871 Milo Products Catalog - A11Y - Elements must meet minimum… #3459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 23, 2025
Merged

MWPW-164871 Milo Products Catalog - A11Y - Elements must meet minimum… #3459

merged 7 commits into from
Jan 23, 2025

Conversation

bozojovicic
Copy link
Contributor
@bozojovicic bozojovicic commented Jan 10, 2025 •
edited
Loading

… color contrast ratio thresholds

Fix color contrast ratio for "REFINE YOUR RESULTS" label on Catalog page. With this change it will be 4.54:1.
4.5:1 is the minimum, it was 4.47:1 before my change

Resolves: MWPW-164871

Test URLs:

MWPW-164871 Milo Products Catalog - A11Y - Elements must meet minimum…
< 8000 /div>
cbca0bd 
… color contrast ratio thresholds
@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Jan 10, 2025 •
edited
Loading
Page Scores Audits Google
📱 /drafts/bozo/price-cta?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/bozo/price-cta?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@bozojovicic bozojovicic marked this pull request as ready for review January 10, 2025 15:59
@codecov Codecov
Copy link
codecov bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (a4101ed) to head (9a623ec).
Report is 9 commits behind head on stage.

Additional details and impacted files 
@@           Coverage Diff           @@
##            stage    #3459   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files         260      260           
  Lines       60415    60415           
=======================================
  Hits        58284    58284           
  Misses       2131     2131

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@Roycethan Roycethan added verified PR has been E2E tested by a reviewer Ready for Stage labels Jan 16, 2025
@milo-pr-merge
Copy link
Contributor
milo-pr-merge bot commented Jan 20, 2025

Skipped 3459: "MWPW-164871 Milo Products Catalog - A11Y - Elements must meet minimum…" due to file "libs/deps/mas/merch-sidenav.js" overlap. Merging will be attempted in the next batch

1 similar comment
@milo-pr-merge
Copy link
Contributor
milo-pr-merge bot commented Jan 21, 2025

Skipped 3459: "MWPW-164871 Milo Products Catalog - A11Y - Elements must meet minimum…" due to file "libs/deps/mas/merch-sidenav.js" overlap. Merging will be attempted in the next batch

@milo-pr-merge milo-pr-merge bot merged commit b114709 into adobecom:stage Jan 23, 2025
14 checks passed
@milo-pr-merge milo-pr-merge bot mentioned this pull request Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narcis-radu narcis-radu narcis-radu approved these changes

@3ch023 3ch023 3ch023 approved these changes

Assignees
No one assigned
Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bozojovicic @narcis-radu @3ch023 @Roycethan
0