8000 [Release] Stage to Main by milo-pr-merge[bot] · Pull Request #3478 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Release] Stage to Main #3478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 15, 2025
Merged

[Release] Stage to Main #3478

merged 3 commits into from
Jan 15, 2025

Conversation

seanchoi-dev and others added 2 commits January 14, 2025 09:15
* Setting aria-live to shadowRoot element instead to the slot.

* Update unit test.

* Adding escape in case there is no resultText.

* Moving the aria-live code to mas
* List accessibility for quiz-marquee
<!-- Before submitting, please review all open PRs. -->

* Update quiz-marquee authoring to denote nested lists
* roles for list and listitem in quiz-marquee and quiz-results

Resolves: [MWPW-165027](https://jira.corp.adobe.com/browse/165027-NUMBER)

* PR feedback
@milo-pr-merge
Copy link
Contributor Author
milo-pr-merge bot commented Jan 14, 2025

Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot

Copy link
Contributor
aem-code-sync bot commented Jan 14, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor
aem-code-sync bot commented Jan 14, 2025
Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (746f58e) to head (95d3ce2).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3478      +/-   ##
==========================================
- Coverage   96.46%   96.46%   -0.01%     
==========================================
  Files         255      255              
  Lines       59431    59430       -1     
==========================================
- Hits        57330    57329       -1     
  Misses       2101     2101              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

@milo-pr-merge milo-pr-merge bot merged commit a61dc66 into main Jan 15, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
< 4B92 div aria-live="polite">
None yet
Development

Successfully merging this pull request may close these issues.

8 participants
0