8000 Add arrow icon by rgclayton · Pull Request #3571 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add arrow icon #3571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2025
Merged

Add arrow icon #3571

merged 1 commit into from
Jan 29, 2025

Conversation

rgclayton
Copy link
Contributor
@rgclayton rgclayton commented Jan 28, 2025 •
edited
Loading
  • Re-add arrow used for action items block

Will create a fast follow ticket for action-items to update arrow.

Related to: MWPW-161523

Test URLs:

@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Jan 28, 2025 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Jan 28, 2025 •
edited
Loading
Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov Codecov
Copy link
codecov bot commented Jan 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.49%. Comparing base (03e7505) to head (96e7dbb).
Report is 1 commits behind head on stage.

Additional details and impacted files 
@@            Coverage Diff             @@
##            stage    #3571      +/-   ##
==========================================
+ Coverage   96.48%   96.49%   +0.01%     
==========================================
  Files         260      260              
  Lines       60808    60808              
==========================================
+ Hits        58670    58678       +8     
+ Misses       2138     2130       -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

This PR does not qualify for the zero-impact label as it touches code outside of the allowed areas. The label is auto applied, do not manually apply the label.

AddumOne
AddumOne approved these changes Jan 29, 2025
View reviewed changes
Copy link
@AddumOne AddumOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rgclayton
Copy link
Contributor Author
rgclayton commented Jan 29, 2025 •
edited
Loading

Testing urls:
Before: https://main--milo--adobecom.hlx.page/drafts/rclayton/action-items?martech=off
After: https://add-arrow--milo--adobecom.hlx.page/drafts/rclayton/action-items?martech=off

@rgclayton rgclayton added Ready for Stage high priority Why is this a high priority? Blocker? Critical? Dependency? labels Jan 29, 2025
@qiyundai
Copy link
Contributor

We also happen to be using that icon 😅, and this fix will help resolve an issue on our pages: https://main--events-milo--adobecom.hlx.live/events/create-now/adobe-creative-cafe-san-francisco/san-francisco/ca/2025-02-06?milolibs=add-arrow. It would be great to get this in soon!

@spadmasa
Copy link

Verified the fix given in below url
https://add-arrow--milo--adobecom.hlx.page/drafts/rclayton/test/action-blocks
image
https://main--events-milo--adobecom.hlx.live/events/create-now/adobe-creative-cafe-san-francisco/san-francisco/ca/2025-02-06?milolibs=add-arrow
image

@spadmasa spadmasa self-assigned this Jan 29, 2025
@spadmasa spadmasa added the verified PR has been E2E tested by a reviewer label Jan 29, 2025
@overmyheadandbody overmyheadandbody merged commit 56128d6 into stage Jan 29, 2025
34 checks passed
@overmyheadandbody overmyheadandbody deleted the add-arrow branch January 29, 2025 16:36
@overmyheadandbody overmyheadandbody mentioned this pull request Jan 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabyamon sabyamon sabyamon approved these changes

@AddumOne AddumOne AddumOne approved these changes

@drashti1712 drashti1712 drashti1712 approved these changes

@qiyundai qiyundai qiyundai approved these changes

@sukamat sukamat sukamat approved these changes

@colloyd colloyd colloyd approved these changes

@robert-bogos robert-bogos robert-bogos approved these changes

Assignees

@spadmasa spadmasa

Labels
high priority Why is this a high priority? Blocker? Critical? Dependency? Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@rgclayton @qiyundai @spadmasa @sabyamon @AddumOne @drashti1712 @sukamat @colloyd @robert-bogos @overmyheadandbody
0