10000 Prevent a console error from the global navigation main menu by sharmrj · Pull Request #3625 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

Prevent a console error from the global navigation main menu #3625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 5, 2025
Merged

Prevent a console error from the global navigation main menu #3625

merged 3 commits into from
Feb 5, 2025

Conversation

sharmrj
Copy link
Contributor
@sharmrj sharmrj commented Feb 5, 2025

…/svg+xml;utf8 inorder to prevent a console error

  • In the main menu for the new mobile gnav a css url is used to load an svg. The svg was being treated as a plain url which caused a console error
  • Changed the url to have data:image/svg+xml;utf8; to prevent that

Test URLs:

qa: https://main--homepage--adobecom.hlx.live/homepage/index-loggedout?milolibs=svg-url

@sharmrj
updated an svg inside a url() in the globalnav css to have data:image…
aa8d31f 
…/svg+xml;utf8 inorder to prevent a console error
@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Feb 5, 2025 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Feb 5, 2025 •
edited
Loading
Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@spadmasa spadmasa self-assigned this Feb 5, 2025
@spadmasa
Copy link
spadmasa commented Feb 5, 2025 •
edited
Loading

Validation done on the PR ,console error which was shown when navigated to mobile mode is not seen now
https://www.adobe.com/
issue seen :
image

After the fix
https://main--homepage--adobecom.hlx.live/homepage/index-loggedout?milolibs=svg-url
image
in mobile mode console error on global navigation is not seen
image

@spadmasa spadmasa added verified PR has been E2E tested by a reviewer Ready for Stage labels Feb 5, 2025
@milo-pr-merge
Copy link
Contributor
milo-pr-merge bot commented Feb 5, 2025

Skipped merging 3625: Prevent a console error from the global navigation main menu due to failing or running checks

@milo-pr-merge milo-pr-merge bot merged commit 91fb8d4 into stage Feb 5, 2025
19 checks passed
@milo-pr-merge milo-pr-merge bot deleted the svg-url branch February 5, 2025 16:02
@milo-pr-merge milo-pr-merge bot mentioned this pull request Feb 5, 2025
Merged
salonijain3 added a commit that referenced this pull request Feb 5, 2025
@salonijain3
Revert "Prevent a console error from the global navigation main menu (#…
632ff04 
…3625)"

This reverts commit 91fb8d4.
@salonijain3 salonijain3 mentioned this pull request Feb 5, 2025
Merged
mokimo pushed a commit that referenced this pull request Feb 5, 2025
@salonijain3
Revert "Prevent a console error from the global navigation main menu" (…
bbbd2b5 
…#3629)

Revert "Prevent a console error from the global navigation main menu (#3625)"

This reverts commit 91fb8d4.
colloyd pushed a commit to colloyd/milo that referenced this pull request Feb 6, 2025
@sharmrj @colloyd
Prevent a console error from the global navigation main menu (adobeco…
679a8bc 
…m#3625)

* updated an svg inside a url() in the globalnav css to have data:image/svg+xml;utf8 inorder to prevent a console error

* changed a ; to a ,
colloyd pushed a commit to colloyd/milo that referenced this pull request Feb 6, 2025
@salonijain3 @colloyd
Revert "Prevent a console error from the global navigation main menu" (…
33edb67 
…adobecom#3629)

Revert "Prevent a console error from the global navigation main menu (adobecom#3625)"

This reverts commit 91fb8d4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salonijain3 salonijain3 salonijain3 approved these changes

@overmyheadandbody overmyheadandbody overmyheadandbody approved these changes

@Deva309 Deva309 Deva309 approved these changes

@sonawanesnehal3 sonawanesnehal3 sonawanesnehal3 approved these changes

@bandana147 bandana147 Awaiting requested review from bandana147

@nishantka nishantka Awaiting requested review from nishantka

Assignees

@spadmasa spadmasa

Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sharmrj @spadmasa @salonijain3 @overmyheadandbody @Deva309 @sonawanesnehal3
0