[MWPW-159581] Federal icons #3797
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
|
Nit. For the consumer pages listed it would be more helpful to see a page with the new icons on them. That would make it more quick to verify if there is a problem or not for consumers. I went ahead and created some sample pages for:
The federated icons are looking good on those two pages. |
There was a problem hiding this comment.
I tested two pages where we had csos in the past and they seem to be good! 🚀
https://main--dc--adobecom.aem.live/acrobat/acrobat-pro?martech=off&milolibs=federal-icons
https://main--cc--adobecom.aem.page/drafts/ramuntea/table-with-tooltip?martech=off&milolibs=federal-icons
In general I think you've done it. Just need to fix a few small things, and then we're over the finish line so amazing job!!
The biggest thing I saw that needs to be fixed though is:
Georouting seems to be off if there are tabs.
https://main--cc--adobecom.aem.page/drafts/ramuntea/table-with-tooltip?martech=off&milolibs=federal-icons&akamaiLocale=CH
Fixed the Georouting icon thing. Thanks for pointing out! |
|
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
|
Closing this PR due to inactivity. |
Good catch! It was a race condition when falling back to milo icons. I fixed it 👍 |
|
Heya, since this PR has been open since a while - could you leave some feedback on https://github.com/orgs/adobecom/discussions/4407 why/what is blocking this from proceeding? |
Left some feedback 👍 |
Victor is on extended leave and cannot review this
|
@robert-bogos Were you able to get all of the previous cso issues into a document to test against? |
|
Hi @rgclayton ! Not yet, but I'm about to set up a QEs meeting to go over all the previous related CSOs, and I'll construct that document for that. |
|
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
Description
Key points from this PR:
Centralized Icon Repository: A new /assets/icons/svgs directory was added to the /federal/ repo, allowing multiple sites (Milo and others) to use the same set of icons. All icons currently available are listed here /icons/icons.json
Consistent Authoring Notation: Authors will continue to use the current notation, such as
:icon-play:, to insert icons into content. This ensures a seamless transition with no change in authoring experience.Source Change: Icons will no longer be served from the Milo code-bus. Instead, they will be fetched from the federal repository. Only when an icon is not found on federal, it will fall back to fetching from the Milo code-bus.
Author Contributions: This new system enables authors to contribute and expand the icon set by adding new icons to the centralized repository, a feature that was previously unavailable.
Sidekick library: The Sidekick plugin library was updated to reflect the changes above and a search field was added to improve authoring accessibility on the icons tab.
Related Issue
Resolves: MWPW-159581
Testing instructions
Test URLs
Sidekick library:
Acrobat:
Express:
BACOM:
CC:
Homepage:
Blog:
Milo:
GNav Test URLs
Gnav + Footer + Region Picker modal:
Thin Gnav + ThinFooter + Region Picker dropup:
Localnav + Promo:
Sticky Branch Banner:
Inline Branch Banner:
Blog
RTL Locale