-
Notifications
You must be signed in to change notification settings - Fork 52
MWPW-174164: Catalog collection block Milo compatibility changes #754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks good to me, but in order to be able to merge it we need to either make it backwards-compatible (atm https://mwpw-174164--cc--adobecom.aem.live/products/catalog shows no sidenav) or make milo PR backwards compatible and merge milo one first
@3ch023 I implemented the compatibility changes with the stage branch, once validated, this can be merged first, then we can merge the Milo one. |
Skipped merging 754: MWPW-174164: Catalog collection block Milo compatibility changes due to missing verified label. kindly make sure that the PR has been verified |
@afmicka can you please confirm if this pr is verified and can be merged to stage ? |
@spadmasa yes, labeled the PR. Can be merged to stage |
The milo collection component was split into 2 (header + content). The collection block has had some changes as well, and the catalog/sidenav blocks need to be updated for that.
NOTE: This branch needs to be merged before the Milo one, it's compatible with the Milo stage branch as well.
Resolves: MWPW-174164
Test URLs: