8000 MWPW-174164: Catalog collection block Milo compatibility changes by st-angelo-adobe · Pull Request #754 · adobecom/cc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MWPW-174164: Catalog collection block Milo compatibility changes #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 8, 2025

Conversation

st-angelo-adobe
Copy link
Collaborator
@st-angelo-adobe st-angelo-adobe commented Jul 1, 2025

The milo collection component was split into 2 (header + content). The collection block has had some changes as well, and the catalog/sidenav blocks need to be updated for that.

NOTE: This branch needs to be merged before the Milo one, it's compatible with the Milo stage branch as well.

Resolves: MWPW-174164

Test URLs:

@st-angelo-adobe st-angelo-adobe requested a review from a team July 1, 2025 07:41
Copy link
aem-code-sync bot commented Jul 1, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
aem-code-sync bot commented Jul 1, 2025
Page Scores Audits Google
📱 /products/catalog?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /products/catalog?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor
@3ch023 3ch023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good to me, but in order to be able to merge it we need to either make it backwards-compatible (atm https://mwpw-174164--cc--adobecom.aem.live/products/catalog shows no sidenav) or make milo PR backwards compatible and merge milo one first

@st-angelo-adobe st-angelo-adobe changed the title MWPW-174164: Catalog collection block backward compatibility changes MWPW-174164: Catalog collection block Milo compatibility changes Jul 3, 2025
@st-angelo-adobe
Copy link
Collaborator Author

@3ch023 I implemented the compatibility changes with the stage branch, once validated, this can be merged first, then we can merge the Milo one.
After the Milo branch is merged, we should remove the redundant code in here (it will be a very small change)

@milo-pr-merge-cc
Copy link

Skipped merging 754: MWPW-174164: Catalog collection block Milo compatibility changes due to missing verified label. kindly make sure that the PR has been verified

@spadmasa
8000 Copy link
Collaborator
spadmasa commented Jul 8, 2025

@afmicka can you please confirm if this pr is verified and can be merged to stage ?

@afmicka
Copy link
afmicka commented Jul 8, 2025

@spadmasa yes, labeled the PR. Can be merged to stage

@milo-pr-merge-cc milo-pr-merge-cc bot merged commit 21200c1 into stage Jul 8, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0