[MWPW-172186] Phase 2 of accessibility fix for transition screen #460
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
As discussed lint issues are not related to this PR and will be fixed separately. |
|
verified |
|
Verified in desktop and iPhone.
temp.8.mov |
| } | ||
|
|
||
| updateProgressBar(layer, percentage) { | ||
| if (!this.progressText && TransitionScreen.lastProgressText) this.progressText = TransitionScreen.lastProgressText; |
| const newStatus = (this.progressText && this.progressText.trim() !== '') | ||
| ? this.progressText.replace('%', `${p}%`) | ||
| : `${p}%`; | ||
| if (status && status.textContent !== newStatus) status.textContent = newStatus; | ||
| } | ||
|
|
||
| createProgressBar() { |
There was a problem hiding this comment.
🚫 [eslint] <class-methods-use-this> reported by reviewdog 🐶
Expected 'this' to be used by class method 'createProgressBar'.
There was a problem hiding this comment.
🚫 [eslint] <no-param-reassign> reported by reviewdog 🐶
Assignment to function parameter 'delay'.
There was a problem hiding this comment.
🚫 [eslint] <no-param-reassign> reported by reviewdog 🐶
Assignment to function parameter 'i'.
There was a problem hiding this comment.
🚫 [eslint] <consistent-return> reported by reviewdog 🐶
Async method 'loadSplashFragment' expected no return value.
There was a problem hiding this comment.
🚫 [eslint] <no-use-before-define> reported by reviewdog 🐶
'cleanup' was used before it was defined.
There was a problem hiding this comment.
🚫 [eslint] <no-use-before-define> reported by reviewdog 🐶
'cleanup' was used before it was defined.
unity/unitylibs/scripts/transition-screen.js
Line 103 in b4a7ee7
We discussed other than the 1st issue other were not related to this PR. And the first issue is fixed and verified. cc @asonnalagi |
* #475 * #460 **Test URLs:** CC - Before: https://main--cc--adobecom.hlx.live/products/photoshop/online?unitylibs=main - After: https://main--cc--adobecom.hlx.live/products/photoshop/online?unitylibs=stage DC - Before: https://main--dc--adobecom.hlx.live/acrobat/online/compress?unitylibs=main - After: https://main--dc--adobecom.hlx.live/acrobat/online/compress?unitylibs=stage
* stage: IMS error logging improvement - Phase 1 (#493) [MWPW-173462] Loading screen: Text should not be marked as a heading (#487) Allow empty query (#488) Sending error object in addition to error message in case of IMS token failures (#486) [MWPW-174632] Getting 'unable to process the request' error toast for 'Empty File + Max File Size' upload for 2b/2c (#476) [MWPW-171797] Introduce timeout to all fetch calls being made (#484) Fix for workflow getting stuck at transition screen if asset api fails (#481) Fix CSS issues found during launch (#482) [MWPW-174834] Added pdf file support in ocr. Was a miss from the last PR. (#483) [MWPW-174834] Fallback to file extension if MIME type is absent for determining file type (#480) [MWPW-174783] Fix error message issue on Japanese page (#478) [MWPW-172186] Phase 2 of accessibility fix for transition screen (#460) # Conflicts: # unitylibs/core/workflow/workflow-acrobat/action-binder.js # unitylibs/utils/FileUtils.js
Resolves: MWPW-172186
To test this we need authoring update. This code is backward compatible so if authoring update is not done screen reader should still read just the percentage without text Loading Completed.
If the text Loading completed is authored it should read the loading completed text.
Please test it for ROW too at least T1 and few RTL locales.
Test URLs:
Pages without authoring update
CC
DC
Pages with authoring update:
These pages are from different branch as I had to update target config to load splash screen with updated authoring
CC
DC
Note: Also attaching updated splash screen word document for reference. Authoring is same as discussed and agreed upon in one of our meetings.
CC: https://main--cc--adobecom.hlx.page/drafts/ruchika/unity/splash-page/splashscreen11
DC: https://main--dc--adobecom.hlx.page/drafts/ruchika/unity/splash