-
Notifications
You must be signed in to change notification settings - Fork 9
Revert "[Release] Stage to Main" #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
🚫 [eslint] <key-spacing> reported by reviewdog 🐶
Extra space after key 'id'.
payload = {id : 'testid'}; |
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required before '}'.
payload = {id : 'testid'}; |
🚫 [eslint] <arrow-parens> reported by reviewdog 🐶
Expected parentheses around arrow function argument.
const imageBuffer = Uint8Array.from(atob(base64PDF), c => c.charCodeAt(0)); |
🚫 [eslint] <arrow-parens> reported by reviewdog 🐶
Expected parentheses around arrow function argument.
return new Promise(resolve => setTimeout(resolve, ms)); |
🚫 [eslint] <no-promise-executor-return> reported by reviewdog 🐶
Return values from promise executor functions cannot be read.
return new Promise(resolve => setTimeout(resolve, ms)); |
🚫 [eslint] <arrow-parens> reported by reviewdog 🐶
Expected parentheses around arrow function argument.
const imageBuffer = Uint8Array.from(atob(base64Image), c => c.charCodeAt(0)); |
Unexpected unnamed function.
describe('Unity Upload Block', function() { |
🚫 [eslint] <space-before-function-paren> reported by reviewdog 🐶
Missing space before function parentheses.
describe('Unity Upload Block', function() { |
🚫 [eslint] <no-restricted-syntax> reported by reviewdog 🐶
iterators/generators require regenerator-runtime, which is too heavyweight for this guide to allow them. Separately, loops should be avoided in favor of array iterations.
unity/unitylibs/blocks/healthcheck/healthcheck.js
Lines 13 to 17 in f44430e
for (const [categoryName, apis] of Object.entries(this.services)) { | |
const results = await this.checkCategory(categoryName, apis); | |
apiStatuses[categoryName] = results.results.reduce((max, res) => res.success ? max : Math.max(max, res.statusCode || 500), 200); | |
this.printResults(categoryName, results); | |
} |
🚫 [eslint] <no-await-in-loop> reported by reviewdog 🐶
Unexpected await
inside a loop.
const results = await this.checkCategory(categoryName, apis); |
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 134. Maximum allowed is 100.
apiStatuses[categoryName] = results.results.reduce((max, res) => res.success ? max : Math.max(max, res.statusCode || 500), 200); |
🚫 [eslint] <no-confusing-arrow> reported by reviewdog 🐶
Arrow function used ambiguously with a conditional expression.
apiStatuses[categoryName] = results.results.reduce((max, res) => res.success ? max : Math.max(max, res.statusCode || 500), 200); |
🚫 [eslint] <consistent-return> reported by reviewdog 🐶
Expected to return a value at the end of async method 'loadServices'.
async loadServices() { |
Unexpected console statement.
console.error('Error loading services:', error.message); |
🚫 [eslint] <class-methods-use-this> reported by reviewdog 🐶
Expected 'this' to be used by class method 'replacePlaceholders'.
replacePlaceholders(services, placeholder, value) { |
🚫 [eslint] <class-methods-use-this> reported by reviewdog 🐶
Expected 'this' to be used by class async method 'getBlobData'.
async getBlobData(options) { |
🚫 [eslint] <no-confusing-arrow> reported by reviewdog 🐶
Arrow function used ambiguously with a conditional expression.
unity/unitylibs/blocks/healthcheck/healthcheck.js
Lines 40 to 42 in f44430e
xhr.onload = () => xhr.status === 200 | |
? res({ ...options, body: xhr.response, headers: { 'Content-Type': 'image/jpeg' } }) | |
: rej(xhr.status); |
🚫 [eslint] <class-methods-use-this> reported by reviewdog 🐶
Expected 'this' to be used by class async method 'uploadPdf'.
async uploadPdf(options) { |
🚫 [eslint] <arrow-parens> reported by reviewdog 🐶
Expected parentheses around arrow function argument.
service.replaceKey.forEach(key => { |
🚫 [eslint] <no-return-assign> reported by reviewdog 🐶
Arrow function should not return assignment.
apis.forEach((_, i) => apis[i] = this.services[category][i]); |
🚫 [eslint] <radix> reported by reviewdog 🐶
Missing radix parameter.
return { name: service.name, status: 'DOWN', success: false, error: error.message, statusCode: parseInt(error.message.match(/\d+/)?.[0]) || 500 }; |
🚫 [eslint] <no-restricted-syntax> reported by reviewdog 🐶
iterators/generators require regenerator-runtime, which is too heavyweight for this guide to allow them. Separately, loops should be avoided in favor of array iterations.
for (const service of apis) results.push(await this.checkService(category, service, apis)); |
🚫 [eslint] <no-await-in-loop> reported by reviewdog 🐶
Unexpected await
inside a loop.
for (const service of apis) results.push(await this.checkService(category, service, apis)); |
🚫 [eslint] <chai-friendly/no-unused-expressions> reported by reviewdog 🐶
Expected an assignment or function call and instead saw an expression.
window.adobeIMS ? new HealthCheck(el) : window.addEventListener('onImsLibInstance', () => new HealthCheck(el), { once: true }); |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
unity/unitylibs/blocks/unity/unity.js
Line 13 in f44430e
return branch.indexOf('--') > -1 |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 2.
unity/unitylibs/blocks/unity/unity.js
Line 14 in f44430e
? `https://${branch}.${helixVersion}.live/unitylibs` |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
unity/unitylibs/blocks/unity/unity.js
Line 14 in f44430e
? `https://${branch}.${helixVersion}.live/unitylibs` |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 2.
unity/unitylibs/blocks/unity/unity.js
Line 15 in f44430e
: `https://${branch}--unity--adobecom.${helixVersion}.live/unitylibs`; |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
if(cfg.presentState.cache) { |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
unity/unitylibs/core/steps/app-connector.js
Lines 12 to 13 in f44430e
dataObj.href = cfg.preludeState.href | |
dataObj.payload.finalAssetUrl = cfg.preludeState.finalAssetUrl; |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
unity/unitylibs/core/steps/app-connector.js
Lines 15 to 16 in f44430e
dataObj.assetId = cfg.preludeState.assetId | |
dataObj.payload.finalAssetId = cfg.preludeState.finalAssetId; |
🚫 [eslint] <eqeqeq> reported by reviewdog 🐶
Expected '===' and instead saw '=='.
unity/unitylibs/core/steps/upload-btn.js
Line 33 in f44430e
if (['image/jpeg', 'image/png', 'image/jpg'].indexOf(file.type) == -1) { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 12 spaces but found 14.
unity/unitylibs/core/steps/upload-btn.js
Line 61 in f44430e
cfg.imgDisplay = 'landscape'; |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 12 spaces but found 14.
unity/unitylibs/core/steps/upload-btn.js
Line 62 in f44430e
if (!target.classList.contains(IMG_LANDSCAPE)) target.classList.add(IMG_LANDSCAPE); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 12 spaces but found 14.
unity/unitylibs/core/steps/upload-btn.js
Line 63 in f44430e
if (target.classList.contains(FULL_HEIGHT)) target.classList.remove(FULL_HEIGHT); |
🚫 [eslint] <eqeqeq> reported by reviewdog 🐶
Expected '===' and instead saw '=='.
unity/unitylibs/core/steps/upload-btn.js
Line 69 in f44430e
if (target.naturalWidth == targetElWidth && target.naturalHeight == targetElHeight) { |
🚫 [eslint] <eqeqeq> reported by reviewdog 🐶
Expected '===' and instead saw '=='.
unity/unitylibs/core/steps/upload-btn.js
Line 69 in f44430e
if (target.naturalWidth == targetElWidth && target.naturalHeight == targetElHeight) { |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
unity/unitylibs/core/steps/upload-btn.js
Line 95 in f44430e
a.addEventListener('click', () => input.click()); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'loadArea' is defined but never used.
|
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'loadImg' is defined but never used.
loadImg, |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
unity/unitylibs/core/workflow/workflow-acrobat/action-binder.js
Lines 20 to 21 in f44430e
'LPT7', 'LPT8', 'LPT9' | |
]); |
🚫 [eslint] <no-control-regex> reported by reviewdog 🐶
Unexpected control character(s) in regular expression: \x00, \x1f.
const INVALID_CHARS_REGEX = /[\x00-\x1F\\/:"*?<>|]/g; |
🚫 [eslint] <no-promise-executor-return> reported by reviewdog 🐶
Return values from promise executor functions cannot be read.
await new Promise((resolve) => setTimeout(resolve, 1000)); |
🚫 [eslint] <radix> reported by reviewdog 🐶
Missing radix parameter.
const retryDelay = parseInt(response.headers.get('retry-after')) || 5; |
🚫 [eslint] <arrow-parens> reported by reviewdog 🐶
Expected parentheses around arrow function argument.
await new Promise(resolve => setTimeout(resolve, retryDelay * 1000)); |
🚫 [eslint] <no-promise-executor-return> reported by reviewdog 🐶
Return values from promise executor functions cannot be read.
await new Promise(resolve => setTimeout(resolve, retryDelay * 1000)); |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'Authorization' found.
'Authorization': accessToken, |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
'x-api-key': 'unity', |
🚫 [eslint] <comma-spacing> reported by reviewdog 🐶
A space is required after ','.
fillsign: ['single','page-limit-100'], |
🚫 [eslint] <comma-spacing> reported by reviewdog 🐶
A space is required after ','.
'split-pdf': ['single', 'max-filesize-1-gb','split-pdf-page-limits','signedInallowedFileTypes'], |
🚫 [eslint] <comma-spacing> reported by reviewdog 🐶
A space is required after ','.
'split-pdf': ['single', 'max-filesize-1-gb','split-pdf-page-limits','signedInallowedFileTypes'], |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
unity/unitylibs/core/workflow/workflow-acrobat/action-binder.js
Lines 198 to 199 in f44430e
'chat-pdf-student': ['hybrid', 'allowed-filetypes-pdf-word-ppt-txt', 'page-limit-600', 'max-numfiles-10', 'max-filesize-100-mb'] | |
}; |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'error_generic' found.
'error_generic': 'verb_upload_error_generic', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'pre_upload_error_loading_verb_limits' found.
'pre_upload_error_loading_verb_limits': 'verb_upload_error_loading_verb_limits', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'pre_upload_error_empty_verb_limits' found.
'pre_upload_error_empty_verb_limits': 'verb_upload_error_empty_verb_limits', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'pre_upload_error_renaming_file' found.
'pre_upload_error_renaming_file': 'verb_upload_error_renaming_file', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'pre_upload_error_fetch_redirect_url' found.
'pre_upload_error_fetch_redirect_url': 'verb_upload_error_fetch_redirect_url', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_validate_files' found.
'validation_error_validate_files': 'verb_upload_error_validate_files', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_unsupported_type' found.
'validation_error_unsupported_type': 'verb_upload_error_unsupported_type', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_empty_file' found.
'validation_error_empty_file': 'verb_upload_error_empty_file', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_file_too_large' found.
'validation_error_file_too_large': 'verb_upload_error_file_too_large', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_only_accept_one_file' found.
'validation_error_only_accept_one_file': 'verb_upload_error_only_accept_one_file', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_file_same_type' found.
'validation_error_file_same_type': 'verb_upload_error_file_same_type', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_unsupported_type_multi' found.
'validation_error_unsupported_type_multi': 'verb_upload_error_unsupported_type_multi', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_empty_file_multi' found.
'validation_error_empty_file_multi': 'verb_upload_error_empty_file_multi', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_file_too_large_multi' found.
'validation_error_file_too_large_multi': 'verb_upload_error_file_too_large_multi', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_multiple_invalid_files' found.
'validation_error_multiple_invalid_files': 'verb_upload_error_multiple_invalid_files', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_max_num_files' found.
'validation_error_max_num_files': 'verb_upload_error_max_num_files', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_file_same_type_multi' found.
'validation_error_file_same_type_multi': 'verb_upload_error_file_same_type_multi', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_validation_error_max_page_count' found.
'upload_validation_error_max_page_count': 'verb_upload_error_max_page_count', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_validation_error_min_page_count' found.
'upload_validation_error_min_page_count': 'verb_upload_error_min_page_count', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_validation_error_verify_page_count' found.
'upload_validation_error_verify_page_count': 'verb_upload_error_verify_page_count', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_validation_error_max_page_count_multi' found.
'upload_validation_error_max_page_count_multi': 'verb_upload_error_max_page_count_multi', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_validation_error_duplicate_asset' found.
'upload_validation_error_duplicate_asset': 'verb_upload_error_duplicate_asset', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_error_max_quota_exceeded' found.
'upload_error_max_quota_exceeded': 'verb_upload_error_max_quota_exceeded', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_error_no_storage_provision' found.
'upload_error_no_storage_provision': 'verb_upload_error_no_storage_provision', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_error_chunk_upload' found.
'upload_error_chunk_upload': 'verb_upload_error_chunk_upload', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_error_finalize_asset' found.
'upload_error_finalize_asset': 'verb_upload_error_finalize_asset', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_error_redirect_to_app' found.
'upload_error_redirect_to_app': 'verb_upload_error_redirect_to_app', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_warn_chunk_upload' found.
'upload_warn_chunk_upload': 'verb_upload_warn_chunk_upload', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'pre_upload_warn_renamed_invalid_file_name' found.
'pre_upload_warn_renamed_invalid_file_name': 'verb_warn_renamed_invalid_file_name', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'warn_delete_asset' found.
'warn_delete_asset': 'verb_upload_warn_delete_asset', |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
unity/unitylibs/core/workflow/workflow-acrobat/action-binder.js
Lines 345 to 346 in f44430e
getMetadata: `${unityConfig.apiEndPoint}/asset/metadata` | |
}; |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
unity/unitylibs/core/workflow/workflow-acrobat/action-binder.js
Lines 384 to 385 in f44430e
desc: errorMetaData.desc || message || undefined | |
}, |
🚫 [eslint] <comma-spacing> reported by reviewdog 🐶
There should be no space before ','.
const detail = { event: eventName, ...(data && { data }) , sendToSplunk }; |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
fileName = DOS_SPECIAL_NAMES.has(nameWithoutExtension.toUpperCase()) |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
? `---${ext}` |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
unity/unitylibs/core/workflow/workflow-acrobat/action-binder.js
Lines 426 to 427 in f44430e
await this.dispatchErrorToast('pre_upload_warn_renamed_invalid_file_name', null, `Renamed ${rawFileName} to ${fileName}`, true) | |
} |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
return multiFileErrorMessage.endsWith('_multi') |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
? multiFileErrorMessage.slice(0, -6) |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
await this.dispatchErrorToast('validation_error_max_num_files', null, `Maximum ${this.limits.maxNumFiles} files allowed`, false, true, { |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
code: 'validation_error_validate_files', |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
unity/unitylibs/core/workflow/workflow-acrobat/action-binder.js
Lines 466 to 467 in f44430e
subCode: 'validation_error_max_num_files' | |
}); |
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required before '}'.
return { isValid: false, validFiles}; |
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required after '{'.
return {isValid: true, validFiles}; |
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required before '}'.
return {isValid: true, validFiles}; |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
if(!(cOpts.payload.feedback)) { |
🚫 [eslint] <quotes> reported by reviewdog 🐶
Strings must use singlequote.
if (this.multiFileValidationFailure) cOpts.payload.feedback = "uploaderror"; |
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required after '{'.
this.dispatchAnalyticsEvent('redirectUrl', {...filesData, redirectUrl: this.redirectUrl}); |
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required before '}'.
this.dispatchAnalyticsEvent('redirectUrl', {...filesData, redirectUrl: this.redirectUrl}); |
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required after '{'.
this.filesData = {...this.filesData,uploadType: 'sfu'}; |
🚫 [eslint] <comma-spacing> reported by reviewdog 🐶
A space is required after ','.
this.filesData = {...this.filesData,uploadType: 'sfu'}; |
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required before '}'.
this.filesData = {...this.filesData,uploadType: 'sfu'}; |
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required after '{'.
this.filesData = {...this.filesData,uploadType: 'mfu'}; |
🚫 [eslint] <comma-spacing> reported by reviewdog 🐶
A space is required after ','.
this.filesData = {...this.filesData,uploadType: 'mfu'}; |
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required before '}'.
this.filesData = {...this.filesData,uploadType: 'mfu'}; |
🚫 [eslint] <curly> reported by reviewdog 🐶
Expected { after 'if' condition.
unity/unitylibs/core/workflow/workflow-acrobat/action-binder.js
Lines 620 to 623 in f44430e
if (!combinedLimits || Object.keys(combinedLimits).length === 0) await this.dispatchErrorToast('error_generic', 500, 'No verb limits found', false, true, { | |
code: 'pre_upload_error_empty_verb_limits', | |
desc: 'No verb limits found', | |
}); |
🚫 [eslint] <no-multiple-empty-lines> reported by reviewdog 🐶
More than 1 blank line not allowed.
unity/unitylibs/core/workflow/workflow-acrobat/upload-handler.js
Lines 51 to 52 in f44430e
async uploadFileToUnityWithRetry(url, blobData, fileType, assetId, signal, chunkNumber = 0) { |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
} catch (err) { |
🚫 [eslint] <no-loop-func> reported by reviewdog 🐶
Function declared in a loop contains unsafe references to variable(s) 'retryDelay'.
await new Promise(resolve => setTimeout(resolve, retryDelay)); |
🚫 [eslint] <arrow-parens> reported by reviewdog 🐶
Expected parentheses around arrow function argument.
await new Promise(resolve => setTimeout(resolve, retryDelay)); |
🚫 [eslint] <no-promise-executor-return> reported by reviewdog 🐶
Return values from promise executor functions cannot be read.
await new Promise(resolve => setTimeout(resolve, retryDelay)); |
🚫 [eslint] <operator-assignment> reported by reviewdog 🐶
Assignment (=) can be replaced with operator assignment (+=).
if (error) error.message = error.message + ', Max retry delay exceeded during upload'; |
🚫 [eslint] <prefer-template> reported by reviewdog 🐶
Unexpected string concatenation.
if (error) error.message = error.message + ', Max retry delay exceeded during upload'; |
🚫 [eslint] <object-shorthand> reported
6D4E
by reviewdog 🐶
Expected property shorthand.
signal: signal |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
unity/unitylibs/core/workflow/workflow-acrobat/upload-handler.js
Lines 88 to 89 in f44430e
signal: signal | |
}; |
🚫 [eslint] <curly> reported by reviewdog 🐶
Expected { after 'if' condition.
unity/unitylibs/core/workflow/workflow-acrobat/upload-handler.js
Lines 112 to 116 in f44430e
} else if (['Timeout'].includes(e.name)) await this.actionBinder.dispatchErrorToast('upload_warn_chunk_upload', 504, `Timeout when uploading chunk to storage; ${assetId}, ${blobData.size} bytes`, true, true, { | |
code: 'upload_warn_chunk_upload', | |
subCode: chunkNumber, | |
desc: `Timeout when uploading chunk to storage; ${assetId}, ${blobData.size} bytes; status: ${e.status}`, | |
}); else { |
🚫 [eslint] <consistent-return> reported by reviewdog 🐶
Expected to return a value at the end of async arrow function.
return async () => { |
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 142. Maximum allowed is 100.
const { attempt } = await this.uploadFileToUnityWithRetry(url.href, chunk, fileType, assetData.id, signal, parseInt(chunkNumber)); |
🚫 [eslint] <radix> reported by reviewdog 🐶
Missing radix parameter.
const { attempt } = await this.uploadFileToUnityWithRetry(url.href, chunk, fileType, assetData.id, signal, parseInt(chunkNumber)); |
🚫 [eslint] <object-shorthand> reported by reviewdog 🐶
Expected property shorthand.
{ body: JSON.stringify(finalAssetData), signal: signal }, |
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 206. Maximum allowed is 100.
this.transitionScreen = new TransitionScreen(this.actionBinder.transitionScreen.splashScreenEl, this.actionBinder.initActionListeners, this.actionBinder.LOADER_LIMIT, this.actionBinder.workflowCfg); |
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 204. Maximum allowed is 100.
this.transitionScreen = new TransitionScreen(this.actionBinder.transitionScreen.splashScreenEl, this.actionBinder.initActionListeners, this.actionBinder.LOADER_LIMIT, this.actionBinder.workflowCfg); |
🚫 [eslint] <space-infix-ops> reported by reviewdog 🐶
Operator '=' must be spaced.
async checkPageNumCount(assetData, isMultiFile=false) { |
🚫 [eslint] <space-before-blocks> reported by reviewdog 🐶
Missing space before opening brace.
unity/unitylibs/core/workflow/workflow-acrobat/upload-handler.js
Lines 256 to 261 in f44430e
if (!isMultiFile){ | |
const { default: TransitionScreen } = await import(`${getUnityLibs()}/scripts/transition-screen.js`); | |
this.transitionScreen = new TransitionScreen(this.actionBinder.transitionScreen.splashScreenEl, this.actionBinder.initActionListeners, this.actionBinder.LOADER_LIMIT, this.actionBinder.workflowCfg); | |
await this.transitionScreen.showSplashScreen(); | |
await this.actionBinder.dispatchErrorToast('upload_validation_error_max_page_count'); | |
} |
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 212. Maximum allowed is 100.
this.transitionScreen = new TransitionScreen(this.actionBinder.transitionScreen.splashScreenEl, this.actionBinder.initActionListeners, this.actionBinder.LOADER_LIMIT, this.actionBinder.workflowCfg); |
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 210. Maximum allowed is 100.
this.transitionScreen = new TransitionScreen(this.actionBinder.transitionScreen.splashScreenEl, this.actionBinder.initActionListeners, this.actionBinder.LOADER_LIMIT, this.actionBinder.workflowCfg); |
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 204. Maximum allowed is 100.
this.transitionScreen = new TransitionScreen(this.actionBinder.transitionScreen.splashScreenEl, this.actionBinder.initActionListeners, this.actionBinder.LOADER_LIMIT, this.actionBinder.workflowCfg); |
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 202. Maximum allowed is 100.
this.transitionScreen = new TransitionScreen(this.actionBinder.transitionScreen.splashScreenEl, this.actionBinder.initActionListeners, this.actionBinder.LOADER_LIMIT, this.actionBinder.workflowCfg); |
🚫 [eslint] <space-infix-ops> reported by reviewdog 🐶
Operator '=' must be spaced.
async handleUploadError(e, errorCode='error_generic') { |
🚫 [eslint] <camelcase> reported by reviewdog 🐶
Identifier 'upload_validation_error_duplicate_asset' is not in camel case.
subCode: upload_validation_error_duplicate_asset, |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'upload_validation_error_duplicate_asset' is not defined.
subCode: upload_validation_error_duplicate_asset, |
🚫 [eslint] <curly> reported by reviewdog 🐶
Expected { after 'if' condition.
unity/unitylibs/core/workflow/workflow-acrobat/upload-handler.js
Lines 375 to 379 in f44430e
if (e.message === 'notentitled') await this.actionBinder.dispatchErrorToast('upload_error_no_storage_provision', e.status, e.message, false, e.showError, { | |
code: errorCode, | |
subCode: upload_error_no_storage_provision, | |
desc: `Exception raised when uploading file(s): ${e.message}`, | |
}); |
🚫 [eslint] <camelcase> reported by reviewdog 🐶
Identifier 'upload_error_no_storage_provision' is not in camel case.
subCode: upload_error_no_storage_provision, |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'upload_error_no_storage_provision' is not defined.
subCode: upload_error_no_storage_provision, |
🚫 [eslint] <curly> reported by reviewdog 🐶
Expected { after 'else'.
unity/unitylibs/core/workflow/workflow-acrobat/upload-handler.js
Lines 380 to 384 in f44430e
else await this.actionBinder.dispatchErrorToast('error_generic', e.status, e.message, false, e.showError, { | |
code: errorCode, | |
subCode: e.status, | |
desc: `Exception raised when uploading file(s): ${e.message}`, | |
}); |
🚫 [eslint] <curly> reported by reviewdog 🐶
Expected { after 'if' condition.
unity/unitylibs/core/workflow/workflow-acrobat/upload-handler.js
Lines 387 to 391 in f44430e
if (e.message === 'quotaexceeded') await this.actionBinder.dispatchErrorToast('upload_error_max_quota_exceeded', e.status, e.message, false, e.showError, { | |
code: errorCode, | |
subCode: 'upload_error_max_quota_exceeded', | |
desc: `Exception raised when uploading file(s): ${e.message}`, | |
}); |
🚫 [eslint] <curly> reported by reviewdog 🐶
Expected { after 'else'.
unity/unitylibs/core/workflow/workflow-acrobat/upload-handler.js
Lines 392 to 396 in f44430e
else await this.actionBinder.dispatchErrorToast('upload_error_no_storage_provision', e.status, e.message, false, e.showError, { | |
code: errorCode, | |
subCode: 'upload_error_no_storage_provision', | |
desc: `Exception raised when uploading file(s): ${e.message}`, | |
}); |
🚫 [eslint] <one-var> reported by reviewdog 🐶
Split 'let' declarations into multiple statements.
let blobData, assetData; |
🚫 [eslint] <one-var-declaration-per-line> reported by reviewdog 🐶
Expected variable declaration to be on a new line.
let blobData, assetData; |
🚫 [eslint] <one-var> reported by reviewdog 🐶
Split 'let' declarations into multiple statements.
let failedFiles, attemptMap; |
🚫 [eslint] <one-var-declaration-per-line> reported by reviewdog 🐶
Expected variable declaration to be on a new line.
let failedFiles, attemptMap; |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
unity/unitylibs/core/workflow/workflow-acrobat/upload-handler.js
Lines 458 to 459 in f44430e
abortSignal | |
)); |
🚫 [eslint] <prefer-template> reported by reviewdog 🐶
Unexpected string concatenation.
desc: 'Error during chunk upload: ' + error.message, |
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 204. Maximum allowed is 100.
this.transitionScreen = new TransitionScreen(this.actionBinder.transitionScreen.splashScreenEl, this.actionBinder.initActionListeners, this.actionBinder.LOADER_LIMIT, this.actionBinder.workflowCfg); |
🚫 [eslint] <consistent-return> reported by reviewdog 🐶
Expected to return a value at the end of async method 'singleFileGuestUpload'.
async singleFileGuestUpload(file, fileData) { |
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 202. Maximum allowed is 100.
this.transitionScreen = new TransitionScreen(this.actionBinder.transitionScreen.splashScreenEl, this.actionBinder.initActionListeners, this.actionBinder.LOADER_LIMIT, this.actionBinder.workflowCfg); |
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 164. Maximum allowed is 100.
const nonpdfSfuProductScreenVerbs = this.actionBinder.workflowCfg.targetCfg.nonpdfSfuProductScreen.includes(this.actionBinder.workflowCfg.enabledFeatures[0]); |
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 109. Maximum allowed is 100.
if(this.isPdf(file) || nonpdfSfuProductScreenVerbs) return await this.uploadSingleFile(file, fileData); |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
if(this.isPdf(file) || nonpdfSfuProductScreenVerbs) return await this.uploadSingleFile(file, fileData); |
🚫 [eslint] <consistent-return> reported by reviewdog 🐶
Async method 'singleFileGuestUpload' expected a return value.
if (!redirectSuccess) return; |
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 202. Maximum allowed is 100.
this.transitionScreen = new TransitionScreen(this.actionBinder.transitionScreen.splashScreenEl, this.actionBinder.initActionListeners, this.actionBinder.LOADER_LIMIT, this.actionBinder.workflowCfg); |
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 133. Maximum allowed is 100.
const { blobDataArray, assetDataArray, fileTypeArray } = await this.createInitialAssets(files, workflowId, maxConcurrentFiles); |
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required after '{'.
await this.actionBinder.dispatchErrorToast('pre_upload_error_create_asset', 500, 'Error during asset creation or blob retrieval', false, true, {code: 'pre_upload_error_create_asset'}); |
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required before '}'.
await this.actionBinder.dispatchErrorToast('pre_upload_error_create_asset', 500, 'Error during asset creation or blob retrieval', false, true, {code: 'pre_upload_error_create_asset'}); |
🚫 [eslint] <one-var> reported by reviewdog 🐶
Split 'let' declarations into multiple statements.
let failedFiles, attemptMap; |
🚫 [eslint] <one-var-declaration-per-line> reported by reviewdog 🐶
Expected variable declaration to be on a new line.
let failedFiles, attemptMap; |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'attemptMap' is assigned a value but never used.
({ failedFiles, attemptMap } = await this.chunkPdf( |
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 143. Maximum allowed is 100.
const uploadedAssets = assetDataArray.filter((_, index) =>!(failedFiles && [...failedFiles].some(failed => failed.fileIndex === index))); |
🚫 [eslint] <arrow-spacing> reported by reviewdog 🐶
Missing space after =>.
const uploadedAssets = assetDataArray.filter((_, index) =>!(failedFiles && [...failedFiles].some(failed => failed.fileIndex === index))); |
🚫 [eslint] <arrow-parens> reported by reviewdog 🐶
Expected parentheses around arrow function argument.
const uploadedAssets = assetDataArray.filter((_, index) =>!(failedFiles && [...failedFiles].some(failed => failed.fileIndex === index))); |
🚫 [eslint] <quotes> reported by reviewdog 🐶
Strings must use singlequote.
await this.actionBinder.dispatchErrorToast('error_generic', error.code, `Exception in uploading one or more files`, true, true); |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <no-return-await> reported by reviewdog 🐶
Redundant use of await
on a return value.
return await this.actionBinder.handleRedirect(cOpts, filesData); |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'allVerified' is assigned a value but never used.
let allVerified = 0; |
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 117. Maximum allowed is 100.
await this.executeInBatches(uploadedAssets, this.getConcurrentLimits().maxConcurrentFiles, async (assetData) => { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 8 spaces but found 10.
const validated = await this.handleValidations(assetData, true); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 8 spaces but found 10.
if (validated) allVerified += 1; |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 8 spaces but found 10.
else assetsToDelete.push(assetData); |
🚫 [eslint] <arrow-parens> reported by reviewdog 🐶
Expected parentheses around arrow function argument.
const verifiedAssets = uploadedAssets.filter(asset => |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
!assetsToDelete.some(deletedAsset => deletedAsset.id === asset.id) |
🚫 [eslint] <arrow-parens> reported by reviewdog 🐶
Expected parentheses around arrow function argument.
!assetsToDelete.some(deletedAsset => deletedAsset.id === asset.id) |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
unity/unitylibs/core/workflow/workflow-acrobat/upload-handler.js
Lines 632 to 633 in f44430e
!assetsToDelete.some(deletedAsset => deletedAsset.id === asset.id) | |
); |
🚫 [eslint] <function-paren-newline> reported by reviewdog 🐶
Unexpected newline before ')'.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
unity/unitylibs/core/workflow/workflow-acrobat/upload-handler.js
Lines 648 to 649 in f44430e
subCode: error.code | |
}); |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 202. Maximum allowed is 100.
this.transitionScreen = new TransitionScreen(this.actionBinder.transitionScreen.splashScreenEl, this.actionBinder.initActionListeners, this.actionBinder.LOADER_LIMIT, this.actionBinder.workflowCfg); |
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 204. Maximum allowed is 100.
this.transitionScreen = new TransitionScreen(this.actionBinder.transitionScreen.splashScreenEl, this.actionBinder.initActionListeners, this.actionBinder.LOADER_LIMIT, this.actionBinder.workflowCfg); |
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 181. Maximum allowed is 100.
const nonpdfMfuFeedbackScreenTypeNonpdf = this.actionBinder.workflowCfg.targetCfg.nonpdfMfuFeedbackScreenTypeNonpdf.includes(this.actionBinder.workflowCfg.enabledFeatures[0]); |
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 137. Maximum allowed is 100.
if (this.actionBinder.workflowCfg.targetCfg.mfuUploadOnlyPdfAllowed.includes(this.actionBinder.workflowCfg.enabledFeatures[0])) { |
🚫 [eslint] <prefer-const> reported by reviewdog 🐶
'fileData' is never reassigned. Use 'const' instead.
let fileData = { type: 'mixed', size: filesData.size, count: pdfFiles.length, uploadType: 'mfu' }; |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
await this.uploadMultiFile(files, filesData); |
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 101. Maximum allowed is 100.
this.transitionScreen.updateProgressBar(this.actionBinder.transitionScreen.splashScreenEl, 85); |
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 204. Maximum allowed is 100.
this.transitionScreen = new TransitionScreen(this.actionBinder.transitionScreen.splashScreenEl, this.actionBinder.initActionListeners, this.actionBinder.LOADER_LIMIT, this.actionBinder.workflowCfg); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'limits' is assigned a value but never used.
constructor(unityEl, workflowCfg, wfblock, canvasArea, actionMap = {}, limits = {}) { |
🚫 [eslint] <prefer-const> reported by reviewdog 🐶
'tel' is never reassigned. Use 'const' instead.
let tel = typeof item === 'string' ? b?.querySelector(item) : item; |
🚫 [eslint] <no-return-assign> reported by reviewdog 🐶
Arrow function should not return assignment.
[...item].forEach((i) => i.style[propertyName] = propertyValue); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'i' is defined but never used.
this.operations.forEach((op, i) => { |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'defineDeviceByScreenSize' is defined but never used.
defineDeviceByScreenSize, |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
unity/unitylibs/core/workflow/workflow-photoshop/widget.js
Lines 89 to 90 in f44430e
} | |
]; |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
unity/unitylibs/core/workflow/workflow-photoshop/widget.js
Lines 142 to 143 in f44430e
this.workflowCfg.productName.toLowerCase() | |
); |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
unity/unitylibs/core/workflow/workflow-photoshop/widget.js
Lines 221 to 222 in f44430e
authCfg.querySelector(':scope ul li img').src | |
) |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
updateQueryParameter | |
} from '../../../scripts/utils.js'; |
🚫 [eslint] <space-infix-ops> reported by reviewdog 🐶
Operator '=' must be spaced.
async function removeBgHandler(cfg, changeDisplay = true, cachedImg=null) { |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
if(cfg.preludeState.href) { |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
if(cfg.presentState.cache && cachedImg) { |
🚫 [eslint] <space-infix-ops> reported by reviewdog 🐶
Operator '=' must be spaced.
cfg.presentState.removeBgState.assetUrl=cachedImg.src; |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
cfg.presentState.removeBgState.assetId = cachedId; |
🚫 [eslint] <no-multi-spaces> reported by reviewdog 🐶
Multiple spaces found before '='.
const { authorCfg } = wfDetail[featureName]; |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
if(cfg.presentState.cache && cachedImg) { |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
unity/unitylibs/core/workflow/workflow-photoshop/workflow-photoshop.js
Lines 249 to 250 in f44430e
await delay(500) | |
img.src = cachedImg.src; |
🚫 [eslint] <prefer-const> reported by reviewdog 🐶
'imgs' is never reassigned. Use 'const' instead.
let imgs = o.querySelectorAll('img'); |
🚫 [eslint] <prefer-destructuring> reported by reviewdog 🐶
Use array destructuring.
bgImg = imgs[0] |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
unity/unitylibs/core/workflow/workflow-photoshop/workflow-photoshop.js
Lines 320 to 321 in f44430e
bgImg = imgs[0] | |
thumbnail = bgImg; |
🚫 [eslint] <spaced-comment> reported by reviewdog 🐶
Expected exception block, space or tab after '//' in comment.
//check if caching is enabled |
🚫 [eslint] <class-methods-use-this> reported by reviewdog 🐶
Expected 'this' to be used by class async method 'priorityLibFetch'.
unity/unitylibs/core/workflow/workflow.js
Line 124 in f44430e
async priorityLibFetch(workflowName) { |
🚫 [eslint] <class-methods-use-this> reported by reviewdog 🐶
Expected 'this' to be used by class method 'getImgSrc'.
unity/unitylibs/core/workflow/workflow.js
Line 234 in f44430e
getImgSrc(pic) { |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
unity/unitylibs/core/workflow/workflow.js
Lines 307 to 308 in f44430e
'chat-pdf-student' | |
]), |
🚫 [eslint] <arrow-parens> reported by reviewdog 🐶
Expected parentheses around arrow function argument.
unity/unitylibs/core/workflow/workflow.js
Line 343 in f44430e
const verb = [...verbWidget.classList].find(cn => supportedFeatures.has(cn)); |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
unity/unitylibs/core/workflow/workflow.js
Lines 344 to 345 in f44430e
if (verb) this.workflowCfg.enabledFeatures.push(verb) | |
} |
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 101. Maximum allowed is 100.
unity/unitylibs/core/workflow/workflow.js
Line 352 in f44430e
if(!this.workflowCfg.enabledFeatures.includes(fn)) this.workflowCfg.enabledFeatures.push(fn); |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
unity/unitylibs/core/workflow/workflow.js
Line 352 in f44430e
if(!this.workflowCfg.enabledFeatures.includes(fn)) this.workflowCfg.enabledFeatures.push(fn); |
🚫 [eslint] <spaced-comment> reported by reviewdog 🐶
Expected exception block, space or tab after '//' in comment.
unity/unitylibs/core/workflow/workflow.js
Line 366 in f44430e
if (el.classList.contains('workflow-ai')) uv = 'v2'; //This line will be removed once CC moves to unity V2 |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
unity/unitylibs/scripts/errors.js
Line 27 in f44430e
const baseUrl = (origin.includes('.aem.') || origin.includes('.hlx.')) |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 2.
unity/unitylibs/scripts/errors.js
Line 28 in f44430e
? `https://main--unity--adobecom.${origin.includes('.hlx.') ? 'hlx' : 'aem'}.live` |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 2.
unity/unitylibs/scripts/errors.js
Line 29 in f44430e
: origin; |
🚫 [eslint] <no-var> reported by reviewdog 🐶
Unexpected var, use let or const instead.
unity/unitylibs/scripts/fallback.js
Line 1 in f44430e
var div = document.createElement('div'); |
🚫 [eslint] <vars-on-top> reported by reviewdog 🐶
All 'var' declarations must be at the top of the function scope.
unity/unitylibs/scripts/fallback.js
Lines 12 to 25 in f44430e
var locFallbackEntries = { | |
'en': 'Your web browser is out of date. For more security, comfort and the best experience on this site, please update to or use a modern browser', | |
'de': 'Ihr Browser ist veraltet. Für mehr Sicherheit, Komfort und die beste Erfahrung auf dieser Website, aktualisieren Sie bitte oder verwenden Sie einen modernen Browser', | |
'it': 'Il tuo browser non è aggiornato. Per una maggiore sicurezza, comodità e la migliore esperienza su questo sito, si prega di aggiornare o utilizzare un browser moderno.', | |
'zh-HK': '您的网络浏览器已过期。为了在本网站上获得更高的安全性、舒适性和最佳体验,请更新到或使用现代浏览器', | |
'zh-TW': '您的網絡瀏覽器已過期。為了在本網站上獲得更高的安全性、舒適性和最佳體驗,請更新到或使用現代瀏覽器', | |
'hi': 'आपका वेब ब्राउज़र पुराना हो चुका है। इस साइट पर अधिक सुरक्षा, आराम और सर्वोत्तम अनुभव के लिए, कृपया किसी आधुनिक ब्राउज़र को अपडेट करें या उसका उपयोग करें', | |
'es': 'Su navegador web está desactualizado. Para mayor seguridad, comodidad y la mejor experiencia en este sitio, actualice o use un navegador moderno.', | |
'fr': 'Votre navigateur Web est obsolète. Pour plus de sécurité, de confort et la meilleure expérience sur ce site, veuillez mettre à jour ou utiliser un navigateur moderne.', | |
'ar': 'متصفحك غير محدثة. لمزيد من الأمان والراحة وأفضل تجربة على هذا الموقع ، يرجى التحديث إلى متصفح حديث أو استخدامه', | |
'ru': 'Ваш веб-браузер устарел. Для большей безопасности, удобства и наилучшего взаимодействия с этим сайтом обновите или используйте современный браузер.', | |
'pt': 'Seu navegador da web está desatualizado. Para mais segurança, conforto e a melhor experiência neste site, atualize ou use um navegador moderno.', | |
'ko': '웹 브라우저가 오래되었습니다. 이 사이트에서 더 많은 보안, 편안함 및 최상의 경험을 위해 최신 브라우저로 업데이트하거나 사용하십시오.', | |
}; |
🚫 [eslint] <no-var> reported by reviewdog 🐶
Unexpected var, use let or const instead.
unity/unitylibs/scripts/fallback.js
Lines 12 to 25 in f44430e
var locFallbackEntries = { | |
'en': 'Your web browser is out of date. For more security, comfort and the best experience on this site, please update to or use a modern browser', | |
'de': 'Ihr Browser ist veraltet. Für mehr Sicherheit, Komfort und die beste Erfahrung auf dieser Website, aktualisieren Sie bitte oder verwenden Sie einen modernen Browser', | |
'it': 'Il tuo browser non è aggiornato. Per una maggiore sicurezza, comodità e la migliore esperienza su questo sito, si prega di aggiornare o utilizzare un browser moderno.', | |
'zh-HK': '您的网络浏览器已过期。为了在本网站上获得更高的安全性、舒适性和最佳体验,请更新到或使用现代浏览器', | |
'zh-TW': '您的網絡瀏覽器已過期。為了在本網站上獲得更高的安全性、舒適性和最佳體驗,請更新到或使用現代瀏覽器', | |
'hi': 'आपका वेब ब्राउज़र पुराना हो चुका है। इस साइट पर अधिक सुरक्षा, आराम और सर्वोत्तम अनुभव के लिए, कृपया किसी आधुनिक ब्राउज़र को अपडेट करें या उसका उपयोग करें', | |
'es': 'Su navegador web está desactualizado. Para mayor seguridad, comodidad y la mejor experiencia en este sitio, actualice o use un navegador moderno.', | |
'fr': 'Votre navigateur Web est obsolète. Pour plus de sécurité, de confort et la meilleure expérience sur ce site, veuillez mettre à jour ou utiliser un navigateur moderne.', | |
'ar': 'متصفحك غير محدثة. لمزيد من الأمان والراحة وأفضل تجربة على هذا الموقع ، يرجى التحديث إلى متصفح حديث أو استخدامه', | |
'ru': 'Ваш веб-браузер устарел. Для большей безопасности, удобства и наилучшего взаимодействия с этим сайтом обновите или используйте современный браузер.', | |
'pt': 'Seu navegador da web está desatualizado. Para mais segurança, conforto e a melhor experiência neste site, atualize ou use um navegador moderno.', | |
'ko': '웹 브라우저가 오래되었습니다. 이 사이트에서 더 많은 보안, 편안함 및 최상의 경험을 위해 최신 브라우저로 업데이트하거나 사용하십시오.', | |
}; |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'en' found.
unity/unitylibs/scripts/fallback.js
Line 13 in f44430e
'en': 'Your web browser is out of date. For more security, comfort and the best experience on this site, please update to or use a modern browser', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'de' found.
unity/unitylibs/scripts/fallback.js
Line 14 in f44430e
'de': 'Ihr Browser ist veraltet. Für mehr Sicherheit, Komfort und die beste Erfahrung auf dieser Website, aktualisieren Sie bitte oder verwenden Sie einen modernen Browser', |
🚫
Unnecessarily quoted property 'it' found.
unity/unitylibs/scripts/fallback.js
Line 15 in f44430e
'it': 'Il tuo browser non è aggiornato. Per una maggiore sicurezza, comodità e la migliore esperienza su questo sito, si prega di aggiornare o utilizzare un browser moderno.', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'hi' found.
unity/unitylibs/scripts/fallback.js
Line 18 in f44430e
'hi': 'आपका वेब ब्राउज़र पुराना हो चुका है। इस साइट पर अधिक सुरक्षा, आराम और सर्वोत्तम अनुभव के लिए, कृपया किसी आधुनिक ब्राउज़र को अपडेट करें या उसका उपयोग करें', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'es' found.
unity/unitylibs/scripts/fallback.js
Line 19 in f44430e
'es': 'Su navegador web está desactualizado. Para mayor seguridad, comodidad y la mejor experiencia en este sitio, actualice o use un navegador moderno.', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'fr' found.
unity/unitylibs/scripts/fallback.js
Line 20 in f44430e
'fr': 'Votre navigateur Web est obsolète. Pour plus de sécurité, de confort et la meilleure expérience sur ce site, veuillez mettre à jour ou utiliser un navigateur moderne.', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ar' found.
unity/unitylibs/scripts/fallback.js
Line 21 in f44430e
'ar': 'متصفحك غير محدثة. لمزيد من الأمان والراحة وأفضل تجربة على هذا الموقع ، يرجى التحديث إلى متصفح حديث أو استخدامه', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ru' found.
unity/unitylibs/scripts/fallback.js
Line 22 in f44430e
'ru': 'Ваш веб-браузер устарел. Для большей безопасности, удобства и наилучшего взаимодействия с этим сайтом обновите или используйте современный браузер.', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'pt' found.
unity/unitylibs/scripts/fallback.js
Line 23 in f44430e
'pt': 'Seu navegador da web está desatualizado. Para mais segurança, conforto e a melhor experiência neste site, atualize ou use um navegador moderno.', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ko' found.
unity/unitylibs/scripts/fallback.js
Line 24 in f44430e
'ko': '웹 브라우저가 오래되었습니다. 이 사이트에서 더 많은 보안, 편안함 및 최상의 경험을 위해 최신 브라우저로 업데이트하거나 사용하십시오.', |
🚫 [eslint] <vars-on-top> reported by reviewdog 🐶
All 'var' declarations must be at the top of the function scope.
unity/unitylibs/scripts/fallback.js
Line 27 in f44430e
var userLocale = navigator.language || navigator.userLanguage; |
🚫 [eslint] <no-var> reported by reviewdog 🐶
Unexpected var, use let or const instead.
unity/unitylibs/scripts/fallback.js
Line 27 in f44430e
var userLocale = navigator.language || navigator.userLanguage; |
🚫 [eslint] <vars-on-top> reported by reviewdog 🐶
All 'var' declarations must be at the top of the function scope.
unity/unitylibs/scripts/fallback.js
Line 28 in f44430e
var userLang = userLocale.split('-')[0]; |
🚫 [eslint] <no-var> reported by reviewdog 🐶
Unexpected var, use let or const instead.
unity/unitylibs/scripts/fallback.js
Line 28 in f44430e
var userLang = userLocale.split('-')[0]; |
🚫 [eslint] <vars-on-top> reported by reviewdog 🐶
All 'var' declarations must be at the top of the function scope.
unity/unitylibs/scripts/fallback.js
Line 30 in f44430e
var locFallbackText = locFallbackEntries[userLang] || locFallbackEntries[userLocale]; |
🚫 [eslint] <no-var> reported by reviewdog 🐶
Unexpected var, use let or const instead.
unity/unitylibs/scripts/fallback.js
Line 30 in f44430e
var locFallbackText = locFallbackEntries[userLang] || locFallbackEntries[userLocale]; |
🚫 [eslint] <dot-notation> reported by reviewdog 🐶
["en"] is better written in dot notation.
unity/unitylibs/scripts/fallback.js
Line 32 in f44430e
locFallbackText = locFallbackEntries['en']; |
🚫 [eslint] <vars-on-top> reported by reviewdog 🐶
All 'var' declarations must be at the top of the function scope.
unity/unitylibs/scripts/fallback.js
Line 36 in f44430e
var span = document.createElement('span'); |
🚫 [eslint] <no-var> reported by reviewdog 🐶
Unexpected var, use let or const instead.
unity/unitylibs/scripts/fallback.js
Line 36 in f44430e
var span = document.createElement('span'); |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
unity/unitylibs/scripts/fallback.js
Lines 37 to 38 in f44430e
span.textContent = locFallbackText | |
span.lang = userLang |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
unity/unitylibs/scripts/fallback.js
Lines 38 to 39 in f44430e
span.lang = userLang | |
div.appendChild(span); |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
unity/unitylibs/scripts/fallback.js
Line 41 in f44430e
if(!document.body) { |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
unity/unitylibs/scripts/fallback.js
Lines 42 to 43 in f44430e
document.body = document.createElement('body') | |
} |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'config' is assigned a value but never used.
unity/unitylibs/scripts/scripts.js
Line 138 in f44430e
const config = setConfig({ ...CONFIG, miloLibs }); |
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 115. Maximum allowed is 100.
const { eventName, product, errorData, redirectUrl, assetId, statusCode, verb, action, workflowStep } = metaData; |
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Expected a line break after this opening brace.
const { eventName, product, errorData, redirectUrl, assetId, statusCode, verb, action, workflowStep } = metaData; |
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Expected a line break before this closing brace.
const { eventName, product, errorData, redirectUrl, assetId, statusCode, verb, action, workflowStep } = metaData; |
🚫 [eslint] <space-infix-ops> reported by reviewdog 🐶
Operator '!==' must be spaced.
...(statusCode!==undefined && { statusCode }), |
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 111. Maximum allowed is 100.
export default function sendAnalyticsToSplunk(eventName, product, metaData, splunkEndpoint, sendBeacon=false) { |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'sendBeacon' is assigned a value but never used.
export default function sendAnalyticsToSplunk(eventName, product, metaData, splunkEndpoint, sendBeacon=false) { |
🚫 [eslint] <space-infix-ops> reported by reviewdog 🐶
Operator '=' must be spaced.
export default function sendAnalyticsToSplunk(eventName, product, metaData, splunkEndpoint, sendBeacon=false) { |
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 111. Maximum allowed is 100.
if (navigator.sendBeacon && navigator.sendBeacon(splunkEndpoint, JSON.stringify(eventDataPayload))) return; |
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 119. Maximum allowed is 100.
if (!this.progressText && TransitionScreen.lastProgressText) this.progressText = TransitionScreen.lastProgressText; |
🚫 [eslint] <class-methods-use-this> reported by reviewdog 🐶
Expected 'this' to be used by class method 'createProgressBar'.
createProgressBar() { |
🚫 [eslint] <no-param-reassign> reported by reviewdog 🐶
Assignment to function parameter 'delay'.
delay = Math.min(delay + 100, 2000); |
🚫 [eslint] <no-param-reassign> reported by reviewdog 🐶
Assignment to function parameter 'i'.
i = Math.max(i - 5, 5); |
🚫 [eslint] <consistent-return> reported by reviewdog 🐶
Async method 'loadSplashFragment' expected no return value.
unity/unitylibs/scripts/transition-screen.js
Line 102 in f44430e
return f; |
🚫 [eslint] <no-use-before-define> reported by reviewdog 🐶
'cleanup' was used before it was defined.
unity/unitylibs/scripts/transition-screen.js
Line 109 in f44430e
cleanup(interactionHandler); |
🚫 [eslint] <no-use-before-define> reported by reviewdog 🐶
'cleanup' was used before it was defined.
unity/unitylibs/scripts/transition-screen.js
Line 114 in f44430e
cleanup(interactionHandler); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'area' is assigned a value but never used.
unity/unitylibs/scripts/utils.js
Line 29 in f44430e
export function decorateArea(area = document) {} |
🚫 [eslint] <no-promise-executor-return> reported by reviewdog 🐶
Return values from promise executor functions cannot be read.
unity/unitylibs/scripts/utils.js
Line 72 in f44430e
await new Promise((resolve) => setTimeout(resolve, RETRY_WAIT)); |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
unity/unitylibs/scripts/utils.js
Lines 82 to 83 in f44430e
originalToken: accessToken | |
}, |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
unity/unitylibs/scripts/utils.js
Lines 139 to 140 in f44430e
const currLocale = getConfig().locale?.prefix.replace('/', '') | |
return currLocale ? currLocale : 'us'; |
🚫 [eslint] <no-unneeded-ternary> reported by reviewdog 🐶
Unnecessary use of conditional expression for default assignment.
unity/unitylibs/scripts/utils.js
Line 140 in f44430e
return currLocale ? currLocale : 'us'; |
🚫 [eslint] <no-else-return> reported by reviewdog 🐶
Unnecessary 'else' after 'return'.
unity/unitylibs/scripts/utils.js
Line 161 in f44430e
else throw new Error('Could not fetch SVG'); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'e' is defined but never used.
unity/unitylibs/scripts/utils.js
Line 164 in f44430e
.catch((e) => { svg.remove(); }), |
🚫 [eslint] <no-return-await> reported by reviewdog 🐶
Redundant use of await
on a return value.
unity/unitylibs/scripts/utils.js
Line 216 in f44430e
return await Promise.all(promiseArr); |
🚫 [eslint] <no-shadow> reported by reviewdog 🐶
'delay' is already declared in the upper scope on line 289 column 17.
unity/unitylibs/scripts/utils.js
Line 260 in f44430e
export async function retryRequestUntilProductRedirect(cfg, requestFunction, delay = 1000) { |
🚫 [eslint] <no-await-in-loop> reported by reviewdog 🐶
Unexpected await
inside a loop.
unity/unitylibs/scripts/utils.js
Line 263 in f44430e
const scanResponse = await requestFunction(); |
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 101. Maximum allowed is 100.
unity/unitylibs/scripts/utils.js
Line 264 in f44430e
if (scanResponse.status === 429 || (scanResponse.status >= 500 && scanResponse.status < 600)) { |
🚫 [eslint] <no-await-in-loop> reported by reviewdog 🐶
Unexpected await
inside a loop.
unity/unitylibs/scripts/utils.js
Line 265 in f44430e
await new Promise((res) => setTimeout(res, delay)); |
🚫 [eslint] <no-promise-executor-return> reported by reviewdog 🐶
Return values from promise executor functions cannot be read.
unity/unitylibs/scripts/utils.js
Line 265 in f44430e
await new Promise((res) => setTimeout(res, delay)); |
🚫 [eslint] <no-await-in-loop> reported by reviewdog 🐶
Unexpected await
inside a loop.
unity/unitylibs/scripts/utils.js
Line 271 in f44430e
await new Promise((res) => setTimeout(res, delay)); |
🚫 [eslint] <no-
10000
promise-executor-return> reported by reviewdog 🐶
Return values from promise executor functions cannot be read.
unity/unitylibs/scripts/utils.js
Line 271 in f44430e
await new Promise((res) => setTimeout(res, delay)); |
🚫 [eslint] <space-infix-ops> reported by reviewdog 🐶
Operator '=' must be spaced.
unity/unitylibs/scripts/utils.js
Line 297 in f44430e
export function updateQueryParameter(url, paramName='format', oldValue='webply', newValue='jpeg') { |
🚫 [eslint] <space-infix-ops> reported by reviewdog 🐶
Operator '=' must be spaced.
unity/unitylibs/scripts/utils.js
Line 297 in f44430e
export function updateQueryParameter(url, paramName='format', oldValue='webply', newValue='jpeg') { |
🚫 [eslint] <space-infix-ops> reported by reviewdog 🐶
Operator '=' must be spaced.
unity/unitylibs/scripts/utils.js
Line 297 in f44430e
export function updateQueryParameter(url, paramName='format', oldValue='webply', newValue='jpeg') { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 6.
unity/unitylibs/scripts/utils.js
Line 299 in f44430e
const urlObj = new URL(url); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 6.
unity/unitylibs/scripts/utils.js
Line 300 in f44430e
const params = urlObj.searchParams; |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 6.
unity/unitylibs/scripts/utils.js
Line 301 in f44430e
if (params.get(paramName) === oldValue) { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
unity/unitylibs/scripts/utils.js
Line 302 in f44430e
params.set(paramName, newValue); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 6.
unity/unitylibs/scripts/utils.js
Line 303 in f44430e
} |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 6.
unity/unitylibs/scripts/utils.js
Line 305 in f44430e
return urlObj.toString(); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 6.
unity/unitylibs/scripts/utils.js
Line 307 in f44430e
return null; |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
unity/unitylibs/scripts/utils.js
Line 336 in f44430e
|| host.includes('hlx.live') |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
unity/unitylibs/scripts/utils.js
Line 338 in f44430e
|| host.includes('aem.live') |
🚫 [eslint] <no-underscore-dangle> reported by reviewdog 🐶
Unexpected dangling '_' in '_adobe_corpnew'.
unity/unitylibs/scripts/utils.js
Line 354 in f44430e
data.data._adobe_corpnew = { digitalData: event.detail }; |
🚫 [eslint] <no-underscore-dangle> reported by reviewdog 🐶
Unexpected dangling '_' in '_satellite'.
unity/unitylibs/scripts/utils.js
Line 356 in f44430e
window._satellite?.track('event', data); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 4.
unity/unitylibs/utils/FileUtils.js
Line 2 in f44430e
return name && name.includes('.') ? name.split('.').pop() : ''; |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 0 spaces but found 2.
unity/unitylibs/utils/FileUtils.js
Line 3 in f44430e
} |
import { expect } from '@esm-bundle/chai'; | ||
|
||
window.adobeIMS = { | ||
getAccessToken: () => { return {"token": 'token', "expire": { valueOf: () => Date.now() + (5 * 60 * 1000)}}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <arrow-body-style> reported by reviewdog 🐶
Unexpected block statement surrounding arrow body; parenthesize the returned value and move it immediately after the =>
.
getAccessToken: () => { return {"token": 'token', "expire": { valueOf: () => Date.now() + (5 * 60 * 1000)}}}, | |
getAccessToken: () => ({"token": 'token', "expire": { valueOf: () => Date.now() + (5 * 60 * 1000)}}), |
import { expect } from '@esm-bundle/chai'; | ||
|
||
window.adobeIMS = { | ||
getAccessToken: () => { return {"token": 'token', "expire": { valueOf: () => Date.now() + (5 * 60 * 1000)}}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required after '{'.
getAccessToken: () => { return {"token": 'token', "expire": { valueOf: () => Date.now() + (5 * 60 * 1000)}}}, | |
getAccessToken: () => { return { "token": 'token', "expire": { valueOf: () => Date.now() + (5 * 60 * 1000)}}}, |
import { expect } from '@esm-bundle/chai'; | ||
|
||
window.adobeIMS = { | ||
getAccessToken: () => { return {"token": 'token', "expire": { valueOf: () => Date.now() + (5 * 60 * 1000)}}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required before '}'.
getAccessToken: () => { return {"token": 'token', "expire": { valueOf: () => Date.now() + (5 * 60 * 1000)}}}, | |
getAccessToken: () => { return {"token": 'token', "expire": { valueOf: () => Date.now() + (5 * 60 * 1000) }}}, |
import { expect } from '@esm-bundle/chai'; | ||
|
||
window.adobeIMS = { | ||
getAccessToken: () => { return {"token": 'token', "expire": { valueOf: () => Date.now() + (5 * 60 * 1000)}}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required before '}'.
getAccessToken: () => { return {"token": 'token', "expire": { valueOf: () => Date.now() + (5 * 60 * 1000)}}}, | |
getAccessToken: () => { return {"token": 'token', "expire": { valueOf: () => Date.now() + (5 * 60 * 1000)} }}, |
import { expect } from '@esm-bundle/chai'; | ||
|
||
window.adobeIMS = { | ||
getAccessToken: () => { return {"token": 'token', "expire": { valueOf: () => Date.now() + (5 * 60 * 1000)}}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <block-spacing> reported by reviewdog 🐶
Requires a space before '}'.
getAccessToken: () => { return {"token": 'token', "expire": { valueOf: () => Date.now() + (5 * 60 * 1000)}}}, | |
getAccessToken: () => { return {"token": 'token', "expire": { valueOf: () => Date.now() + (5 * 60 * 1000)}} }, |
"splashScreenConfig": {"fragmentLink": "/test/core/workflow/mocks/splash", "splashScreenParent": "body"}, | ||
"actionMap": { | ||
".verb-wrapper": [{"actionType": "croppages"},{"actionType": "continueInApp"}], | ||
"#file-upload": [{"actionType": "croppages"},{"actionType": "continueInApp"}] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
"#file-upload": [{"actionType": "croppages"},{"actionType": "continueInApp"}] | |
"#file-upload": [{"actionType": "croppages"},{"actionType": "continueInApp"}], |
"actionMap": { | ||
".verb-wrapper": [{"actionType": "croppages"},{"actionType": "continueInApp"}], | ||
"#file-upload": [{"actionType": "croppages"},{"actionType": "continueInApp"}] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
} | |
}, |
".verb-wrapper": [{"actionType": "croppages"},{"actionType": "continueInApp"}], | ||
"#file-upload": [{"actionType": "croppages"},{"actionType": "continueInApp"}] | ||
} | ||
}}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Expected a line break before this closing brace.
}}; | |
} | |
}; |
".verb-wrapper": [{"actionType": "croppages"},{"actionType": "continueInApp"}], | ||
"#file-upload": [{"actionType": "croppages"},{"actionType": "continueInApp"}] | ||
} | ||
}}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required before '}'.
}}; | |
} }; |
} else if (url.includes('metadata')) { | ||
payload = {}; | ||
} else if (url.includes('asset')) { | ||
payload = {id : 'testid'}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required after '{'.
payload = {id : 'testid'}; | |
payload = { id : 'testid'}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected unnamed function.
sinon.stub(UnityWidget.prototype, 'loadPrompts').callsFake(function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <no-plusplus> reported by reviewdog 🐶
Unary operator '++' used.
for (let attempt = 1; attempt <= maxRetries; attempt++) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <no-use-before-define> reported by reviewdog 🐶
'timeoutId' was used before it was defined.
clearTimeout(timeoutId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <space-before-blocks> reported by reviewdog 🐶
Missing space before opening brace.
unity/unitylibs/core/workflow/workflow-acrobat/upload-handler.js
Lines 666 to 671 in f44430e
if (allNonPdf){ | |
const redirectSuccess = await this.actionBinder.handleRedirect(this.getGuestConnPayload('nonpdf'), filesData); | |
if (!redirectSuccess) return; | |
this.actionBinder.redirectWithoutUpload = true; | |
return; | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverts #498