This repository was archived by the owner on Jul 1, 2022. It is now read-only.
fix duplicate bot name in status update message #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the behavior of the _send_status_update method. If the generic_api is in use, it will avoid adding the bot name to the start of the message because the bot name is already added by the generic api.
aeon0
suggested changes
Jan 21, 2022
src/game_stats.py
Outdated
| if self._config.general["message_api_type"] == "generic_api": | ||
| msg = f"Status Report\n{self._create_msg()}\nVersion: {__version__}" | ||
| else: | ||
| msg = f"{self._config.general['name']}: Status Report\n{self._create_msg()}\nVersion: {__version__}" |
There was a problem hiding this comment.
I would rather remove the name here and add it to the DiscordEmbeds class instead of this if clause
This commit moves the fix to the DiscordEmbeds class instead of performing it with an if statement in the GameStats class.
|
Made the changes and re-tested both api modes today. Good to go from my end. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the generic_api is in use, the bot name appears twice at the start of each status update message, because the bot name is added at the start by both the GameStats
_send_status_updatemethod and the GenericApi_sendmethod.example of bug:
This commit changes the behavior of the _send_status_update method. If the generic_api is in use, it will avoid adding the bot name to the start of the message.