Transmute All Gems #736
Transmute All Gems #736
Conversation
|
Can't we make it as "transmute gems" as one line instead of having them all seperate in params? |
That's not a good idea because some people keep specific gems for upgrading specific runes or (in my case) rerolling certain items with chips is more effective than with perfect |
|
@D2RLegit As TallenKerl said I built it this way so the user has the choice which gems they want to keep. |
|
It actually quite a cool coding exercise to implement it in a way it does everything in one go. Imagine picking up a batch of gems: 6 chipped, 1 flawed, 2 standard, 2 flawless and produce 1 perfect one out of it. Not required to merge but if you're up for a challenge |
|
it does it in order the way written already and yes I can change the "STD" to "standard" in the assets and the files if needed |
|
@VladimirMakaev so it will already do that to make all the perfect, Thanks! |
|
@VladimirMakaev I reread and now think I understand what you are asking. You want it to be able to pick up all the gems at the same time instead of looping through? |
|
The original implementation was focused on optimizing manipulations you do with your stash. E.g. you have X number of slots in your inventory and you have gems of different colors on 4 tabs of your stash. So the algorithm would be picking somewhat optimal amount of gems of different colors to fill that X number of slots to add up to Y number of perfect gems. The problem with your implementation that you'd
So going back to my example:
While in essense you can pick them all up in 1 go and keep transmuting until you get 1 flawless gem in the end. Which would be quite cool. But if you're not up for this challenge let me know and we can probably merge as is. |
|
@VladimirMakaev im trying to resubmit the required changes. I completely understand what you are asking now so I will work on that for version 2. Thanks for the help and recomendations ;) |
config/params.ini
Outdated
| ; flawed | ||
| ; standard | ||
| ; flawless | ||
| transmute=chipped, flawed, standard, flawless |
There was a problem hiding this comment.
Leave default as 'flawless' please. As it's not "free" to have a wider option
|
I made the requested change Thanks. |
|
@mgleed @VladimirMakaev I made another change and optimize the gem transmute per recommendation. This is to decrease the "cost" and optimize the use of the inventory. |
|
@mgleed Thank you for running the test again, |
|
If one of the contributors can test this I'd be willing to merge. Not able to get on d2 til sunday to test myself |
|
@mgleed ok sounds good, I appreciate it! |
|
I had tested this initially but realized the test case I'd contrived was wrong, leading to error. Deleted my video post from earlier. Tested this about three times with a variety of gems and it works nicely. One way this could be improved is to include logic starting from chipped --> flawless for the number of gems to bring over to be cubed. I.e. if it knows we have 3 flawed gems and 2 normal gems, bring them all over and cube them into each other to make 1 flawless gem. But I don't think that needs to be included in this PR. Nice job @badbrad2889 |
|
@mgleed Thanks for retesting I greatly appreciate it! next implementation I will work on is going to be runes. after I will work on trying to have it grab all the gems at once if you are using that gem and the one above. |
I added the ability to transmute all gems and select which kind of gems you would like to transmute in the params.ini file