Add context to prepareRoutes #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istathar
reviewed
May 10, 2022
| import Core.Webserver.Warp | ||
| import Data.Proxy (Proxy) | ||
| import GHC.Base (Type) | ||
| import Network.Wai (Application) | ||
| import Servant (Handler (..), ServerT) | ||
| import Servant.Server (HasServer, hoistServer, serve) | ||
| import Core.Telemetry.Observability (clearMetrics) | ||
| import Servant.Server (Context (..), HasServer, ServerContext, serveWithContextT) |
There was a problem hiding this comment.
At this point should we make this a qualified import (Servant. presumably), mirroring the pattern elsewhere in this family of libraries? [rather than having to be explicit about Core.Program.Context.Context below]
There was a problem hiding this comment.
@jack-davies sent you jack-davies#1
| prepareRoutes proxy (routes :: ServerT api (Program τ)) = | ||
| prepareRoutes proxy = prepareRoutesWithContext proxy EmptyContext | ||
|
|
||
| prepareRoutesWithContext :: |
There was a problem hiding this comment.
If you want this part of the public API we should add a Haddock documentation, even if it just has
{-|
Prepare routes as above, but providing a Context.
@since 0.1.1
-}
in it.
There was a problem hiding this comment.
(I can do these things if you're busy)
Use qualified imports for servant
|
These changes look sensible. I think this is good to go @istathar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
prepareRoutesWithContextto align with servant'sserveWithContext. Required for servant-auth.