8000 Preserve service name when clearing trace state by istathar · Pull Request #146 · aesiniath/unbeliever · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Preserve service name when clearing trace state #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2022
Merged

Preserve service name when clearing trace state #146

merged 1 commit into from
Aug 9, 2022

Conversation

istathar
Copy link
Member
@istathar istathar commented Aug 9, 2022

When resetting the trace state with clearTrace, don't reset the service name. As commented, the "service name" is set once per process at process startup or once with setServiceName and having to reset it everytime you call clearTrace proved annoying.

@istathar istathar added the core-telemetry Issues involving sending telemetry to an observability service label Aug 9, 2022
@istathar istathar self-assigned this Aug 9, 2022
@istathar istathar merged commit 546e126 into aesiniath:main Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@istathar istathar

Labels
core-telemetry Issues involving sending telemetry to an observability service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@istathar
0