8000 Render numbers properly by istathar · Pull Request #177 · aesiniath/unbeliever · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Render numbers properly #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 20, 2023
Merged

Render numbers properly #177

merged 4 commits into from
Mar 20, 2023

Conversation

istathar
Copy link
Member

When using the Render instance (ie writeR or debugR) on a JsonValue, numbers were showing up as 200.0 even when they weren't floating point. I thought we'd fixed that, and we HAD, but for actually encoding JsonValues to Rope / Bytes! but not when Rendering.

Replicate the trick used when actually encoding in encodeToRope to the Render instance.

@istathar istathar added improvement New feature or request core-data Issues involving the wrappers around data structures labels Mar 20, 2023
@istathar istathar self-assigned this Mar 20, 2023
@istathar istathar merged commit f739957 into aesiniath:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@istathar istathar

Labels
core-data Issues involving the wrappers around data structures improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@istathar
0