Allow for overriding the default honeycomb host #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for situations where the Honeycomb host needs a tweak, such as when using the Refinery: https://docs.honeycomb.io/manage-data-volume/refinery/ Adding support for an environment variable `HONEYCOMB_HOST_OVERRIDE` but still using the default 443 port, and still assuming that the host is behind SSL. Bump core-telemetry to v0.2.8.0
|
|
istathar
requested changes
Feb 16, 2023
|
Cheers @istathar. Thanks for the review. Will do 👍🏼 |
And fix up haddock, which contained a typo
|
Done. Also caught that I had the thing misspelled in the haddock, so that kinda proves that it was indeed a cumbersome name 😄 |
istathar
reviewed
Feb 16, 2023
| appendOption | ||
| ( Variable | ||
| "HONEYCOMB_HOST" | ||
| "Override the default API endpoint for occasions where telemetry needs to be proxied through an intermediate service. Default: api.honeycomb.io" |
There was a problem hiding this comment.
fyi I'm going to change this style to "... service (the default is api.honeycomb.io)." in a future commit, but that can wait.
istathar
reviewed
Feb 16, 2023
istathar
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for situations where the Honeycomb host needs a tweak, such as when using
the Refinery:
https://docs.honeycomb.io/manage-data-volume/refinery/
Adding support for an environment variable
HONEYCOMB_HOST_OVERRIDEbutstill using the default 443 port, and still assuming that the host is
behind SSL.
Bump core-telemetry to v0.2.8.0