8000 add prettyjson output type by philbrookes · Pull Request #66 · aerogear-attic/mobile-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add prettyjson output type #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 7, 2018
Merged

add prettyjson output type #66

merged 2 commits into from
Feb 7, 2018

Conversation

philbrookes
Copy link
Contributor

Describe what this PR does and why we need it:
add prettyjson output option

Changes proposed in this pull request

  • add prettyjson output option

@philbrookes philbrookes requested a review from maleck13 February 6, 2018 15:19
maleck13
maleck13 reviewed Feb 7, 2018
View reviewed changes
Copy link
Contributor
@maleck13 maleck13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want prettyjson as an option? I would be tempted to just leave it at json and pretty print be default. What is the drawback

@philbrookes
Copy link
Contributor Author

@maleck13 I just didn't want to upset the current system, I can change default behaviour alright.

I implemented this as @sedroche suggested it was required for a part of the IDE plugin he is working on. @sedroche any thoughts?

@maleck13
Copy link
Contributor
maleck13 commented Feb 7, 2018

@philbrookes yeah I spoke with @sedroche I think we can just always pretty print, pretty sure this is what the oc tool does also

@philbrookes philbrookes force-pushed the add-pretty-json branch 12 times, most recently from 4617b6d to 69fc466 Compare February 7, 2018 13:53
@philbrookes philbrookes merged commit e8b55a8 into aerogear-attic:master Feb 7, 2018
@wtrocki
Copy link
Contributor
wtrocki commented Feb 7, 2018

@maleck13 @philbrookes Is it ok to release this/integrate changes into mobile?
Just want to know if it's ok to adjust mobile SDK parsers to new format for this sprint or some things will still change? Sending some info to list will be much appreciated.

@maleck13
Copy link
Contributor
maleck13 commented Feb 7, 2018

@wtrocki will create a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maleck13 maleck13 maleck13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philbrookes @maleck13 @wtrocki
0