This repository was archived by the owner on Dec 17, 2024. It is now read-only.
Correctly starting Selenoid from image with custom registry host and … #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
==========================================
+ Coverage 72.88% 72.96% +0.08%
==========================================
Files 4 4
Lines 1180 1180
==========================================
+ Hits 860 861 +1
Misses 214 214
+ Partials 106 105 -1
Continue to review full report at Codecov.
|
lanwen
reviewed
Jan 5, 2020
selenoid/docker.go
Outdated
| @@ -261,6 +261,7 @@ func (c *DockerConfigurator) getImage(name string, version string) *types.ImageS | |||
| c.Errorf("Failed to list images: %v", err) | |||
| return nil | |||
| } | |||
| //name = c.getFullyQualifiedImageRef(name) | |||
There was a problem hiding this comment.
what does it suppose to mean?
There was a problem hiding this comment.
Hmm, accidentally commented stuff. Need to recheck.
8000
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…port (fixes #250)