MDC short send fix #1770
Merged
MDC short send fix #1770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyazelenko
requested changes
Mar 24, 2025
aeron-system-tests/src/test/java/io/aeron/SpySimulatedConnectionTest.java
Outdated
Show resolved
Hide resolved
aeron-system-tests/src/test/java/io/aeron/SpySimulatedConnectionTest.java
Outdated
Show resolved
Hide resolved
vyazelenko
requested changes
Apr 29, 2025
aeron-system-tests/src/test/java/io/aeron/SpySimulatedConnectionTest.java
Outdated
Show resolved
Hide resolved
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Java media driver sets the initial result ('bytes sent' effectively) to the number of bytes to be sent in the two implementations of
MultiSndDestination#send(). The first commit here does the same for the equivalent function in the C media driver. The second commit is a new system test that fails when run against the C media driver before the fix.