add direction for HTML tags #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RTL books must hav dir attribute both in body and HTML tags
|
Correct, will merge this. But I was checking epub3 sample files (https://github.com/IDPF/epub3-samples/blob/master/30/regime-anticancer-arabic/EPUB/Content/C_content.xhtml) and now I see they don't use it on the BODY tag at all. They just have it on the HTML. Clearly, it must be on the HTMl but will check docs to see why we had it on the BODY. Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RTL books must have
dirattribute both in body and HTML tags.