10000 Fix accessing uninitialized member by safocl · Pull Request #177 · aewallin/opencamlib · GitHub

More Web Proxy on the site http://driver.im/

Fix accessing uninitialized member #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

safocl wants to merge 1 commit into aewallin:master from safocl:fix-accessing-uninitialized-member

safocl commented

•

accessing to uninitialized member is undefined behavior (if member function setTolerance is not called).

opencamlib/src/common/lineclfilter.cpp

Line 61 in 95b036f

if((p - *p1).norm() < tol) {

here member tol is erroneous value or indeterminate value

https://eel.is/c++draft/defns.undefined
https://eel.is/c++draft/basic.indet#2
https://eel.is/c++draft/dcl.init.general#1
https://eel.is/c++draft/dcl.init#general-12
https://eel.is/c++draft/dcl.init#general-7.1
https://eel.is/c++draft/class.base.init
https://eel.is/c++draft/class#base.init-example-6

simple example:
https://godbolt.org/z/7s1YEfqhG

please select one of the explicit initialization options for the class member


          Fix accessing uninitialized member

5a8baa2

accessing to uninitialized member is undefined behavior.
https://eel.is/c++draft/defns.undefined
https://eel.is/c++draft/basic.indet#2
https://eel.is/c++draft/dcl.init.general#1
https://eel.is/c++draft/class.base.init
https://eel.is/c++draft/class#base.init-example-6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

0