8000 Use early return in optimizeComponents and avoid using setAttribute followed by removeAttribute by vincentfretin · Pull Request #803 · aframevr/aframe-inspector · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use early return in optimizeComponents and avoid using setAttribute followed by removeAttribute #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2025
Merged

Use early return in optimizeComponents and avoid using setAttribute followed by removeAttribute #803

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/lib/entity.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,12 +209,11 @@ function optimizeComponents(copy, source) {
var doesNotNeedUpdate = optimalUpdate === null;
if (isInherited && doesNotNeedUpdate) {
removeAttribute.call(copy, name);
} else {
var schema = component.schema;
var value = stringifyComponentValue(schema, optimalUpdate);
setAttribute.call(copy, name, value);
return;
}

var schema = component.schema;
var value = stringifyComponentValue(schema, optimalUpdate);
// Remove special components if they use the default value
if (
value === '' &&
Expand All @@ -224,7 +223,10 @@ function optimizeComponents(copy, source) {
name === 'scale')
) {
removeAttribute.call(copy, name);
return;
}

setAttribute.call(copy, name, value);
});
}

Expand Down
Loading
0