feat: add cluster metadata request via aiokafka admin client in ping #2212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
murzinov01
commented
May 15, 2025
Lancetnik
reviewed
May 15, 2025
faststream/kafka/broker/broker.py
Outdated
| if self._admin_client is None: | ||
| return False | ||
|
|
||
| try: |
There was a problem hiding this comment.
I think, we should replace the old logic by new one. Also, this check should respect timeout option
There was a problem hiding this comment.
Ok. I think that in other broker classes(like RabbitMQ and others) the broker.ping should be checked for an example of a similar bug. But this is beyond the scope of my PR. Just keep it mind
murzinov01
commented
May 15, 2025
4dd9972 to
0f95ee6
Compare
|
Tests in |
Lancetnik
previously approved these changes
May 17, 2025
Lancetnik
previously approved these changes
May 18, 2025
…v01/faststream into bugfix/ping_kafka_broker
auto-merge was automatically disabled
May 18, 2025 09:52
Head branch was pushed to by a user without write access
Lancetnik
approved these changes
May 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add request of the kafka cluster metadata via aiokafka.admin.client.AIOKafkaAdminClient in
broker.pingmethod to achieve ping correct work.For now, if you run FastStream application, connected to the Kafka, for example, in docker container and use
broker.pingin /readiness probe you can encounter a bug:After shutting down a Kafka docker container, broker.ping still respond as True value.
I believe that this is wrong behaviour.
More proper and expected decision is to return False or at least raise an Exception in that case.
Fixes # (issue number)
Type of change
Please delete options that are not relevant.
Checklist
scripts/lint.shshows no errors)scripts/test-cov.shscripts/static-analysis.sh