fix(redis): prevent memory leak by deleting acknowledged stream messages, added test coverage for message deletion behaviour #2232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ges, added test coverage for message deletion behavious
|
|
Lancetnik
requested changes
May 26, 2025
| @@ -128,6 +128,7 @@ async def ack( | |||
| ids = self.raw_message["message_ids"] | |||
| channel = self.raw_message["channel"] | |||
| await redis.xack(channel, group, *ids) # type: ignore[no-untyped-call] | |||
| await redis.xdel(channel, *ids) # type: ignore[no-untyped-call] | |||
There was a problem hiding this comment.
Sorry, but this is not that I ment. We shouldn't ack and remove messages by the same call. Also, it shouldn't be a default behavior as well. Please, move this logic to separated message.delete() method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements automatic deletion of Redis Stream messages after acknowledgment to prevent memory accumulation in long-running FastStream applications.
Problem: Redis Stream messages were only being acknowledged (XACK) but never deleted from the stream, causing Redis memory to grow indefinitely as processed messages accumulated.
Solution: Added
XDELcall immediately afterXACKin the_RedisStreamMessageMixin.ack()method to automatically remove messages from the stream after successful processing.Impact: This changes Redis Streams behavior from persistent event log to message queue semantics, preventing memory leaks while maintaining backward compatibility for typical use cases.
Fixes #2223
Type of change
Please delete options that are not relevant.
Checklist
scripts/lint.shshows no errors)scripts/test-cov.shscripts/static-analysis.sh