8000 feat: setup otel tracing by atanmarko · Pull Request #499 · agglayer/agglayer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: setup otel tracing #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: setup otel tracing #499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b88835a
feat: otlp tracing
atanmarko May 28, 2025
bb6085d
fix: format
atanmarko May 29, 2025
7f61e3a
fix: clippy
atanmarko May 29, 2025
cb8c91f
fix: format
atanmarko May 30, 2025
d29bda2
fix: comment
atanmarko Jun 2, 2025
6cc1b46
chore: rename struct
atanmarko Jun 2, 2025
26bf94a
fix: review
atanmarko Jun 4, 2025
c7a6641
fix: review 2
atanmarko Jun 4, 2025
627f929
fix: review 2
atanmarko Jun 4, 2025
5975e1c
fix: format
atanmarko Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
192 changes: 172 additions & 20 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions 8000 & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,13 @@ insta = { git = "https://github.com/freyskeyd/insta", branch = "chore/updating-d
jsonrpsee = { version = "0.24.7", features = ["full"] }
lazy_static = "1.5"
mockall = "0.13.1"
opentelemetry = { version = "0.29.1", features = ["metrics"] }
opentelemetry-otlp = { version = "0.29.0", features = ["trace", "grpc-tonic"]}
opentelemetry-prometheus = "0.29.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The opentelemetry-prometheus crate has not updated for quite some time. The crate description states:

Warning: This crate is no longer recommended for use.

Development of the Prometheus exporter has been discontinued. See the related issue. This crate depends on the unmaintained protobuf crate and has unresolved security vulnerabilities. Version 0.29 will be the final release.

For Prometheus integration, we strongly recommend using the OTLP exporter instead. Prometheus natively supports OTLP, providing a more stable and actively maintained solution.

I see we pull in otlp too. What do we actually rely on opentelemetry-prometheus for? How difficult would it be to remove the dependency altogether?

opentelemetry_sdk = { version = "0.29.0", features = ["metrics", "rt-tokio", "trace"] }
parking_lot = "0.12.3"
pin-project = "1.1"
prometheus = "0.14.0"
prost = "0.13.4"
rand = "0.9.0"
rstest = "0.22.0"
Expand Down
6 changes: 3 additions & 3 deletions crates/agglayer-config/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,23 +24,23 @@ pub mod certificate_orchestrator;
pub mod epoch;
pub(crate) mod l1;
pub(crate) mod l2;
pub mod log;
pub mod outbound;
pub mod rate_limiting;
pub(crate) mod rpc;
pub mod shutdown;
pub mod storage;
pub(crate) mod telemetry;
pub mod tracing;
mod with;

pub use auth::{AuthConfig, GcpKmsConfig, LocalConfig, PrivateKey};
pub use epoch::Epoch;
pub use l1::L1;
pub use l2::L2;
pub use log::Log;
use prover::default_prover_entrypoint;
pub use rate_limiting::RateLimitingConfig;
pub use rpc::RpcConfig;
pub use tracing::TracingConfig;

/// The Agglayer configuration.
#[serde_with::serde_as]
Expand All @@ -65,7 +65,7 @@ pub struct Config {

/// The log configuration.
#[serde(default)]
pub log: Log,
pub log: TracingConfig,

/// The local RPC server configuration.
#[serde(default)]
Expand Down
Loading
Loading
0