8000 feat: refactor settlement logic and use strong types for agglayer-types by Ekleog-Polygon · Pull Request #835 · agglayer/agglayer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: refactor settlement logic and use strong types for agglayer-types #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 47 commits into from
Jun 30, 2025
Merged

feat: refactor settlement logic and use strong types for agglayer-types #835

merged 47 commits into from
Jun 30, 2025

Conversation

Ekleog-Polygon
Copy link
Contributor
@Ekleog-Polygon Ekleog-Polygon commented Jun 4, 2025 •
edited
Loading

Fixes https://github.com/agglayer/protocol-research/issues/148
Fixes #661

Builds on top of #819

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@Ekleog-Polygon Ekleog-Polygon self-assigned this Jun 4, 2025
iljakuklic
iljakuklic reviewed Jun 4, 2025
View reviewed changes
Copy link
Contributor
@iljakuklic iljakuklic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just first pass over some of the new stronger types. These are mostly suggestions and can be done as a follow up or ignored.

@Ekleog-Polygon Ekleog-Polygon requested a review from iljakuklic June 5, 2025 11:49
iljakuklic
iljakuklic reviewed Jun 10, 2025
View reviewed changes
Copy link
Contributor
@iljakuklic iljakuklic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another pass over the strong type changes

iljakuklic
iljakuklic reviewed Jun 13, 2025
View reviewed changes
Copy link
Contributor
@iljakuklic iljakuklic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workflow question: How does this relate to #819? Seems a number of changes is duplicate among the two PRs. Could #819 be made target of this branch?

@Ekleog-Polygon
Copy link
Contributor Author
Ekleog-Polygon commented Jun 16, 2025 •
edited
Loading

This PR actually builds on top of #819 (as per the PR description 😝). So yes, all changes from #819 are also duplicated here, it's also the reason why I've left it as draft until #819 lands and we can easily review the diff between this and main-then. This being said, thank you very much for your reviews, that are helping me start to improve on this PR even before #819 lands 😄

(As for making #819 the target of this branch, last time I tried that, when I merged the base github completely broke my PR and I had to reopen it. So I decided to just keep both targeting main, leave this one as draft, and just merge main into this branch once #819 will have merged-in; that should hopefully work fine)

@Ekleog-Polygon Ekleog-Polygon marked this pull request as ready for review June 25, 2025 16:38
@Ekleog-Polygon Ekleog-Polygon requested a review from a team as a code owner June 25, 2025 16:38
@Ekleog-Polygon Ekleog-Polygon requested a review from Freyskeyd June 25, 2025 16:38
Freyskeyd
Freyskeyd requested changes Jun 26, 2025
View reviewed changes
@Ekleog-Polygon @Freyskeyd
Update crates/agglayer-types/src/lib.rs
5905ab0 
Co-authored-by: Simon Paitrault <spaitrault@polygon.technology>
iljakuklic
iljakuklic reviewed Jun 26, 2025
View reviewed changes
atanmarko
atanmarko reviewed Jun 27, 2025
View reviewed changes
iljakuklic
iljakuklic previously approved these changes Jun 27, 2025
View reviewed changes
atanmarko
atanmarko previously approved these 10000 changes Jun 27, 2025
View reviewed changes
@Ekleog-Polygon Ekleog-Polygon dismissed stale reviews from atanmarko and iljakuklic via 6d7a60e June 30, 2025 09:02
atanmarko
atanmarko previously approved these changes Jun 30, 2025
View reviewed changes
@Ekleog-Polygon Ekleog-Polygon requested a review from atanmarko June 30, 2025 09:38
Freyskeyd
Freyskeyd approved these changes Jun 30, 2025
View reviewed changes
@Ekleog-Polygon Ekleog-Polygon added this pull request to the merge queue Jun 30, 2025
Merged via the queue into main with commit df035c8 Jun 30, 2025
25 checks passed
@Ekleog-Polygon Ekleog-Polygon deleted the ekleog/settlement-cleanup branch June 30, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Freyskeyd Freyskeyd Freyskeyd approved these changes

@atanmarko atanmarko atanmarko approved these changes

@iljakuklic iljakuklic Awaiting requested review from iljakuklic

Assignees

@Ekleog-Polygon Ekleog-Polygon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use strong types to semantically differentiate plain data
4 participants
@Ekleog-Polygon @iljakuklic @Freyskeyd @atanmarko
0