feat: use U256 instead of global index #857
Draft
+224
−205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 23, 2025
hadjiszs
commented
Jun 23, 2025
Comment on lines
+47
to
+51
| agglayer-interop = { git = "https://github.com/agglayer/interop.git", branch = "feat/gi-unused-bits" } | ||
| agglayer-interop-types = { git = "https://github.com/agglayer/interop.git", branch = "feat/gi-unused-bits" } | ||
| agglayer-primitives = { git = "https://github.com/agglayer/interop.git", branch = "feat/gi-unused-bits" } | ||
| agglayer-tries = { git = "https://github.com/agglayer/interop.git", branch = "feat/gi-unused-bits" } | ||
| unified-bridge = { git = "https://github.com/agglayer/interop.git", branch = "feat/gi-unused-bits" } |
There was a problem hiding this comment.
todo: points to release tag once ready
hadjiszs
commented
Jun 23, 2025
| global_index: GlobalIndex, | ||
| global_index: U256, |
There was a problem hiding this comment.
@iljakuklic such change is breaking for the serialization/deserialization iirc right? In that case should I just create a new variant with U256 instead of GlobalIndex?
There was a problem hiding this comment.
@iljakuklic such change is breaking for the serialization/deserialization iirc right? In that case should I just create a new variant with
U256instead ofGlobalIndex?
Yep, a new variant is required here.
Once we get the up-to-date interop dependency, I will be able to create a PR taking a snapshot of the structure of these types which will make it easier to spot the incompatibilities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use U256 directly instead of GlobalIndex in order to preserve the values of the padded unused bits.
Companion of:
PR Checklist: