8000 [Add] Initial files for Domain theory by jmougeot · Pull Request #2721 · agda/agda-stdlib · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Add] Initial files for Domain theory #2721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jmougeot
Copy link
Contributor
@jmougeot jmougeot commented May 26, 2025

This draft pull request introduces three new files under src/Relation/Binary/Domain, providing foundational modules for domain theory in the Agda standard library. The new modules include definitions and structures such as DCPO, Lub, and ScottContinuous, aiming to extend the library's support for domain-theoretic formalizations. This is an initial draft and feedback is welcome on the design and implementation.
This is an import from the 1Lab library.

The definition of Lub provided here is likely better placed elsewhere in the library and may require a different name. For further discussion, see issue #2717.

@jamesmckinna
Copy link
Contributor

Any particular reason to introduce this material as a separate sub-hierarchy under Relation.Binary.Domain?

@JacquesCarette
Copy link
Contributor

Any particular reason to introduce this material as a separate sub-hierarchy under Relation.Binary.Domain?

Increased findability, because of the occurrence of Domain, I would think. This is a port from 1lab, where it uses an Order hierarchy where we "bury" a lot of stuff down into Relation.Binary. In retrospect, I think 1lab's scheme is better.

In any case, for agda-stdlib, the clear precedent is that Lattice hierarchy, which this follows.

record IsDirectedFamily {Ix : Set c} (s : Ix → Carrier) : Set (c ⊔ ℓ₁ ⊔ ℓ₂) where
no-eta-equality
field
elt : Ix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does elt stand for?

Copy link
Contributor Author
@jmougeot jmougeot Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elt stands for element, should I change it ?

record IsDCPO : Set (suc (c ⊔ ℓ₁ ⊔ ℓ₂)) where
field
⋁ : ∀ {Ix : Set c}
→ (s : Ix → Carrier)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the standard formatting for laying out types over multiple lines (see the library style guide)

A B : Set a


module _ {c ℓ₁ ℓ₂ : Level} (P : Poset c ℓ₁ ℓ₂) where
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these definitions really need a Poset or just a relation? I don't immediately see the use of any of the other fields of Poset below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0