8000 Relax dependency bound to `split < 0.3` by andreasabel · Pull Request #6912 · agda/agda · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

Relax dependency bound to split < 0.3 #6912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2023
Merged

Relax dependency bound to split < 0.3 #6912

merged 1 commit into from
Oct 10, 2023

Conversation

andreasabel
Copy link
Member
@andreasabel andreasabel commented Oct 10, 2023 •
edited
Loading

I am not sure what the reason was to have an upper bound that is not a
major version (we had first < 0.2.3.4 and then < 0.2.4).

NB: The PVP recommends a minor upper bound (< 0.2.4) only in case that
we define an orphan instance for a type or class defined in the dependency.

Triggered by this issue:

Question to @ice1000 about upper bound at be1c62d#r129587723.

@andreasabel
Relax dependency bound to split < 0.3
d70d993 
I am not sure what the reason was to have an upper bound that is not a
major version (we had first `< 0.2.3.4` and then `< 0.2.4`).

NB: The PVP recommends a minor upper bound (`< 0.2.4`) only in case that
we define an orphan instance for a type or class defined in the dependency.

Triggered by this issue:
- commercialhaskell/stackage#7141
@andreasabel andreasabel added this to the 2.6.4.1 milestone Oct 10, 2023
@andreasabel andreasabel self-assigned this Oct 10, 2023
@andreasabel andreasabel added the dependencies Pull requests that update a dependency file label Oct 10, 2023
ice1000
ice1000 approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member
@ice1000 ice1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's because that's the latest version back then. I didn't know about the convention

@andreasabel
Copy link
Member Author

@ice1000: Thanks for the quick feedback!
Going ahead then...

@andreasabel andreasabel merged commit d70d993 into master Oct 10, 2023
@andreasabel andreasabel deleted the split-0.2.4 branch November 30, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ice1000 ice1000 ice1000 approved these changes

Assignees

@andreasabel andreasabel

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
2.6.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@andreasabel @ice1000
0