8000
andreasabel
added
the
dev: hlint
About using 'hlint' for code style (not in changelog)
label
Jul 30, 2024
Follow hlint suggestion: use gets #7400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasabel
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry @andreasabel. Yesterday I ran the following command to install
hlint-3.8but somehow ended up with a local build that was not the published version (should have also checked the path to the exe was~/.cabal/bin/hlint) so there's an extra commit (that resets the "warnings triggered" properly) included with this pull request. The "Empty single-line comment" should have been a give away as that is part of ndmitchell/hlint#1459 and not yet included in hlint. I was not being careful enough.The second commit follows the hlint suggestion to use
gets.