8000 Revert default to `--no-save-metas` by andreasabel · Pull Request #7457 · agda/agda · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revert default to --no-save-metas #7457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2024
Merged

Revert default to --no-save-metas #7457

merged 1 commit into from
Sep 2, 2024

Conversation

andreasabel
Copy link
Member
@andreasabel andreasabel commented Aug 28, 2024 •
edited
Loading

Agda 2.7.0 defaulted to --save-metas which caused performance regression #7452:

Thus, we revert to --no-save-metas as default.
Closes #7452.

@andreasabel
Revert default to --no-save-metas
95f5716 
Agda 2.7.0 defaulted to `--save-metas` which caused performance
regression
- #7452

Thus, we revert to `--no-save-metas` as default.
Closes #7452.
@andreasabel andreasabel added this to the 2.7.0.1 milestone Aug 28, 2024
@andreasabel andreasabel added ux: options Issues relating to Agda's command line options save-metas Problems with --save-metas labels Aug 28, 2024
@andreasabel andreasabel self-assigned this Aug 28, 2024
@andreasabel andreasabel merged commit df5d558 into master Sep 2, 2024
29 checks passed
@andreasabel andreasabel deleted the revert-save-metas-default branch September 2, 2024 15:57
@andreasabel
Copy link
Member Author

Cherry-picked onto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@andreasabel andreasabel

Labels
save-metas Problems with --save-metas ux: options Issues relating to Agda's command line options
Projects
None yet
Milestone
2.7.0.1
Development

Successfully merging this pull request may close these issues.

Performance regression caused by making --save-metas the default
1 participant
@andreasabel
0