Make BackendName a Text #7479
Merged
Make BackendName a Text #7479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main motivation for this refactoring was to consistently enforce the type synonym `BackendName`; so I changed it from `String` to `Text`. In the long run, we should deprecate `String` for `Text` everywhere, but this will be another mammut refactoring. Also changed the "installed backends" list into a bullet list in the error for non-existing backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3DF2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main motivation for this refactoring was to consistently enforce the type synonym
BackendName; so I changed it fromStringtoText.In the long run, we should deprecate
StringforTexteverywhere, but this will be another mammut refactoring.Also changed the "installed backends" list into a bullet list in the error for non-existing backend.