8000 [ fix #7503 ] Use principal sort of datatype for checking if split is ok by jespercockx · Pull Request #7504 · agda/agda · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[ fix #7503 ] Use principal sort of datatype for checking if split is ok #7504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2024
Merged

[ fix #7503 ] Use principal sort of datatype for checking if split is ok #7504

merged 1 commit into from
Sep 19, 2024

Conversation

jespercockx
Copy link
Member

Fixes #7503

@andreasabel
Copy link
Member

Ah good!
Would make sense to add #7503 as testcase as well...

@andreasabel andreasabel added prop Prop, definitional proof irrelevance cumulativity "Universe subtyping", inference of levels with --cumulativity, etc labels Sep 19, 2024
@andreasabel andreasabel added this to the 2.8.0 milestone Sep 19, 2024
@jespercockx
Copy link
Member Author

Would make sense to add #7503 as testcase as well...

Yeah I thought so too but then I saw that PropCumulative.agda is already almost exactly the same test, so I'm not sure if it's really worth duplicating.

@andreasabel
Copy link
Member

Ok, then let's merge!

@andreasabel andreasabel merged commit 768c61e into agda:master Sep 19, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cumulativity "Universe subtyping", inference of levels with --cumulativity, etc prop Prop, definitional proof irrelevance
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

Cumulativity Prop <= Set loses canonicity
2 participants
@jespercockx @andreasabel
0