8000 Update the mongodb driver to 4.0 by harisvsulaiman · Pull Request #1358 · agenda/agenda · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update the mongodb driver to 4.0 #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Aug 5, 2021
Merged

Conversation

harisvsulaiman
Copy link
Member
@harisvsulaiman harisvsulaiman commented Aug 1, 2021
  • Fix type issues,
  • Fix Tests

Resolves #1355

Signed-off-by: Haris Sulaiman <harisvsulaiman@gmail.com>
Signed-off-by: Haris Sulaiman <harisvsulaiman@gmail.com>
Signed-off-by: Haris Sulaiman <harisvsulaiman@gmail.com>
Signed-off-by: Haris Sulaiman <harisvsulaiman@gmail.com>
Signed-off-by: Haris Sulaiman <harisvsulaiman@gmail.com>
Signed-off-by: Haris Sulaiman <harisvsulaiman@gmail.com>
.
Signed-off-by: Haris Sulaiman <harisvsulaiman@gmail.com>
Signed-off-by: Haris Sulaiman <harisvsulaiman@gmail.com>
Signed-off-by: Haris Sulaiman <harisvsulaiman@gmail.com>
Signed-off-by: Haris Sulaiman <harisvsulaiman@gmail.com>
@harisvsulaiman harisvsulaiman requested a review from koresar August 4, 2021 13:57
@harisvsulaiman harisvsulaiman marked this pull request as ready for review August 4, 2021 13:59
Copy link
Member Author

@koresar Can you review this change to support new mongo driver.

Copy link
Contributor
@koresar koresar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update REAMDE and/or History with the upcoming SemVer major release or Agenda. It should sound something like:

In order to support new MongoDB 5.0 and mongodb node.js driver/package the next release of Agenda will be major. The required node version will become >=12. The mongodb dependency version will become >=4.

(Please phrase it better than me, if you can. :) )

Signed-off-by: Haris Sulaiman <harisvsulaiman@gmail.com>
Signed-off-by: Haris Sulaiman <harisvsulaiman@gmail.com>
Signed-off-by: Haris Sulaiman <harisvsulaiman@gmail.com>
Signed-off-by: Haris Sulaiman <harisvsulaiman@gmail.com>
@harisvsulaiman
Copy link
Member Author

@koresar Merging to master beacuse tests run indefenitely due to #1369 . Will Fix after merge

@harisvsulaiman harisvsulaiman merged commit de7ab29 into agenda:master Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility with TypeScript and mongodb@4.0.0 (driver)
2 participants
0