Added serper.dev as new tool with agno toolkit #2673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anuragts hey what else do i need to add or check? thanks a lot |
|
hi can you please check now? @anuragts |
|
Hi @CoderOMaster |
|
@dirkbrnd hey i have added it, let me it know if its good enough? |
|
|
||
| self.api_key = api_key or getenv("SERPER_API_KEY") | ||
| if not self.api_key: | ||
| log_debug("No Serper API key provided") |
There was a problem hiding this comment.
We should raise a value error so user is made aware that API is not set.
raise ValueError("No Serper API key provided")
| def __init__( | ||
| self, | ||
| api_key: str = "", | ||
| gl: str = "us", |
There was a problem hiding this comment.
change this to relevant parameter name: could be 'search_location'
|
Anything we can do to push this through? Serper MCP server unneeded complication. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR incorpates use of serper.dev api tool which works flawless and one of the best while performing google search. I have tested this locally and it worked like charm
Type of change
Checklist
./scripts/format.shand./scripts/validate.sh)Additional Notes
Add any important context (deployment instructions, screenshots, security considerations, etc.)