8000 feat: add logic to track eval runs by manuhortet · Pull Request #3019 · agno-agi/agno · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add logic to track eval runs #3019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: add logic to track eval runs #3019

wants to merge 10 commits into from

Conversation

manuhortet
Copy link
Contributor
  • Add agno/api/evals.py and agno/eval/utils.py: logic to call the API and track evaluations runs
  • Update the Eval classes with a track_results flag and logic to track the runs when needed

@manuhortet manuhortet requested a review from a team as a code owner April 29, 2025 15:12
@manuhortet manuhortet changed the title feat(evals): add logic to track eval runs feat: add logic to track eval runs May 13, 2025
dirkbrnd
dirkbrnd reviewed May 15, 2025
View reviewed changes
libs/agno/agno/eval/reliability.py
@@ -56,6 +58,8 @@ class ReliabilityEval:
file_path_to_save_results: Optional[str] = None
# Enable debug logs
debug_mode: bool = getenv("AGNO_DEBUG", "false").lower() == "true"
# Log the results to the Agno platform
monitoring: bool = getenv("AGNO_MONITOR", "").lower() == "true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also be able to set this on initialize, same as agent/team

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And that parameter should default to True I think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Yes, they can be set on initialization already! we don't overwrite __init__ for this classes but they're decorated w @dataclass
  • Good one, agree, will make it default to True

dirkbrnd
dirkbrnd reviewed May 15, 2025
View reviewed changes
Copy link
Contributor
@dirkbrnd dirkbrnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one last thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirkbrnd dirkbrnd dirkbrnd left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manuhortet @dirkbrnd
0