[fix] Make models stateless #3140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 10, 2025
manuhortet
reviewed
May 12, 2025
Comment on lines
+50
to
+65
| def determine_tools_for_model(self, tools: List[Callable]) -> None: | ||
| if self._tools_for_model is None: | ||
| self._tools_for_model = [] | ||
| self._functions_for_model = {} | ||
|
|
||
| for tool in tools: | ||
| try: | ||
| function_name = tool.__name__ | ||
| if function_name not in self._functions_for_model: | ||
| func = Function.from_callable(tool, strict=True) # type: ignore | ||
| func.strict = True | ||
| self._functions_for_model[func.name] = func | ||
| self._tools_for_model.append({"type": "function", "function": func.to_dict()}) | ||
| log_debug(f"Added function {func.name}") | ||
| except Exception as e: | ||
| log_warning(f"Could not add function {tool}: {e}") |
There was a problem hiding this comment.
we still want the logic to run when self._tools_for_model already has tools, right?
or is it cleaned on exit?
There was a problem hiding this comment.
else can we clarify what the early exit is about? it's a bit obscure rn
There was a problem hiding this comment.
Once it is populated we don't need it to run again.
There was a problem hiding this comment.
It saves on processing time
manuhortet
approved these changes
May 12, 2025
| tools=self._tools_for_model, | ||
| functions=self._functions_for_model, | ||
| tool_choice=self.tool_choice, | ||
| tool_call_limit=self.tool_call_limit, |
There was a problem hiding this comment.
Thinking a general limit could be defined in the Model and be independent of the agent runs. Would be nice DX to set defaults when reusing a model.
model = OpenAIChat(..., tool_call_limit=5)
agent.run(..., tool_call_limit=10) # raises with InvalidLimit (or we use the min)Not blocking, just an idea.
There was a problem hiding this comment.
That is a good idea!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove state like
response_formatandtoolsfrom model state to avoid issues where models are shared between teams/agents.Fixes #3095
Type of change
Checklist
./scripts/format.shand./scripts/validate.sh)Additional Notes
Add any important context (deployment instructions, screenshots, security considerations, etc.)