8000 chore: pull filter data from s3 at runtime by kausmeows · Pull Request #3174 · agno-agi/agno · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: pull filter data from s3 at runtime #3174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 13, 2025
Merged

chore: pull filter data from s3 at runtime #3174

merged 6 commits into from
May 13, 2025

Conversation

kausmeows
Copy link
Contributor
@kausmeows kausmeows commented May 12, 2025 •
edited
Loading

Summary

pull filters data from s3 instead of keeping locally

  • Currently in the path- cookbook/agent_concepts/knowledge/filters/data we have sample data to be used with filters, but to not making forking of repo heavy and bloated its better to pull it from s3 during run-time

(If applicable, issue number: #____)

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Improvement
  • Model update
  • Other:

Checklist

  • Code complies with style guidelines
  • Ran format/validation scripts (./scripts/format.sh and ./scripts/validate.sh)
  • Self-review completed
  • Documentation updated (comments, docstrings)
  • Examples and guides: Relevant cookbook examples have been included or updated (if applicable)
  • Tested in clean environment
  • Tests added/updated (if applicable)

Additional Notes

Add any important context (deployment instructions, screenshots, security considerations, etc.)

@kausmeows kausmeows marked this pull request as ready for review May 12, 2025 21:31
@kausmeows kausmeows requested a review from a team as a code owner May 12, 2025 21:31
manuhortet
manuhortet approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor
@manuhortet manuhortet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one, better to keep the repo light

@dirkbrnd dirkbrnd merged commit 8be975e into main May 13, 2025
3 checks passed
@dirkbrnd dirkbrnd deleted the pull-filters-data-from-s3-instead-of-keeping-locally-ag-3072 branch May 13, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuhortet manuhortet manuhortet approved these changes

@dirkbrnd dirkbrnd dirkbrnd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kausmeows @manuhortet @dirkbrnd
0