feat: custom evaluator agent for accuracy evals #3389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkbrnd
reviewed
Jun 12, 2025
| # This is the agent we will use to perform the evaluation | ||
| evaluator_agent = Agent( | ||
| model=OpenAIChat(id="o4-mini"), | ||
| tools=[CalculatorTools(enable_all=True)], |
There was a problem hiding this comment.
does it need calculator tools?
dirkbrnd
reviewed
Jun 12, 2025
| expected_output="$1,739,130.43", | ||
| ) | ||
|
|
||
| result: Optional[AccuracyResult] = evaluation.run(print_results=True) |
There was a problem hiding this comment.
How do you now access that custom response?
dirkbrnd
reviewed
Jun 12, 2025
| """Check if the evaluator agent is using a custom response model""" | ||
| if not self.evaluator_agent: | ||
| return False | ||
| return self.evaluator_agent.response_model is not AccuracyAgentResponse |
There was a problem hiding this comment.
shouldn't this use isinstance?
There was a problem hiding this comment.
Or actually like type comparison? I'm not sure, just asking
dirkbrnd
reviewed
Jun 12, 2025
| @@ -419,7 +455,11 @@ def run_with_output( | |||
| ) | |||
|
|
|||
| if result is not None: | |||
| self.result.results.append(result) | |||
| if self._using_custom_response(): | |||
| print(f"Evaluator Agent response: {result}") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update to AccuracyEval to support providing a custom evaluator agent.
Type of change
Checklist
./scripts/format.shand./scripts/validate.sh)