feat: Persist events on run response #3548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-events-on-runresponse
…response-agent-name
…-agi/agno into feat/add-events-on-runresponse
…-agi/agno into fix/run-response-agent-name
…-agi/agno into feat/add-events-on-runresponse
…-events-on-runresponse
…-events-on-runresponse
manuhortet
approved these changes
Jun 17, 2025
kausmeows
reviewed
Jun 17, 2025
libs/agno/agno/agent/agent.py
Outdated
| ) | ||
|
|
||
| def _handle_event(self, event: RunResponseEvent, run_response: RunResponse): | ||
| # We only store events that are not run_response_content events | ||
| if self.store_events and event.event != RunEvent.run_response_content.value: |
There was a problem hiding this comment.
Maybe in future there could be more events that we'd want to skip? Maybe we can make a list of which events are persisted and it'll be easier to document them as well that way. Not a big one, but just mentioning.
PERSISTED_EVENTS = {
RunEvent.run_started.value,
RunEvent.run_completed.value,
RunEvent.tool_call_started.value,
RunEvent.tool_call_completed.value,
# ...add others
}
def _handle_event(self, event: RunResponseEvent, run_response: RunResponse):
if self.store_events and event.event in PERSISTED_EVENTS:
if run_response.events is None:
run_response.events = []
run_response.events.append(event)
return eventThere was a problem hiding this comment.
Yeah that is a good idea. I'll make it configurable
ysolanky
reviewed
Jun 17, 2025
| self.save_run_response_to_file(message=message, session_id=session_id) | ||
|
|
||
| if stream_intermediate_steps: |
There was a problem hiding this comment.
This event should remain as the last function executed?
There was a problem hiding this comment.
It won't be stored on the session if I don't make this change
ysolanky
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Give users the option to persist all the events on the final run response so they can see everything that happened.
We explicitly don't do that with content, as that will bloat it too much.
Type of change
Checklist
./scripts/format.shand./scripts/validate.sh)Additional Notes
Add any important context (deployment instructions, screenshots, security considerations, etc.)