8000 Fix endless loop on EOF by apatrushev · Pull Request #213 · aio-libs/aiomonitor · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix endless loop on EOF #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2019
Merged

Fix endless loop on EOF #213

merged 1 commit into from
Nov 4, 2019
+4 −1

Conversation

apatrushev
Copy link
Contributor

What do these changes do?

Fixes issue #128

Are there changes in behavior for the user?

Nope

Related issue number

#128

Checklist

  • [х] I think the code is well written
  • [] Unit tests for the changes exist
  • [] Documentation reflects the changes
  • [?] Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

@codecov
Copy link
codecov bot commented Oct 31, 2019 •
edited
Loading

Codecov Report

Merging #213 into master will decrease coverage by 0.93%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
- Coverage   85.67%   84.73%   -0.94%     
==========================================
  Files           4        4              
  Lines         377      380       +3     
  Branches       45       46       +1     
==========================================
- Hits          323      322       -1     
- Misses         41       44       +3     
- Partials       13       14       +1
Impacted Files Coverage Δ
aiomonitor/monitor.py 81.69% <100%> (-1.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bfd22d...2ff5cd7. Read the comment docs.

jettify
jettify approved these changes Nov 4, 2019
View reviewed changes
Copy link
Member
@jettify jettify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is good catch!

@jettify jettify merged commit 0380988 into aio-libs:master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jettify jettify jettify approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apatrushev @jettify
0