8000 Implement graceful shutdown on Mac by xiantang · Pull Request #618 · air-verse/air · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Implement graceful shutdown on Mac #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

Implement graceful shutdown on Mac #618

wants to merge 8 commits into from

Conversation

xiantang
Copy link
Collaborator
@xiantang xiantang commented Jun 23, 2024 •
edited
Loading

close #534

@sethbrasile
hold cleanup until procKilledCh signal
4d7d7a8
@sethbrasile
signal to procKilledChan in existing deferred func
0dcd9c5
@sethbrasile
without this can't exit when non zero exit code
fec348c 
it seems like `os.Exit(state.ExitCode())` belongs here... but unclear on intent of `e.config.Build.Rerun`

This at least lets you ctrl+c out of error condition instead of killing pid via external means.
@sethbrasile
Revert "without this can't exit when non zero exit code"
7034632 
This reverts commit fec348c.
@sethbrasile
Merge branch 'cosmtrek:master' into master
8e99edc
@xiantang xiantang changed the title Sethbrasile/master https://github.com/air-verse/air/issues/534 Jun 23, 2024
@xiantang xiantang changed the title https://github.com/air-verse/air/issues/534 fix https://github.com/air-verse/air/issues/534 Jun 23, 2024
@codecov Codecov
Copy link
codecov bot commented Jun 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
runner/engine.go 71.13% <100.00%> (+4.46%) ⬆️

... and 2 files with indirect coverage changes

@ccoVeille
Copy link
Contributor

So it's about

Easier for everyone, and allow crossing issue and PR

@xiantang xiantang force-pushed the sethbrasile/master branch from e379ed5 to a759095 Compare June 23, 2024 15:05
@ccoVeille
Copy link
Contributor

Title is not used for resolving and quoting issues and PR relationship.

Especially there were you used an URL and not an hash (and I'm unsure it would have worked anyway)

Description and comments are the perfect candidates when dealing with GitHub relationship

@xiantang xiantang changed the title fix https://github.com/air-verse/air/issues/534 Implement graceful shutdown on Mac Jun 23, 2024
@xiantang xiantang mentioned this pull request Jun 23, 2024
Closed
@xiantang
Copy link
Collaborator Author

Title is not used for resolving and quoting issues and PR relationship.

Especially there were you used an URL and not an hash (and I'm unsure it would have worked anyway)

Description and comments are the perfect candidates when dealing with GitHub relationship

gotcha, thank you

@xiantang xiantang closed this Jun 23, 2024
@xiantang xiantang deleted the sethbrasile/master branch June 23, 2024 15:24
@xiantang xiantang mentioned this pull request Jun 23, 2024
Merged
@ccoVeille
Copy link
Contributor

PR superseeded and replaced by #619

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement graceful shutdown on Mac
3 participants
@xiantang @ccoVeille @sethbrasile
0