8000 Fix Relative Path error on Windows by tusharsadhwani · Pull Request #122 · air-verse/air · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Relative Path error on Windows #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2021
Merged

Fix Relative Path error on Windows #122

merged 1 commit into from
Apr 25, 2021

Conversation

tusharsadhwani
Copy link
Contributor

This error was shown when trying to delete old main.exe file on Windows:

main.go has changed
building...
failed to remove D:\code\flutter\instachat\server\tmp\main.exe, error: remove D:\code\flutter\instachat\server\D:\code\flutter\instachat\server\tmp\main.exe: The filename, directory name, or volume label syntax is incorrect.
running...

This patch fixes that error, locally tested.

@codecov
Copy link
codecov bot commented Nov 16, 2020

Codecov Report

Merging #122 (d0678fb) into master (64d8911) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   32.46%   32.46%           
=======================================
  Files           5        5           
  Lines         499      499           
=======================================
  Hits          162      162           
  Misses        307      307           
  Partials       30       30
Impacted Files Coverage Δ
runner/engine.go 13.16% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64d8911...f5d78fd. Read the comment docs.

@tusharsadhwani
Copy link
Contributor Author

Tested on linux as well, seems good :D

@cosmtrek
Copy link
Collaborator

What's your air.toml and project layout?

@tusharsadhwani
Copy link
Contributor Author
tusharsadhwani commented Nov 21, 2020 •
edited
Loading

@cosmtrek I don't have an air.toml, my main.go is in the root directory, and I run it by just typing air in terminal

@tusharsadhwani tusharsadhwani mentioned this pull request Mar 7, 2021
Closed
@xiantang
Copy link
Collaborator

i have my windows systems now... i will check this feature...
because i meet same issue use air @tusharsadhwani

@xiantang
Copy link
Collaborator

test pass LGTM

@xiantang xiantang merged commit 36d7ddc into air-verse:master Apr 25, 2021
@xiantang
Copy link
Collaborator

image

This was referenced Apr 25, 2021
Closed
Closed
Closed
@kindywu
Copy link
kindywu commented Apr 27, 2021 •
edited
Loading

it still not work ,win10 vscode go1.16。

building...
failed to remove D:\WS\go\demo1\tmp\main.exe, error: remove D:\WS\go\demo1\D:\WS\go\demo1\tmp\main.exe: The filename, directory name, or volume label syntax is incorrect.
running...

image

image

@kindywu kindywu mentioned this pull request Apr 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tusharsadhwani @cosmtrek @xiantang @kindywu
0