Fix dev node #56
Annotations
106 warnings
|
large size difference between variants:
node/src/cli.rs#L73
warning: large size difference between variants
--> node/src/cli.rs:73:1
|
73 | / pub enum Subcommand {
74 | | /// Key management cli utilities
75 | | #[clap(subcommand)]
76 | | Key(sc_cli::KeySubcommand),
| | -------------------------- the second-largest variant contains at least 240 bytes
... |
116 | | Benchmark(frame_benchmarking_cli::BenchmarkCmd),
| | ----------------------------------------------- the largest variant contains at least 592 bytes
117 | | }
| |_^ the entire enum is at least 592 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
|
116 - Benchmark(frame_benchmarking_cli::BenchmarkCmd),
116 + Benchmark(Box<frame_benchmarking_cli::BenchmarkCmd>),
|
|
|
unneeded `return` statement:
node/src/chain_spec/mod.rs#L47
warning: unneeded `return` statement
--> node/src/chain_spec/mod.rs:47:9
|
47 | return RobonomicsFamily::Mainnet;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
47 - return RobonomicsFamily::Mainnet;
47 + RobonomicsFamily::Mainnet
|
|
|
function `get_account_id_from_seed` is never used:
node/src/chain_spec/mod.rs#L79
warning: function `get_account_id_from_seed` is never used
--> node/src/chain_spec/mod.rs:79:8
|
79 | pub fn get_account_id_from_seed<TPublic: Public>(seed: &str) -> robonomics_primitives::AccountId
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
|
function `get_from_seed` is never used:
node/src/chain_spec/mod.rs#L72
warning: function `get_from_seed` is never used
--> node/src/chain_spec/mod.rs:72:8
|
72 | pub fn get_from_seed<TPublic: Public>(seed: &str) -> <TPublic::Pair as Pair>::Public {
| ^^^^^^^^^^^^^
|
|
type alias `AccountPublic` is never used:
node/src/chain_spec/mod.rs#L69
warning: type alias `AccountPublic` is never used
--> node/src/chain_spec/mod.rs:69:10
|
69 | pub type AccountPublic = <robonomics_primitives::Signature as Verify>::Signer;
| ^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
unused import: `sp_runtime::traits::IdentifyAccount`:
node/src/chain_spec/dev.rs#L30
warning: unused import: `sp_runtime::traits::IdentifyAccount`
--> node/src/chain_spec/dev.rs:30:5
|
30 | use sp_runtime::traits::IdentifyAccount;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `sp_core::sr25519`:
node/src/chain_spec/dev.rs#L29
warning: unused import: `sp_core::sr25519`
--> node/src/chain_spec/dev.rs:29:5
|
29 | use sp_core::sr25519;
| ^^^^^^^^^^^^^^^^
|
|
unused import: `serde_json::json`:
node/src/chain_spec/dev.rs#L28
warning: unused import: `serde_json::json`
--> node/src/chain_spec/dev.rs:28:5
|
28 | use serde_json::json;
| ^^^^^^^^^^^^^^^^
|
|
unused imports: `AccountId`, `Balance`, and `CommunityAccount`:
node/src/chain_spec/dev.rs#L25
warning: unused imports: `AccountId`, `Balance`, and `CommunityAccount`
--> node/src/chain_spec/dev.rs:25:29
|
25 | use robonomics_primitives::{AccountId, Balance, CommunityAccount};
| ^^^^^^^^^ ^^^^^^^ ^^^^^^^^^^^^^^^^
|
|
unused imports: `AuraConfig`, `AuraId`, `BalancesConfig`, `DemocracyConfig`, `GrandpaConfig`, `GrandpaId`, `RuntimeGenesisConfig`, `SudoConfig`, and `SystemConfig`:
node/src/chain_spec/dev.rs#L22
warning: unused imports: `AuraConfig`, `AuraId`, `BalancesConfig`, `DemocracyConfig`, `GrandpaConfig`, `GrandpaId`, `RuntimeGenesisConfig`, `SudoConfig`, and `SystemConfig`
--> node/src/chain_spec/dev.rs:22:25
|
22 | wasm_binary_unwrap, AuraConfig, AuraId, BalancesConfig, DemocracyConfig, GrandpaConfig,
| ^^^^^^^^^^ ^^^^^^ ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^
23 | GrandpaId, RuntimeGenesisConfig, SudoConfig, SystemConfig,
| ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^ ^^^^^^^^^^^^
|
|
unused imports: `get_account_id_from_seed` and `get_from_seed`:
node/src/chain_spec/dev.rs#L20
warning: unused imports: `get_account_id_from_seed` and `get_from_seed`
--> node/src/chain_spec/dev.rs:20:13
|
20 | use super::{get_account_id_from_seed, get_from_seed, Extensions};
| ^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
this function has too many arguments (9/7):
node/service/src/parachain.rs#L301
warning: this function has too many arguments (9/7)
--> node/service/src/parachain.rs:301:1
|
301 | #[sc_tracing::logging::prefix_logs_with("Parachain")]
| ^----------------------------------------------------
| |
| _in this procedural macro expansion
| |
302 | | pub async fn new_service<RuntimeApi, RB, BIQ, BIC>(
303 | | parachain_config: Configuration,
304 | | polkadot_config: Configuration,
... |
337 | | bool,
338 | | ) -> Result<Box<dyn ParachainConsensus<Block>>, sc_service::Error>,
| |_______________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: this warning originates in the attribute macro `sc_tracing::logging::prefix_logs_with` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
node/service/src/parachain.rs#L254
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> node/service/src/parachain.rs:254:13
|
254 | &config,
| ^^^^^^^ help: change this to: `config`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
very complex type used. Consider factoring parts into `type` definitions:
node/service/src/parachain.rs#L200
warning: very complex type used. Consider factoring parts into `type` definitions
--> node/service/src/parachain.rs:200:6
|
200 | ) -> Result<
| ______^
201 | | PartialComponents<
202 | | ParachainClient<RuntimeApi>,
203 | | ParachainBackend,
... |
213 | | sc_service::Error,
214 | | >
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
|
this function has too many arguments (12/7):
node/service/src/parachain.rs#L121
warning: this function has too many arguments (12/7)
--> node/service/src/parachain.rs:121:1
|
121 | / pub fn build_open_consensus<RuntimeApi>(
122 | | para_id: ParaId,
123 | | lighthouse_account: AccountId,
124 | | client: Arc<ParachainClient<RuntimeApi>>,
... |
135 | | _force_authoring: bool,
136 | | ) -> Result<Box<dyn ParachainConsensus<Block>>, sc_service::Error>
| |__________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|
|
using `clone` on type `Option<&Registry>` which implements the `Copy` trait:
node/service/src/parachain.rs#L115
warning: using `clone` on type `Option<&Registry>` which implements the `Copy` trait
--> node/service/src/parachain.rs:115:9
|
115 | registry.clone(),
| ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `registry`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
using `clone` on type `Role` which implements the `Copy` trait:
node/service/src/dev.rs#L251
warning: using `clone` on type `Role` which implements the `Copy` trait
--> node/service/src/dev.rs:251:16
|
251 | let role = config.role.clone();
| ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.role`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
node/service/src/dev.rs#L101
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> node/service/src/dev.rs:101:13
|
101 | &config,
| ^^^^^^^ help: change this to: `config`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
very complex type used. Consider factoring parts into `type` definitions:
node/service/src/dev.rs#L58
warning: very complex type used. Consider factoring parts into `type` definitions
--> node/service/src/dev.rs:58:6
|
58 | ) -> Result<
| ______^
59 | | sc_service::PartialComponents<
60 | | FullClient,
61 | | FullBackend,
... |
71 | | ServiceError,
72 | | > {
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
|
unused variable: `is_authority`:
node/service/src/dev.rs#L255
warning: unused variable: `is_authority`
--> node/service/src/dev.rs:255:9
|
255 | let is_authority = config.role.is_authority();
| ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_is_authority`
|
= note: `#[warn(unused_variables)]` on by default
|
|
use of deprecated function `cumulus_client_service::start_full_node`: use start_relay_chain_tasks instead:
node/service/src/parachain.rs#L493
warning: use of deprecated function `cumulus_client_service::start_full_node`: use start_relay_chain_tasks instead
--> node/service/src/parachain.rs:493:9
|
493 | start_full_node(params)?;
| ^^^^^^^^^^^^^^^
|
|
use of deprecated function `cumulus_client_service::start_collator`: use start_relay_chain_tasks instead:
node/service/src/parachain.rs#L479
warning: use of deprecated function `cumulus_client_service::start_collator`: use start_relay_chain_tasks instead
--> node/service/src/parachain.rs:479:9
|
479 | start_collator(params).await?;
| ^^^^^^^^^^^^^^
|
|
use of deprecated function `cumulus_client_service::start_full_node`: use start_relay_chain_tasks instead:
node/service/src/parachain.rs#L30
warning: use of deprecated function `cumulus_client_service::start_full_node`: use start_relay_chain_tasks instead
--> node/service/src/parachain.rs:30:5
|
30 | start_full_node, BuildNetworkParams, CollatorSybilResistance, StartCollatorParams,
| ^^^^^^^^^^^^^^^
|
|
use of deprecated function `cumulus_client_service::start_collator`: use start_relay_chain_tasks instead:
node/service/src/parachain.rs#L29
warning: use of deprecated function `cumulus_client_service::start_collator`: use start_relay_chain_tasks instead
--> node/service/src/parachain.rs:29:70
|
29 | build_network, build_relay_chain_interface, prepare_node_config, start_collator,
| ^^^^^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
unused imports: `AccountId`, `Balance`, `Hash`, and `Nonce`:
node/service/src/dev.rs#L22
warning: unused imports: `AccountId`, `Balance`, `Hash`, and `Nonce`
--> node/service/src/dev.rs:22:29
|
22 | use robonomics_primitives::{AccountId, Balance, Block, Hash, Nonce};
| ^^^^^^^^^ ^^^^^^^ ^^^^ ^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
non-local `impl` definition, `impl` blocks should be written at the same level as their item:
runtime/dev/src/lib.rs#L880
warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item
--> runtime/dev/src/lib.rs:880:13
|
872 | / fn dispatch_benchmark(
873 | | config: frame_benchmarking::BenchmarkConfig
874 | | ) -> Result<Vec<frame_benchmarking::BenchmarkBatch>, sp_runtime::RuntimeString> {
| |_______________________________________________________________________________________- move the `impl` block outside of this associated function `dispatch_benchmark`
...
880 | impl frame_system_benchmarking::Config for Runtime {}
| ^^^^^---------------------------------^^^^^-------
| | |
| | `Runtime` is not local
| `Config` is not local
|
= note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl`
= note: `#[warn(non_local_definitions)]` on by default
|
|
unneeded `return` statement:
runtime/dev/src/lib.rs#L869
warning: unneeded `return` statement
--> runtime/dev/src/lib.rs:869:13
|
869 | return (list, storage_info)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
869 - return (list, storage_info)
869 + (list, storage_info)
|
|
|
this operation has no effect:
runtime/dev/src/lib.rs#L587
warning: this operation has no effect
--> runtime/dev/src/lib.rs:587:37
|
587 | pub const MinimalBid: Balance = 1 * XRT;
| ^^^^^^^ help: consider reducing it to: `XRT`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
|
|
this operation has no effect:
runtime/dev/src/lib.rs#L426
warning: this operation has no effect
--> runtime/dev/src/lib.rs:426:45
|
426 | pub const DataDepositPerByte: Balance = 1 * COASE;
| ^^^^^^^^^ help: consider reducing it to: `COASE`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
|
|
this operation has no effect:
runtime/dev/src/lib.rs#L407
warning: this operation has no effect
--> runtime/dev/src/lib.rs:407:46
|
407 | pub const PreimageBaseDeposit: Balance = 1 * XRT;
| ^^^^^^^ help: consider reducing it to: `XRT`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
|
|
this operation has no effect:
runtime/dev/src/lib.rs#L263
warning: this operation has no effect
--> runtime/dev/src/lib.rs:263:44
|
263 | pub const MinVestedTransfer: Balance = 1 * XRT;
| ^^^^^^^ help: consider reducing it to: `XRT`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
|
|
this operation has no effect:
runtime/dev/src/lib.rs#L206
warning: this operation has no effect
--> runtime/dev/src/lib.rs:206:45
|
206 | pub const ExistentialDeposit: Balance = 1 * COASE;
| ^^^^^^^^^ help: consider reducing it to: `COASE`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
= note: `#[warn(clippy::identity_op)]` on by default
|
|
use of deprecated type alias `sp_runtime::RuntimeString`: Use String or Cow<'static, str> instead:
runtime/dev/src/lib.rs#L874
warning: use of deprecated type alias `sp_runtime::RuntimeString`: Use String or Cow<'static, str> instead
--> runtime/dev/src/lib.rs:874:74
|
874 | ) -> Result<Vec<frame_benchmarking::BenchmarkBatch>, sp_runtime::RuntimeString> {
| ^^^^^^^^^^^^^
|
|
use of deprecated macro `sp_runtime::create_runtime_str`: Use Cow::Borrowed() instead of create_runtime_str!():
runtime/dev/src/lib.rs#L73
warning: use of deprecated macro `sp_runtime::create_runtime_str`: Use Cow::Borrowed() instead of create_runtime_str!()
--> runtime/dev/src/lib.rs:73:5
|
73 | create_runtime_str, generic, impl_opaque_keys,
| ^^^^^^^^^^^^^^^^^^
|
|
use of deprecated macro `create_runtime_str`: Use Cow::Borrowed() instead of create_runtime_str!():
runtime/dev/src/lib.rs#L97
warning: use of deprecated macro `create_runtime_str`: Use Cow::Borrowed() instead of create_runtime_str!()
--> runtime/dev/src/lib.rs:97:16
|
97 | impl_name: create_runtime_str!("robonomics-dev-airalab"),
| ^^^^^^^^^^^^^^^^^^
|
|
use of deprecated macro `create_runtime_str`: Use Cow::Borrowed() instead of create_runtime_str!():
runtime/dev/src/lib.rs#L96
warning: use of deprecated macro `create_runtime_str`: Use Cow::Borrowed() instead of create_runtime_str!()
--> runtime/dev/src/lib.rs:96:16
|
96 | spec_name: create_runtime_str!("robonomics-dev"),
| ^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
unused import: `sp_genesis_builder::PresetId`:
runtime/dev/src/lib.rs#L70
warning: unused import: `sp_genesis_builder::PresetId`
--> runtime/dev/src/lib.rs:70:5
|
70 | use sp_genesis_builder::PresetId;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
this match could be written as a `let` statement:
frame/lighthouse/src/lib.rs#L215
warning: this match could be written as a `let` statement
--> frame/lighthouse/src/lib.rs:215:9
|
215 | / match InherentError::try_from(&INHERENT_IDENTIFIER, error)? {
216 | | o => Some(Err(sp_inherents::Error::Application(Box::from(o)))),
217 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding
= note: `#[warn(clippy::match_single_binding)]` on by default
help: consider using a `let` statement
|
215 ~ let o = InherentError::try_from(&INHERENT_IDENTIFIER, error)?;
216 + Some(Err(sp_inherents::Error::Application(Box::from(o))))
|
|
|
useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`:
frame/lighthouse/src/lib.rs#L100
warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`
--> frame/lighthouse/src/lib.rs:100:19
|
100 | pub fn set(origin: OriginFor<T>, lighthouse: T::AccountId) -> DispatchResultWithPostInfo {
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`:
frame/lighthouse/src/lib.rs#L100
warning: useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`
--> frame/lighthouse/src/lib.rs:100:19
|
100 | pub fn set(origin: OriginFor<T>, lighthouse: T::AccountId) -> DispatchResultWithPostInfo {
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
|
use of deprecated type alias `sp_runtime::RuntimeString`: Use String or Cow<'static, str> instead:
frame/lighthouse/src/lib.rs#L159
warning: use of deprecated type alias `sp_runtime::RuntimeString`: Use String or Cow<'static, str> instead
--> frame/lighthouse/src/lib.rs:159:23
|
159 | Other(sp_runtime::RuntimeString),
| ^^^^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
redundant field names in struct initialization:
frame/lighthouse/src/lib.rs#L128
warning: redundant field names in struct initialization
--> frame/lighthouse/src/lib.rs:128:17
|
128 | lighthouse: lighthouse,
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lighthouse`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
= note: `#[warn(clippy::redundant_field_names)]` on by default
|
|
useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`:
frame/rws/src/lib.rs#L419
warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`
--> frame/rws/src/lib.rs:419:29
|
419 | pub fn start_auction(
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`:
frame/rws/src/lib.rs#L419
warning: useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`
--> frame/rws/src/lib.rs:419:29
|
419 | pub fn start_auction(
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`:
frame/rws/src/lib.rs#L391
warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`
--> frame/rws/src/lib.rs:391:32
|
391 | pub fn set_subscription(
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`:
frame/rws/src/lib.rs#L391
warning: useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`
--> frame/rws/src/lib.rs:391:32
|
391 | pub fn set_subscription(
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`:
frame/rws/src/lib.rs#L372
warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`
--> frame/rws/src/lib.rs:372:26
|
372 | pub fn set_oracle(
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`:
frame/rws/src/lib.rs#L372
warning: useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`
--> frame/rws/src/lib.rs:372:26
|
372 | pub fn set_oracle(
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`:
frame/rws/src/lib.rs#L350
warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`
--> frame/rws/src/lib.rs:350:27
|
350 | pub fn set_devices(
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`:
frame/rws/src/lib.rs#L350
warning: useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`
--> frame/rws/src/lib.rs:350:27
|
350 | pub fn set_devices(
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`:
frame/rws/src/lib.rs#L307
warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`
--> frame/rws/src/lib.rs:307:19
|
307 | pub fn bid(
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`:
frame/rws/src/lib.rs#L307
warning: useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`
--> frame/rws/src/lib.rs:307:19
|
307 | pub fn bid(
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`:
frame/rws/src/lib.rs#L275
warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`
--> frame/rws/src/lib.rs:275:20
|
275 | pub fn call(
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L390
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:390:26
|
390 | #[pallet::weight(100_000)]
| ^^^^^^^ help: omit the `let` binding: `100_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L371
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:371:26
|
371 | #[pallet::weight(100_000)]
| ^^^^^^^ help: omit the `let` binding: `100_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L349
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:349:26
|
349 | #[pallet::weight(100_000)]
| ^^^^^^^ help: omit the `let` binding: `100_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L306
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:306:26
|
306 | #[pallet::weight(100_000)]
| ^^^^^^^ help: omit the `let` binding: `100_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L419
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:419:16
|
419 | pub fn start_auction(
| ^^^^^^^^^^^^^ help: omit the `let` binding: `start_auction;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L391
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:391:16
|
391 | pub fn set_subscription(
| ^^^^^^^^^^^^^^^^ help: omit the `let` binding: `set_subscription;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L372
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:372:16
|
372 | pub fn set_oracle(
| ^^^^^^^^^^ help: omit the `let` binding: `set_oracle;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L350
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:350:16
|
350 | pub fn set_devices(
| ^^^^^^^^^^^ help: omit the `let` binding: `set_devices;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L307
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:307:16
|
307 | pub fn bid(
| ^^^ help: omit the `let` binding: `bid;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L423
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:423:13
|
423 | let _ = ensure_root(origin)?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `ensure_root(origin)?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
|
|
using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait:
frame/rws/src/lib.rs#L334
warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait
--> frame/rws/src/lib.rs:334:38
|
334 | auction.best_price = amount.clone();
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait:
frame/rws/src/lib.rs#L332
warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait
--> frame/rws/src/lib.rs:332:54
|
332 | T::AuctionCurrency::reserve(&sender, amount.clone())?;
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait:
frame/rws/src/lib.rs#L328
warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait
--> frame/rws/src/lib.rs:328:38
|
328 | auction.best_price = amount.clone();
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
frame/rws/src/lib.rs#L326
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> frame/rws/src/lib.rs:326:47
|
326 | T::AuctionCurrency::unreserve(&winner, auction.best_price);
| ^^^^^^^ help: change this to: `winner`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait:
frame/rws/src/lib.rs#L325
warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait
--> frame/rws/src/lib.rs:325:54
|
325 | T::AuctionCurrency::reserve(&sender, amount.clone())?;
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_4::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/rws/src/lib.rs#L418
warning: use of deprecated constant `pallet::warnings::ConstantWeight_4::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/rws/src/lib.rs:418:26
|
418 | #[pallet::weight(100_000)]
| ^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_3::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/rws/src/lib.rs#L390
warning: use of deprecated constant `pallet::warnings::ConstantWeight_3::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/rws/src/lib.rs:390:26
|
390 | #[pallet::weight(100_000)]
| ^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_2::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/rws/src/lib.rs#L371
warning: use of deprecated constant `pallet::warnings::ConstantWeight_2::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/rws/src/lib.rs:371:26
|
371 | #[pallet::weight(100_000)]
| ^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/rws/src/lib.rs#L349
warning: use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/rws/src/lib.rs:349:26
|
349 | #[pallet::weight(100_000)]
| ^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/rws/src/lib.rs#L306
warning: use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/rws/src/lib.rs:306:26
|
306 | #[pallet::weight(100_000)]
| ^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_5::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/rws/src/lib.rs#L419
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_5::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/rws/src/lib.rs:419:16
|
419 | pub fn start_auction(
| ^^^^^^^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_4::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/rws/src/lib.rs#L391
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_4::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/rws/src/lib.rs:391:16
|
391 | pub fn set_subscription(
| ^^^^^^^^^^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_3::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/rws/src/lib.rs#L372
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_3::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/rws/src/lib.rs:372:16
|
372 | pub fn set_oracle(
| ^^^^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_2::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/rws/src/lib.rs#L350
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_2::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/rws/src/lib.rs:350:16
|
350 | pub fn set_devices(
| ^^^^^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_1::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/rws/src/lib.rs#L307
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_1::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/rws/src/lib.rs:307:16
|
307 | pub fn bid(
| ^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_0::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/rws/src/lib.rs#L275
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_0::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/rws/src/lib.rs:275:16
|
275 | pub fn call(
| ^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`:
frame/liability/src/lib.rs#L147
warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`
--> frame/liability/src/lib.rs:147:24
|
147 | pub fn finalize(origin: OriginFor<T>, report: ReportFor<T>) -> DispatchResultWithPostInfo {
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`:
frame/liability/src/lib.rs#L147
warning: useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`
--> frame/liability/src/lib.rs:147:24
|
147 | pub fn finalize(origin: OriginFor<T>, report: ReportFor<T>) -> DispatchResultWithPostInfo {
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`:
frame/liability/src/lib.rs#L119
warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`
--> frame/liability/src/lib.rs:119:22
|
119 | pub fn create(origin: OriginFor<T>, agreement: T::Agreement) -> DispatchResultWithPostInfo {
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
this let-binding has unit value:
frame/liability/src/lib.rs#L145
warning: this let-binding has unit value
--> frame/liability/src/lib.rs:145:26
|
145 | #[pallet::weight(200_000)]
| ^^^^^^^ help: omit the `let` binding: `200_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
binary comparison to literal `Option::None`:
frame/liability/src/lib.rs#L156
warning: binary comparison to literal `Option::None`
--> frame/liability/src/lib.rs:156:17
|
156 | <ReportOf<T>>::get(index) == None,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `<ReportOf<T>>::get(index).is_none()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
= note: `#[warn(clippy::partialeq_to_none)]` on by default
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/liability/src/lib.rs#L145
warning: use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/liability/src/lib.rs:145:26
|
145 | #[pallet::weight(200_000)]
| ^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/liability/src/lib.rs#L117
warning: use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/liability/src/lib.rs:117:26
|
117 | #[pallet::weight(200_000)]
| ^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
this `else { if .. }` block can be collapsed:
frame/liability/src/signed.rs#L76
warning: this `else { if .. }` block can be collapsed
--> frame/liability/src/signed.rs:76:16
|
76 | } else {
| ________________^
77 | | if C::unreserve(&self.promisee, self.economics.price) == self.economics.price {
78 | | Ok(())
79 | | } else {
... |
82 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if
= note: `#[warn(clippy::collapsible_else_if)]` on by default
help: collapse nested if block
|
76 ~ } else if C::unreserve(&self.promisee, self.economics.price) == self.economics.price {
77 + Ok(())
78 + } else {
79 + Err("reserved less than expected")?
80 + }
|
|
|
useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`:
frame/digital-twin/src/lib.rs#L84
warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`
--> frame/digital-twin/src/lib.rs:84:26
|
84 | pub fn set_source(
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `frame_support::sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`:
frame/digital-twin/src/lib.rs#L84
warning: useless conversion to the same type: `frame_support::sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`
--> frame/digital-twin/src/lib.rs:84:26
|
84 | pub fn set_source(
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`:
frame/digital-twin/src/lib.rs#L73
warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`
--> frame/digital-twin/src/lib.rs:73:22
|
73 | pub fn create(origin: OriginFor<T>) -> DispatchResultWithPostInfo {
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
this let-binding has unit value:
frame/digital-twin/src/lib.rs#L83
warning: this let-binding has unit value
--> frame/digital-twin/src/lib.rs:83:26
|
83 | #[pallet::weight(50_000)]
| ^^^^^^ help: omit the `let` binding: `50_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/digital-twin/src/lib.rs#L72
warning: this let-binding has unit value
--> frame/digital-twin/src/lib.rs:72:26
|
72 | #[pallet::weight(50_000)]
| ^^^^^^ help: omit the `let` binding: `50_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/digital-twin/src/lib.rs#L84
warning: this let-binding has unit value
--> frame/digital-twin/src/lib.rs:84:16
|
84 | pub fn set_source(
| ^^^^^^^^^^ help: omit the `let` binding: `set_source;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`:
frame/datalog/src/lib.rs#L131
warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`
--> frame/datalog/src/lib.rs:131:21
|
131 | pub fn erase(origin: OriginFor<T>) -> DispatchResultWithPostInfo {
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `frame_support::sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`:
frame/datalog/src/lib.rs#L131
warning: useless conversion to the same type: `frame_support::sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`
--> frame/datalog/src/lib.rs:131:21
|
131 | pub fn erase(origin: OriginFor<T>) -> DispatchResultWithPostInfo {
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`:
frame/datalog/src/lib.rs#L108
warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`
--> frame/datalog/src/lib.rs:108:22
|
108 | pub fn record(origin: OriginFor<T>, record: T::Record) -> DispatchResultWithPostInfo {
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `frame_support::sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`:
frame/datalog/src/lib.rs#L108
warning: useless conversion to the same type: `frame_support::sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`
--> frame/datalog/src/lib.rs:108:22
|
108 | pub fn record(origin: OriginFor<T>, record: T::Record) -> DispatchResultWithPostInfo {
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#u
57AE
seless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
|
the borrowed expression implements the required traits:
frame/datalog/src/lib.rs#L152
warning: the borrowed expression implements the required traits
--> frame/datalog/src/lib.rs:152:50
|
152 | let mut idx = DatalogIndex::<T>::get(&account);
| ^^^^^^^^ help: change this to: `account`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/digital-twin/src/lib.rs#L83
warning: use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/digital-twin/src/lib.rs:83:26
|
83 | #[pallet::weight(50_000)]
| ^^^^^^
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/digital-twin/src/lib.rs#L72
warning: use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/digital-twin/src/lib.rs:72:26
|
72 | #[pallet::weight(50_000)]
| ^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_1::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/digital-twin/src/lib.rs#L84
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_1::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/digital-twin/src/lib.rs:84:16
|
84 | pub fn set_source(
| ^^^^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_0::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/digital-twin/src/lib.rs#L73
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_0::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/digital-twin/src/lib.rs:73:16
|
73 | pub fn create(origin: OriginFor<T>) -> DispatchResultWithPostInfo {
| ^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`:
frame/launch/src/lib.rs#L60
warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`
--> frame/launch/src/lib.rs:60:22
|
60 | pub fn launch(
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`:
frame/launch/src/lib.rs#L60
warning: useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`
--> frame/launch/src/lib.rs:60:22
|
60 | pub fn launch(
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
|
this let-binding has unit value:
frame/launch/src/lib.rs#L58
warning: this let-binding has unit value
--> frame/launch/src/lib.rs:58:26
|
58 | #[pallet::weight(500_000)]
| ^^^^^^^ help: omit the `let` binding: `500_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/launch/src/lib.rs#L58
warning: use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/launch/src/lib.rs:58:26
|
58 | #[pallet::weight(500_000)]
| ^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|