Optimized RWS storage, removed devices functions (use proxy instead) #78
Annotations
1 error and 92 warnings
|
fmt
Process completed with exit code 1.
|
|
check-license
Config does not cover the file 'Cargo.lock'
|
|
check-license
Config does not cover the file 'Cargo.toml'
|
|
check-license
Config does not cover the file 'Dockerfile'
|
|
check-license
Config does not cover the file 'LICENSE'
|
|
check-license
Config does not cover the file 'NOTICE'
|
|
check-license
Config does not cover the file 'README.adoc'
|
|
check-license
Config does not cover the file 'SECURITY.md'
|
|
check-license
Config does not cover the file 'rust-toolchain.toml'
|
|
check-license
Config does not cover the file 'shell.nix'
|
|
check-license
Config does not cover the file 'web3_foundation_grants_badge_black.jpg'
|
|
large size difference between variants:
node/src/cli.rs#L73
warning: large size difference between variants
--> node/src/cli.rs:73:1
|
73 | / pub enum Subcommand {
74 | | /// Key management cli utilities
75 | | #[clap(subcommand)]
76 | | Key(sc_cli::KeySubcommand),
| | -------------------------- the second-largest variant contains at least 240 bytes
... |
116 | | Benchmark(frame_benchmarking_cli::BenchmarkCmd),
| | ----------------------------------------------- the largest variant contains at least 592 bytes
117 | | }
| |_^ the entire enum is at least 592 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
|
116 - Benchmark(frame_benchmarking_cli::BenchmarkCmd),
116 + Benchmark(Box<frame_benchmarking_cli::BenchmarkCmd>),
|
|
|
unneeded `return` statement:
node/src/chain_spec/mod.rs#L45
warning: unneeded `return` statement
--> node/src/chain_spec/mod.rs:45:9
|
45 | return RobonomicsFamily::Mainnet;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
45 - return RobonomicsFamily::Mainnet;
45 + RobonomicsFamily::Mainnet
|
|
|
this function has too many arguments (9/7):
node/service/src/parachain.rs#L304
warning: this function has too many arguments (9/7)
--> node/service/src/parachain.rs:304:1
|
304 | #[sc_tracing::logging::prefix_logs_with("Parachain")]
| ^----------------------------------------------------
| |
| _in this procedural macro expansion
| |
305 | | pub async fn new_service<RuntimeApi, RB, BIQ, BIC>(
306 | | parachain_config: Configuration,
307 | | polkadot_config: Configuration,
... |
340 | | bool,
341 | | ) -> Result<Box<dyn ParachainConsensus<Block>>, sc_service::Error>,
| |_______________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: this warning originates in the attribute macro `sc_tracing::logging::prefix_logs_with` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
node/service/src/parachain.rs#L256
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> node/service/src/parachain.rs:256:13
|
256 | &config,
| ^^^^^^^ help: change this to: `config`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
very complex type used. Consider factoring parts into `type` definitions:
node/service/src/parachain.rs#L202
warning: very complex type used. Consider factoring parts into `type` definitions
--> node/service/src/parachain.rs:202:6
|
202 | ) -> Result<
| ______^
203 | | PartialComponents<
204 | | ParachainClient<RuntimeApi>,
205 | | ParachainBackend,
... |
215 | | sc_service::Error,
216 | | >
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
|
this function has too many arguments (12/7):
node/service/src/parachain.rs#L123
warning: this function has too many arguments (12/7)
--> node/service/src/parachain.rs:123:1
|
123 | / pub fn build_open_consensus<RuntimeApi>(
124 | | para_id: ParaId,
125 | | lighthouse_account: AccountId,
126 | | client: Arc<ParachainClient<RuntimeApi>>,
... |
137 | | _force_authoring: bool,
138 | | ) -> Result<Box<dyn ParachainConsensus<Block>>, sc_service::Error>
| |__________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|
|
using `clone` on type `Option<&Registry>` which implements the `Copy` trait:
node/service/src/parachain.rs#L117
warning: using `clone` on type `Option<&Registry>` which implements the `Copy` trait
--> node/service/src/parachain.rs:117:9
|
117 | registry.clone(),
| ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `registry`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
using `clone` on type `Role` which implements the `Copy` trait:
node/service/src/dev.rs#L226
warning: using `clone` on type `Role` which implements the `Copy` trait
--> node/service/src/dev.rs:226:16
|
226 | let role = config.role.clone();
| ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.role`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
node/service/src/dev.rs#L101
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> node/service/src/dev.rs:101:13
|
101 | &config,
| ^^^^^^^ help: change this to: `config`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
very complex type used. Consider factoring parts into `type` definitions:
node/service/src/dev.rs#L58
warning: very complex type used. Consider factoring parts into `type` definitions
--> node/service/src/dev.rs:58:6
|
58 | ) -> Result<
| ______^
59 | | sc_service::PartialComponents<
60 | | FullClient,
61 | | FullBackend,
... |
71 | | ServiceError,
72 | | > {
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
|
unused variable: `prometheus_registry`:
node/service/src/parachain.rs#L365
warning: unused variable: `prometheus_registry`
--> node/service/src/parachain.rs:365:9
|
365 | let prometheus_registry = parachain_config.prometheus_registry().cloned();
| ^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_prometheus_registry`
|
|
unused variable: `force_authoring`:
node/service/src/parachain.rs#L363
warning: unused variable: `force_authoring`
--> node/service/src/parachain.rs:363:9
|
363 | let force_authoring = parachain_config.force_authoring;
| ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_force_authoring`
|
|
unused variable: `collator_key`:
node/service/src/parachain.rs#L352
warning: unused variable: `collator_key`
--> node/service/src/parachain.rs:352:33
|
352 | let (relay_chain_interface, collator_key) = build_relay_chain_interface(
| ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_collator_key`
|
|
unused variable: `block_import`:
node/service/src/parachain.rs#L347
warning: unused variable: `block_import`
--> node/service/src/parachain.rs:347:10
|
347 | let (block_import, mut telemetry, telemetry_worker_handle) = params.other;
| ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_block_import`
|
|
unused variable: `build_consensus`:
node/service/src/parachain.rs#L313
warning: unused variable: `build_consensus`
--> node/service/src/parachain.rs:313:5
|
313 | build_consensus: BIC,
| ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_build_consensus`
|
|
unused variable: `lighthouse_account`:
node/service/src/parachain.rs#L310
warning: unused variable: `lighthouse_account`
--> node/service/src/parachain.rs:310:5
|
310 | lighthouse_account: AccountId,
| ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_lighthouse_account`
|
= note: `#[warn(unused_variables)]` on by default
|
|
unused import: `ParachainHostFunctions`:
node/service/src/parachain.rs#L30
warning: unused import: `ParachainHostFunctions`
--> node/service/src/parachain.rs:30:69
|
30 | BuildNetworkParams, CollatorSybilResistance, DARecoveryProfile, ParachainHostFunctions,
| ^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
non-local `impl` definition, `impl` blocks should be written at the same level as their item:
runtime/dev/src/lib.rs#L873
warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item
--> runtime/dev/src/lib.rs:873:13
|
865 | / fn dispatch_benchmark(
866 | | config: frame_benchmarking::BenchmarkConfig
867 | | ) -> Result<Vec<frame_benchmarking::BenchmarkBatch>, sp_runtime::RuntimeString> {
| |_______________________________________________________________________________________- move the `impl` block outside of this associated function `dispatch_benchmark`
...
873 | impl frame_system_benchmarking::Config for Runtime {}
| ^^^^^---------------------------------^^^^^-------
| | |
| | `Runtime` is not local
| `Config` is not local
|
= note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl`
= note: `#[warn(non_local_definitions)]` on by default
|
|
unneeded `return` statement:
runtime/dev/src/lib.rs#L862
warning: unneeded `return` statement
--> runtime/dev/src/lib.rs:862:13
|
862 | return (list, storage_info)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
862 - return (list, storage_info)
862 + (list, storage_info)
|
|
|
this operation has no effect:
runtime/dev/src/lib.rs#L585
warning: this operation has no effect
--> runtime/dev/src/lib.rs:585:37
|
585 | pub const MinimalBid: Balance = 1 * XRT;
| ^^^^^^^ help: consider reducing it to: `XRT`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
|
|
this operation has no effect:
runtime/dev/src/lib.rs#L426
warning: this operation has no effect
--> runtime/dev/src/lib.rs:426:45
|
426 | pub const DataDepositPerByte: Balance = 1 * COASE;
| ^^^^^^^^^ help: consider reducing it to: `COASE`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
|
|
this operation has no effect:
runtime/dev/src/lib.rs#L407
warning: this operation has no effect
--> runtime/dev/src/lib.rs:407:46
|
407 | pub const PreimageBaseDeposit: Balance = 1 * XRT;
| ^^^^^^^ help: consider reducing it to: `XRT`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
|
|
this operation has no effect:
runtime/dev/src/lib.rs#L263
warning: this operation has no effect
--> runtime/dev/src/lib.rs:263:44
|
263 | pub const MinVestedTransfer: Balance = 1 * XRT;
| ^^^^^^^ help: consider reducing it to: `XRT`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
|
|
this operation has no effect:
runtime/dev/src/lib.rs#L206
warning: this operation has no effect
--> runtime/dev/src/lib.rs:206:45
|
206 | pub const ExistentialDeposit: Balance = 1 * COASE;
| ^^^^^^^^^ help: consider reducing it to: `COASE`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
= note: `#[warn(clippy::identity_op)]` on by default
|
|
use of deprecated type alias `sp_runtime::RuntimeString`: Use String or Cow<'static, str> instead:
runtime/dev/src/lib.rs#L867
warning: use of deprecated type alias `sp_runtime::RuntimeString`: Use String or Cow<'static, str> instead
--> runtime/dev/src/lib.rs:867:74
|
867 | ) -> Result<Vec<frame_benchmarking::BenchmarkBatch>, sp_runtime::RuntimeString> {
| ^^^^^^^^^^^^^
|
|
use of deprecated macro `sp_runtime::create_runtime_str`: Use Cow::Borrowed() instead of create_runtime_str!():
runtime/dev/src/lib.rs#L73
warning: use of deprecated macro `sp_runtime::create_runtime_str`: Use Cow::Borrowed() instead of create_runtime_str!()
--> runtime/dev/src/lib.rs:73:5
|
73 | create_runtime_str, generic, impl_opaque_keys,
| ^^^^^^^^^^^^^^^^^^
|
|
use of deprecated macro `create_runtime_str`: Use Cow::Borrowed() instead of create_runtime_str!():
runtime/dev/src/lib.rs#L97
warning: use of deprecated macro `create_runtime_str`: Use Cow::Borrowed() instead of create_runtime_str!()
--> runtime/dev/src/lib.rs:97:16
|
97 | impl_name: create_runtime_str!("robonomics-dev-airalab"),
| ^^^^^^^^^^^^^^^^^^
|
|
use of deprecated macro `create_runtime_str`: Use Cow::Borrowed() instead of create_runtime_str!():
runtime/dev/src/lib.rs#L96
warning: use of deprecated macro `create_runtime_str`: Use Cow::Borrowed() instead of create_runtime_str!()
--> runtime/dev/src/lib.rs:96:16
|
96 | spec_name: create_runtime_str!("robonomics-dev"),
| ^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
unused import: `sp_genesis_builder::PresetId`:
runtime/dev/src/lib.rs#L70
warning: unused import: `sp_genesis_builder::PresetId`
--> runtime/dev/src/lib.rs:70:5
|
70 | use sp_genesis_builder::PresetId;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
this match could be written as a `let` statement:
frame/lighthouse/src/lib.rs#L215
warning: this match could be written as a `let` statement
--> frame/lighthouse/src/lib.rs:215:9
|
215 | / match InherentError::try_from(&INHERENT_IDENTIFIER, error)? {
216 | | o => Some(Err(sp_inherents::Error::Application(Box::from(o)))),
217 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding
= note: `#[warn(clippy::match_single_binding)]` on by default
help: consider using a `let` statement
|
215 ~ let o = InherentError::try_from(&INHERENT_IDENTIFIER, error)?;
216 + Some(Err(sp_inherents::Error::Application(Box::from(o))))
|
|
|
useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`:
frame/lighthouse/src/lib.rs#L100
warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`
--> frame/lighthouse/src/lib.rs:100:19
|
100 | pub fn set(origin: OriginFor<T>, lighthouse: T::AccountId) -> DispatchResultWithPostInfo {
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
use of deprecated type alias `sp_runtime::RuntimeString`: Use String or Cow<'static, str> instead:
frame/lighthouse/src/lib.rs#L159
warning: use of deprecated type alias `sp_runtime::RuntimeString`: Use String or Cow<'static, str> instead
--> frame/lighthouse/src/lib.rs:159:23
|
159 | Other(sp_runtime::RuntimeString),
| ^^^^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
redundant field names in struct initialization:
frame/lighthouse/src/lib.rs#L128
warning: redundant field names in struct initialization
--> frame/lighthouse/src/lib.rs:128:17
|
128 | lighthouse: lighthouse,
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lighthouse`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
= note: `#[warn(clippy::redundant_field_names)]` on by default
|
|
very complex type used. Consider factoring parts into `type` definitions:
frame/rws/src/lib.rs#L208
warning: very complex type used. Consider factoring parts into `type` definitions
--> frame/rws/src/lib.rs:208:15
|
208 | #[pallet::storage]
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
|
useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`:
frame/rws/src/lib.rs#L404
warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`
--> frame/rws/src/lib.rs:404:29
|
404 | pub fn start_auction(
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`:
frame/rws/src/lib.rs#L404
warning: useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`
--> frame/rws/src/lib.rs:404:29
|
404 | pub fn start_auction(
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`:
frame/rws/src/lib.rs#L342
warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`
--> frame/rws/src/lib.rs:342:21
|
342 | pub fn claim(
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`:
frame/rws/src/lib.rs#L342
warning: useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`
--> frame/rws/src/lib.rs:342:21
|
342 | pub fn claim(
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`:
frame/rws/src/lib.rs#L295
warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`
--> frame/rws/src/lib.rs:295:19
|
295 | pub fn bid(
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`:
frame/rws/src/lib.rs#L295
warning: useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`
--> frame/rws/src/lib.rs:295:19
|
295 | pub fn bid(
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`:
frame/rws/src/lib.rs#L234
warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`
--> frame/rws/src/lib.rs:234:20
|
234 | pub fn call(
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`:
frame/rws/src/lib.rs#L234
warning: useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`
--> frame/rws/src/lib.rs:234:20
|
234 | pub fn call(
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L408
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:408:13
|
408 | let _ = ensure_root(origin)?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `ensure_root(origin)?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
|
|
the borrowed expression implements the required traits:
frame/rws/src/lib.rs#L387
warning: the borrowed expression implements the required traits
--> frame/rws/src/lib.rs:387:31
|
387 | <Auction<T>>::set(&auction_id, Some(auction));
| ^^^^^^^^^^^ help: change this to: `auction_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
frame/rws/src/lib.rs#L381
warning: the borrowed expression implements the required traits
--> frame/rws/src/lib.rs:381:17
|
381 | &subscription_id,
| ^^^^^^^^^^^^^^^^ help: change this to: `subscription_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
frame/rws/src/lib.rs#L351
warning: the borrowed expression implements the required traits
--> frame/rws/src/lib.rs:351:49
|
351 | let mut auction = <Auction<T>>::get(&auction_id).ok_or(Error::<T>::NotExistAuction)?;
| ^^^^^^^^^^^ help: change this to: `auction_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
frame/rws/src/lib.rs#L328
warning: the borrowed expression implements the required traits
--> frame/rws/src/lib.rs:328:31
|
328 | <Auction<T>>::set(&auction_id, Some(auction));
| ^^^^^^^^^^^ help: change this to: `auction_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait:
frame/rws/src/lib.rs#L326
warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait
--> frame/rws/src/lib.rs:326:38
|
326 | auction.best_price = amount.clone();
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait:
frame/rws/src/lib.rs#L324
warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait
--> frame/rws/src/lib.rs:324:54
|
324 | T::AuctionCurrency::reserve(&sender, amount.clone())?;
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait:
frame/rws/src/lib.rs#L318
warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait
--> frame/rws/src/lib.rs:318:38
|
318 | auction.best_price = amount.clone();
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
frame/rws/src/lib.rs#L316
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> frame/rws/src/lib.rs:316:47
|
316 | T::AuctionCurrency::unreserve(&winner, auction.best_price);
| ^^^^^^^ help: change this to: `winner`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait:
frame/rws/src/lib.rs#L315
warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait
--> frame/rws/src/lib.rs:315:54
|
315 | T::AuctionCurrency::reserve(&sender, amount.clone())?;
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
|
the borrowed expression implements the required traits:
frame/rws/src/lib.rs#L304
warning: the borrowed expression implements the required traits
--> frame/rws/src/lib.rs:304:49
|
304 | let mut auction = <Auction<T>>::get(&auction_id).ok_or(Error::<T>::NotExistAuction)?;
| ^^^^^^^^^^^ help: change this to: `auction_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
frame/rws/src/lib.rs#L273
warning: the borrowed expression implements the required traits
--> frame/rws/src/lib.rs:273:49
|
273 | <Subscription<T>>::set(&sender, &subscription_id, Some(subscription));
| ^^^^^^^^^^^^^^^^ help: change this to: `subscription_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
frame/rws/src/lib.rs#L269
warning: the borrowed expression implements the required traits
--> frame/rws/src/lib.rs:269:49
|
269 | <Subscription<T>>::set(&sender, &subscription_id, Some(subscription));
| ^^^^^^^^^^^^^^^^ help: change this to: `subscription_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
frame/rws/src/lib.rs#L243
warning: the borrowed expression implements the required traits
--> frame/rws/src/lib.rs:243:68
|
243 | let mut subscription = <Subscription<T>>::get(&sender, &subscription_id)
| ^^^^^^^^^^^^^^^^ help: change this to: `subscription_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
|
useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`:
frame/digital-twin/src/lib.rs#L84
warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`
--> frame/digital-twin/src/lib.rs:84:26
|
84 | pub fn set_source(
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `frame_support::sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`:
frame/digital-twin/src/lib.rs#L84
warning: useless conversion to the same type: `frame_support::sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`
--> frame/digital-twin/src/lib.rs:84:26
|
84 | pub fn set_source(
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`:
frame/digital-twin/src/lib.rs#L73
warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`
--> frame/digital-twin/src/lib.rs:73:22
|
73 | pub fn create(origin: OriginFor<T>) -> DispatchResultWithPostInfo {
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `frame_support::sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`:
frame/digital-twin/src/lib.rs#L73
warning: useless conversion to the same type: `frame_support::sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`
--> frame/digital-twin/src/lib.rs:73:22
|
73 | pub fn create(origin: OriginFor<T>) -> DispatchResultWithPostInfo {
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
|
this let-binding has unit value:
frame/digital-twin/src/lib.rs#L83
warning: this let-binding has unit value
--> frame/digital-twin/src/lib.rs:83:26
|
83 | #[pallet::weight(50_000)]
| ^^^^^^ help: omit the `let` binding: `50_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/digital-twin/src/lib.rs#L72
warning: this let-binding has unit value
--> frame/digital-twin/src/lib.rs:72:26
|
72 | #[pallet::weight(50_000)]
| ^^^^^^ help: omit the `let` binding: `50_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/digital-twin/src/lib.rs#L84
warning: this let-binding has unit value
--> frame/digital-twin/src/lib.rs:84:16
|
84 | pub fn set_source(
| ^^^^^^^^^^ help: omit the `let` binding: `set_source;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/digital-twin/src/lib.rs#L83
warning: use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/digital-twin/src/lib.rs:83:26
|
83 | #[pallet::weight(50_000)]
| ^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_0::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/digital-twin/src/lib.rs#L73
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_0::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/digital-twin/src/lib.rs:73:16
|
73 | pub fn create(origin: OriginFor<T>) -> DispatchResultWithPostInfo {
| ^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`:
frame/liability/src/lib.rs#L147
warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`
--> frame/liability/src/lib.rs:147:24
|
147 | pub fn finalize(origin: OriginFor<T>, report: ReportFor<T>) -> DispatchResultWithPostInfo {
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`:
frame/liability/src/lib.rs#L147
warning: useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`
--> frame/liability/src/lib.rs:147:24
|
147 | pub fn finalize(origin: OriginFor<T>, report: ReportFor<T>) -> DispatchResultWithPostInfo {
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`:
frame/liability/src/lib.rs#L119
warning: useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`
--> frame/liability/src/lib.rs:119:22
|
119 | pub fn create(origin: OriginFor<T>, agreement: T::Agreement) -> DispatchResultWithPostInfo {
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
|
this let-binding has unit value:
frame/liability/src/lib.rs#L145
warning: this let-binding has unit value
--> frame/liability/src/lib.rs:145:26
|
145 | #[pallet::weight(200_000)]
| ^^^^^^^ help: omit the `let` binding: `200_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/liability/src/lib.rs#L117
warning: this let-binding has unit value
--> frame/liability/src/lib.rs:117:26
|
117 | #[pallet::weight(200_000)]
| ^^^^^^^ help: omit the `let` binding: `200_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
|
|
binary comparison to literal `Option::None`:
frame/liability/src/lib.rs#L156
warning: binary comparison to literal `Option::None`
--> frame/liability/src/lib.rs:156:17
|
156 | <ReportOf<T>>::get(index) == None,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `<ReportOf<T>>::get(index).is_none()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
= note: `#[warn(clippy::partialeq_to_none)]` on by default
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/liability/src/lib.rs#L145
warning: use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/liability/src/lib.rs:145:26
|
145 | #[pallet::weight(200_000)]
| ^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/liability/src/lib.rs#L117
warning: use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/liability/src/lib.rs:117:26
|
117 | #[pallet::weight(200_000)]
| ^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
this `else { if .. }` block can be collapsed:
frame/liability/src/signed.rs#L76
warning: this `else { if .. }` block can be collapsed
--> frame/liability/src/signed.rs:76:16
|
76 | } else {
| ________________^
77 | | if C::unreserve(&self.promisee, self.economics.price) == self.economics.price {
78 | | Ok(())
79 | | } else {
... |
82 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if
= note: `#[warn(clippy::collapsible_else_if)]` on by default
help: collapse nested if block
|
76 ~ } else if C::unreserve(&self.promisee, self.economics.price) == self.economics.price {
77 + Ok(())
78 + } else {
79 + Err("reserved less than expected")?
80 + }
|
|
|
useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`:
frame/launch/src/lib.rs#L60
warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`
--> frame/launch/src/lib.rs:60:22
|
60 | pub fn launch(
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`:
frame/launch/src/lib.rs#L60
warning: useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`
--> frame/launch/src/lib.rs:60:22
|
60 | pub fn launch(
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
|
this let-binding has unit value:
frame/launch/src/lib.rs#L58
warning: this let-binding has unit value
--> frame/launch/src/lib.rs:58:26
|
58 | #[pallet::weight(500_000)]
| ^^^^^^^ help: omit the `let` binding: `500_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/launch/src/lib.rs#L58
warning: use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/launch/src/lib.rs:58:26
|
58 | #[pallet::weight(500_000)]
| ^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
useless conversion to the same type: `frame_support::sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`:
frame/datalog/src/lib.rs#L131
warning: useless conversion to the same type: `frame_support::sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`
--> frame/datalog/src/lib.rs:131:21
|
131 | pub fn erase(origin: OriginFor<T>) -> DispatchResultWithPostInfo {
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`:
frame/datalog/src/lib.rs#L108
warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo`
--> frame/datalog/src/lib.rs:108:22
|
108 | pub fn record(origin: OriginFor<T>, record: T::Record) -> DispatchResultWithPostInfo {
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
useless conversion to the same type: `frame_support::sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`:
frame/datalog/src/lib.rs#L108
warning: useless conversion to the same type: `frame_support::sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>`
--> frame/datalog/src/lib.rs:108:22
|
108 | pub fn record(origin: OriginFor<T>, record: T::Record) -> DispatchResultWithPostInfo {
| ^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
|
the borrowed expression implements the required traits:
frame/datalog/src/lib.rs#L152
warning: the borrowed expression implements the required traits
--> frame/datalog/src/lib.rs:152:50
|
152 | let mut idx = DatalogIndex::<T>::get(&account);
| ^^^^^^^^ help: change this to: `account`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|